Improve TSQLConnection.GetAsSQLText methods in sqldb.pp
Original Reporter info from Mantis: lacak @lacak.sk
-
Reporter name: LacaK
Original Reporter info from Mantis: lacak @lacak.sk
- Reporter name: LacaK
Description:
Please add also support for ftFixedChar and ftCurrency,ftBcd,ftFMTBcd param types:
-ftString : Result := '''' + param.asstring + '''';
+ftFixedChar,
+ftString : Result := '''' + param.asstring + '''';
Here I am not sure what happens if Param.AsString will contain quote ... IMHO some escaping of quotes inside string must be also performed!
...
-ftFloat : Result := '''' + FloatToStr(Param.AsFloat, FSQLServerFormatSettings) + ''''
+ftCurrency,
+ftBcd,
+ftFMTBcd,
+ftFloat : Result := FloatToStr(Param.AsFloat, FSQLServerFormatSettings)
Here I do not know why numbers are quoted, IMHO without quotes will it be better !?