| Anonymous | Login | Signup for a new account | 2013-05-24 04:45 CEST |  |
| All Projects | FPC | Lazarus: Packages, Patches | Lazarus CCR | Mantis | fpGUI | fpcprojects: fpprofiler |
| Main | My View | View Issues | Change Log | Roadmap |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0020543 | FPC | FCL | public | 2011-10-23 02:26 | 2012-04-22 00:53 | ||||
| Reporter | J. Gareth Moreton | ||||||||
| Assigned To | Marco van de Voort | ||||||||
| Priority | normal | Severity | tweak | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | Product Build | ||||||||
| Target Version | Fixed in Version | 2.7.1 | |||||||
| Summary | 0020543: TFPReadPNG - Chunk should be 'protected' | ||||||||
| Description | Given that HandleChunk is virtual and possibly designed that way so descendent classes can handle custom PNG chunks, wouldn't it be logical to make the Chunk variable protected rather than private? | ||||||||
| Additional Information | Unit: FPReadPNG Class: TFPReadPNG | ||||||||
| Tags | bitmaps, fpc | ||||||||
| FPCOldBugId | 0 | ||||||||
| Fixed in Revision | 20969 | ||||||||
| Attached Files | |||||||||
 Relationships |
|
 Relationships |
|
Notes |
|
|
(0053317) Zeljan Rikalo (reporter) 2011-10-23 12:06 |
Isn't this fpc thing ? |
|
(0053319) Vincent Snijders (manager) 2011-10-23 12:19 |
Yes, it is part of fcl-image, so I move this issue to the fpc project. |
|
(0053329) J. Gareth Moreton (reporter) 2011-10-23 17:26 |
My mistake. |
|
(0053355) Marco van de Voort (manager) 2011-10-24 09:51 edited on: 2011-10-24 09:51 |
Or add a property as done for headerchunk. Michael, what do you prefer ? |
|
(0053591) J. Gareth Moreton (reporter) 2011-10-29 20:18 |
The problem there is that Chunk is very volatile and in most cases will probably equal IEND; the only time it doesn't is during the numerous calls to HandleChunk. |
|
(0058860) Marco van de Voort (manager) 2012-04-22 00:53 |
No reaction so I made it protected |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-10-23 02:26 | J. Gareth Moreton | New Issue | |
| 2011-10-23 02:26 | J. Gareth Moreton | Widgetset | => Win32/Win64 |
| 2011-10-23 02:44 | J. Gareth Moreton | Note Added: 0053313 | |
| 2011-10-23 03:16 | J. Gareth Moreton | Note Deleted: 0053313 | |
| 2011-10-23 03:56 | J. Gareth Moreton | Tag Attached: bitmaps | |
| 2011-10-23 03:56 | J. Gareth Moreton | Tag Attached: fpc | |
| 2011-10-23 12:06 | Zeljan Rikalo | Note Added: 0053317 | |
| 2011-10-23 12:19 | Vincent Snijders | Note Added: 0053319 | |
| 2011-10-23 12:19 | Vincent Snijders | Project | Lazarus => FPC |
| 2011-10-23 15:14 | Florian | FPCOldBugId | => 0 |
| 2011-10-23 15:14 | Florian | Category | LCL => FCL |
| 2011-10-23 15:14 | Florian | Product Version | 0.9.30.2RC1 => |
| 2011-10-23 17:26 | J. Gareth Moreton | Note Added: 0053329 | |
| 2011-10-24 09:51 | Marco van de Voort | Note Added: 0053355 | |
| 2011-10-24 09:51 | Marco van de Voort | Note Edited: 0053355 | |
| 2011-10-29 20:18 | J. Gareth Moreton | Note Added: 0053591 | |
| 2012-04-22 00:53 | Marco van de Voort | Fixed in Revision | => 20969 |
| 2012-04-22 00:53 | Marco van de Voort | Status | new => resolved |
| 2012-04-22 00:53 | Marco van de Voort | Fixed in Version | => 2.7.1 |
| 2012-04-22 00:53 | Marco van de Voort | Resolution | open => fixed |
| 2012-04-22 00:53 | Marco van de Voort | Assigned To | => Marco van de Voort |
| 2012-04-22 00:53 | Marco van de Voort | Note Added: 0058860 | |
|
Issue History |
| Main | My View | View Issues | Change Log | Roadmap |
