View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0021766LazarusLCLpublic2012-04-13 23:032012-04-19 16:23
ReporterDavid Jenkins 
Assigned ToJuha Manninen 
PrioritynormalSeveritytweakReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.9.30.5 (SVN)Product Build 
Target VersionFixed in Version 
Summary0021766: Optimize ImageList drawing by removing RefreshControl in TToolButton.SetImageIndex
DescriptionWe'd like to remove the call to RefreshControl in TToolButton.SetImageIndex. This call causes the toolbar to check for resize each time a image index is updated and can slow things down significantly. An imagelist should have all same size images. Changing index therefore should not change image size / button size, and toolbar should not need to be sized.

Suggested implementation in patches attached (created against rev 36681)
TagsNo tags attached.
Fixed in Revisionr36785
LazTarget-
WidgetsetCarbon
Attached Filespatch file icon toolbutton.inc.patch [^] (328 bytes) 2012-04-13 23:03 [Show Content]

- Relationships

-  Notes
(0058606)
Juha Manninen (developer)
2012-04-15 09:02

The file path in the patch should be relative to Lazarus root dir.
This is a one line patch and I can easily make the change manually but bigger patches will be a problem.
How did you create the patch?

***

$ patch -p0 < ~/patch/toolbutton.inc.patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- /Users/djenkins/laz-changes/13631/toolbutton.inc 2012-04-09 15:03:49.000000000
|+++ /Users/djenkins/laz-changes/13631/toolbutton.inc.ss 2012-04-09 15:05:22.000000000
--------------------------
File to patch: ^C
(0058607)
Juha Manninen (developer)
2012-04-15 09:47

Applied, thanks.
In my tests it works well but it must be tested for possible side-effects.
(0058735)
David Jenkins (reporter)
2012-04-19 00:32

I'm reopening this one just long enough to add back in a note that got deleted by accident responding to the question by @Juha about the patch.

All these patches were created using the text_report/patch feature of beyond compare with 'unified diff' setting. This is the same as using linux diff to create a unified patch. The problem being seen is a path problem: it is not relative and not based on laz root. Future patches I will make relative to laz root and I will coalesce all patches for a feature into one file.

Thanks for applying this one manually
(0058737)
David Jenkins (reporter)
2012-04-19 00:35

This works with my tests as well and can be reclosed (I lost my closing powers when I reopened).
(0058741)
Juha Manninen (developer)
2012-04-19 06:51

Thanks. Resolving...

- Issue History
Date Modified Username Field Change
2012-04-13 23:03 David Jenkins New Issue
2012-04-13 23:03 David Jenkins File Added: toolbutton.inc.patch
2012-04-13 23:03 David Jenkins Widgetset => Carbon
2012-04-15 09:02 Juha Manninen Note Added: 0058606
2012-04-15 09:47 Juha Manninen Fixed in Revision => r36785
2012-04-15 09:47 Juha Manninen LazTarget => -
2012-04-15 09:47 Juha Manninen Status new => resolved
2012-04-15 09:47 Juha Manninen Resolution open => fixed
2012-04-15 09:47 Juha Manninen Assigned To => Juha Manninen
2012-04-15 09:47 Juha Manninen Note Added: 0058607
2012-04-19 00:29 David Jenkins Status resolved => closed
2012-04-19 00:32 David Jenkins Status closed => assigned
2012-04-19 00:32 David Jenkins Resolution fixed => reopened
2012-04-19 00:32 David Jenkins Note Added: 0058735
2012-04-19 00:32 David Jenkins Note Added: 0058736
2012-04-19 00:33 David Jenkins Note Deleted: 0058736
2012-04-19 00:35 David Jenkins Note Added: 0058737
2012-04-19 06:51 Juha Manninen Status assigned => resolved
2012-04-19 06:51 Juha Manninen Resolution reopened => fixed
2012-04-19 06:51 Juha Manninen Note Added: 0058741
2012-04-19 16:23 David Jenkins Status resolved => closed



MantisBT 1.2.12[^]
Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker