| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0021976 | Lazarus CCR | Virtual Treeview | public | 2012-05-07 12:12 | 2012-05-14 18:43 |
|
| Reporter | cobines | |
| Assigned To | Luiz Americo | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | Linux i386 | OS | Debian | OS Version | Sid |
|
| Summary | 0021976: VTVDragManager unneccesarily created on non-Windows with DragType=dtVCL |
| Description | VTVDragManager is created on non-Windows even with DragType=dtVCL but it is not implemented and after drag&drop operation it for example prevents scrolling in DoTimerScroll (DoSetOffsetXY is not called).
VTVDragManager is created in TBaseVirtualTree.DragOver because there is a missing check for FDragManager <> nil.
You can test with attached project on Linux, but you need to hardcode InRect to True in DoTimerScroll because MapWindowPoints is not implemented:
1. Move mouse at the bottom of the Tree, scrolling should start.
2. Start dragging some node and after dragging starts release mouse.
3. Move mouse at the bottom of the Tree, scrolling does not start anymore.
Patch against trunk is attached. |
| Tags | No tags attached. |
|
| Widgetset | |
|
| Attached Files |  vtv_scroll.zip [^] (2,591 bytes) 2012-05-07 12:12
 vtvdragmanager_nocreate.diff [^] (565 bytes) 2012-05-07 12:13 [Show Content] [Hide Content]Index: VirtualTrees.pas
===================================================================
--- VirtualTrees.pas (wersja 2420)
+++ VirtualTrees.pas (kopia robocza)
@@ -19872,7 +19872,7 @@
begin
//{$ifdef DEBUG_VTV}Logger.EnterMethod([lcDrag],'DragOver');{$endif}
- if not VTVDragManager.DropTargetHelperSupported and (Source is TBaseVirtualTree) then
+ if Assigned(FDragManager) and not VTVDragManager.DropTargetHelperSupported and (Source is TBaseVirtualTree) then
begin
Tree := Source as TBaseVirtualTree;
ScrollOptions := [suoUpdateNCArea];
|
|
Relationships 
Relationships 