0021984: [Patch] "FileUtil.FileSetDateUTF8" failed to work with Unicode FileName/Directory

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Tags

No tags attached.

Fixed in Revision

37794

LazTarget

Widgetset

Win32/Win64

Attached Files

2012-05-08 - FileSetDateUTF8 (Patch).patch [^] (1,175 bytes) 2012-05-08 07:50 [Show Content] [Hide Content]

Index: fileutil.inc
===================================================================
--- fileutil.inc	(revision 37216)
+++ fileutil.inc	(working copy)
@@ -95,8 +95,29 @@
 end;
 
 function FileSetDateUTF8(const FileName: String; Age: Longint): Longint;
+{$IFDEF Windows}
+ Function ADosTimeToWinTime (DosTime:longint;Var Wintime : TFileTime):longbool;
+ var
+  lft : TFileTime;
+ begin
+  ADosTimeToWinTime:=DosDateTimeToFileTime(longrec(DosTime).hi,longrec(DosTime).lo,@lft) and
+                                           LocalFileTimeToFileTime(lft,Wintime);
+ end;
+var
+ FT:TFileTime;
+{$ENDIF}
 begin
+ {$IFDEF WINDOWS}
+   if (ADosTimeToWinTime(Age,FT) and
+    SetFileTime(CreateFileW(PWideChar(UTF8Decode(FileName)),
+                                            FILE_WRITE_ATTRIBUTES,
+                                            0, nil, OPEN_EXISTING,
+                                            FILE_ATTRIBUTE_NORMAL, 0),
+                                            nil, nil, @FT)) then Exit;
+  Result := GetLastError;
+ {$ELSE}
   Result:=SysUtils.FileSetDate(UTF8ToSys(Filename),Age);
+ {$ENDIF}
 end;
 
 function ParamStrUTF8(Param: Integer): string;

2012-05-08 - FileSetDateUTF8 (Patch)2.patch [^] (1,353 bytes) 2012-05-10 06:41 [Show Content] [Hide Content]

Index: fileutil.inc
===================================================================
--- fileutil.inc	(revision 37234)
+++ fileutil.inc	(working copy)
@@ -95,9 +95,36 @@
 end;
 
 function FileSetDateUTF8(const FileName: String; Age: Longint): Longint;
+{$IFDEF Windows}
+ {$ifdef WindowsUnicodeSupport}
+ Function ADosTimeToWinTime (DosTime:longint;Var Wintime : TFileTime):longbool;
+ var
+  lft : TFileTime;
+ begin
+  ADosTimeToWinTime:=DosDateTimeToFileTime(longrec(DosTime).hi,longrec(DosTime).lo,@lft) and
+                                           LocalFileTimeToFileTime(lft,Wintime);
+ end;
+var
+ FT:TFileTime;
+  {$endif}
+{$ENDIF}
 begin
+ {$IFDEF WINDOWS}
+  {$ifdef WindowsUnicodeSupport}
+   if (ADosTimeToWinTime(Age,FT) and
+    SetFileTime(CreateFileW(PWideChar(UTF8ToUTF16(FileName)),
+                                            FILE_WRITE_ATTRIBUTES,
+                                            0, nil, OPEN_EXISTING,
+                                            FILE_ATTRIBUTE_NORMAL, 0),
+                                            nil, nil, @FT)) then Exit;
+   Result := GetLastError;
+  {$else}
+   Result:=SysUtils.FileSetDate(UTF8ToSys(Filename),Age);
+  {$endif}
+ {$ELSE}
   Result:=SysUtils.FileSetDate(UTF8ToSys(Filename),Age);
-end;
+ {$ENDIF}
+end;  
 
 function ParamStrUTF8(Param: Integer): string;
 begin

Relationships

Notes
(0059443) Bart Broersma (developer) 2012-05-09 18:30	Proposed patch will completely break FileSetDateUTF8() on win9x, since CreateFileW will return an OS error 6 (in Dutch: "De ingang is ongeldig", which probably translates into "Invalid entry") for each and every filename (wether they contain Unicode characters or not).

(0059453) Takeda Matsuki (reporter) 2012-05-10 03:53	Mr. Bart ; I have a little question : Is recent stable FPC still support Win9x by default? If Yes, I would try to check it and might create patch to make it would work on Win9x. ;) > ... CreateFileW will return an OS error 6 ... This OS Bugs or my patch? coz the attched patch, work fine here. I have 3 PCs with Japanese Language, Korean Language, and English. -Takeda-

(0059456) Takeda Matsuki (reporter) 2012-05-10 06:40 edited on: 2012-05-10 06:45	Now, I know what Mr. Bart mean and Yes Mr. Bart true -> "... which probably translates into "Invalid entry".. ". I found UTF8Decode and UTF8Encode which come from FPC higher than 2.6.0/2.6.0a (especially which came from FPC 2.7.1) failed to work (sometime). I test 23 times, sometime UTF8Decode/Encode would give me "?????" My Directory to test -> " C:\New folder (2)\아이\อยู่ห่างๆอย่างห่วง ๆ ", using UTF8Decode/Encode from FPC higher than 2.6.0/2.6.0a would give me " C:\New folder (2)\????\?????? ". In my patch ( 2012-05-08 - FileSetDateUTF8 (Patch)2.patch ), I decide to use UTF8ToUTF16, and it working fine. Also, it would work with win9x. ;) -Takeda-

(0059472) Bart Broersma (developer) 2012-05-10 19:28	> Is recent stable FPC still support Win9x by default? Yes, Win98 and WinMe are still supported. Win95 is not supported out of the box, it needs patching.

(0059563) Bart Broersma (developer) 2012-05-13 16:27	Second patch at least works on WinMe.

(0060691) Felipe Monteiro de Carvalho (developer) 2012-06-27 09:07	thanks, applied

Issue History
Date Modified	Username	Field	Change
2012-05-08 07:50	Takeda Matsuki	New Issue
2012-05-08 07:50	Takeda Matsuki	File Added: 2012-05-08 - FileSetDateUTF8 (Patch).patch
2012-05-08 07:50	Takeda Matsuki	Widgetset	=> Win32/Win64
2012-05-09 17:08	Felipe Monteiro de Carvalho	Status	new => assigned
2012-05-09 17:08	Felipe Monteiro de Carvalho	Assigned To	=> Felipe Monteiro de Carvalho
2012-05-09 18:30	Bart Broersma	Note Added: 0059443
2012-05-10 03:53	Takeda Matsuki	Note Added: 0059453
2012-05-10 06:40	Takeda Matsuki	Note Added: 0059456
2012-05-10 06:41	Takeda Matsuki	File Added: 2012-05-08 - FileSetDateUTF8 (Patch)2.patch
2012-05-10 06:42	Takeda Matsuki	Note Edited: 0059456
2012-05-10 06:45	Takeda Matsuki	Note Edited: 0059456
2012-05-10 19:28	Bart Broersma	Note Added: 0059472
2012-05-13 16:27	Bart Broersma	Note Added: 0059563
2012-06-27 09:07	Felipe Monteiro de Carvalho	Fixed in Revision	=> 37794
2012-06-27 09:07	Felipe Monteiro de Carvalho	LazTarget	=> -
2012-06-27 09:07	Felipe Monteiro de Carvalho	Status	assigned => resolved
2012-06-27 09:07	Felipe Monteiro de Carvalho	Fixed in Version	=> 1.1 (SVN)
2012-06-27 09:07	Felipe Monteiro de Carvalho	Resolution	open => fixed
2012-06-27 09:07	Felipe Monteiro de Carvalho	Note Added: 0060691

lazarus bugtracker

Open source GUI RAD IDE for Free Pascal