[Test] Minor refactoring of bcase.pp
Original Reporter info from Mantis: CuriousKit @CuriousKit
-
Reporter name: J. Gareth Moreton
Original Reporter info from Mantis: CuriousKit @CuriousKit
- Reporter name: J. Gareth Moreton
Description:
A couple of minor changes were made to remove compiler notes:
- GetRealTime - function is now surrounded with {push}{
warn 5057 off}...{$pop} to suppress the note that 'st' is uninitialised (its initial contents don't matter when it's passed into GetLocalTime).
- TCStyleCascade.DoTestIteration - the variable P was never used (and was erroneously copied from another method) and so has been removed.
Additionally, the file "tests/test/tcase49.pp" that includes bcase.pp now specifies { %OPT=-O2 } because the tests are designed to evaluate optimised jump table generation and the like, and some of the branch redirections require -O2 in order to be applied, since they're not very debugger-friendly.
Steps to reproduce:
Overwrite tests/bench/bcase.pp with the attachment and confirm identical behaviour.
Overwrite tests/test/tcase49.pp with the attachment and confirm that the test runs as expected.
Additional information:
I would have supplied a patch file, but I was unable to create one that didn't degenerately remove every single line and then re-add them, resulting in a patch that was double the size of the original source file. Sorry!
Mantis conversion info:
- Mantis ID: 35633
- OS: Microsoft Windows
- OS Build: 10 Professional
- Build: 42124
- Platform: Cross-platform
- Version: 3.3.1
- Fixed in version: 3.3.1
- Fixed in revision: 43671 (#f62fd437)