TNotebook can't delete page

Original Reporter info from Mantis: mcclane

• Reporter name: John McClane

Description:

When I try to delete a page with notebook1.items.delete(1) I get access violation. (I have two pages).

Mantis conversion info:

• Mantis ID: 30688
• OS: Linux Peppermint
• OS Build: 6
• Fixed in version: 1.6.2
• Fixed in revision: r53085 (#821eb9c4)
• Monitored by: » mcclane (John McClane)
• Target version: 1.6.2

assigned to @flyingsheep

added CategoryLCL WS: GTK labels

changed milestone to %Version 1.6.2

Converted from Mantis. Note by Bart Broersma @flyingsheep

• Mantis submitter username: Bart @flyingsheep
• Mantis submitter real name: Bart Broersma

---

As always, please attach a sample project demonstrating the issue (sources only).
See: http://wiki.lazarus.freepascal.org/Tips_on_writing_bug_reports

Converted from Mantis. Note by wp @wpam

• Mantis submitter username: wp @wpam
• Mantis submitter real name: wp

---

John, do you really think that somebody will seriously consider this to be a Lazarus issue if you demonstrate the problem with the attached enchat.unix project containing 75 files? And you don't even give instructions on how to get to the buggy situation.

If you really want somebody to take his time to fix this issue you should at least take your time to write a minimalized project containing only what's needed to reproduce the error.

Converted from Mantis. Note by John McClane

• Mantis submitter username: mcclane
• Mantis submitter real name: John McClane

---

My apologies wp. I've attached a small project.
When you click the delete button, it should change the tnotebook index page to 0 and delete the page 1.
I hope this helps.
I'm sorry I can't remove enchat.unix.zip

Converted from Mantis. Note by Juha Manninen @JuhaManninen

• Mantis submitter username: JuhaManninen @JuhaManninen
• Mantis submitter real name: Juha Manninen

---

I'm sorry I can't remove enchat.unix.zip

Removed.

Converted from Mantis. Note by Bart Broersma @flyingsheep

• Mantis submitter username: Bart @flyingsheep
• Mantis submitter real name: Bart Broersma

---

You may try Application.RemoveComponent() as a workaround?

Converted from Mantis. Note by John McClane

• Mantis submitter username: mcclane
• Mantis submitter real name: John McClane

---

Actually I tried Notebook1.removecontrol(notebook1.page[1]) but I don't know exactly what it is for.
It worked, but I can't create the dynamically later.
I just tried Application.RemoveComponent() as you wrote but I got access violation too.

Thanks Bart.

Converted from Mantis. Note by wp @wpam

• Mantis submitter username: wp @wpam
• Mantis submitter real name: wp

---

The issue is that Notebook.Pages.Delete(0) tries to set the parent of the page to be deleted to nil which in turn calls Notebook.Pages.Delete(0) again. This happens when deleting any page (at least on Windows).

Converted from Mantis. Note by Bart Broersma @flyingsheep

• Mantis submitter username: Bart @flyingsheep
• Mantis submitter real name: Bart Broersma

---

Also it does not delete the page from fPageList.

Converted from Mantis. Note by Bart Broersma @flyingsheep

• Mantis submitter username: Bart @flyingsheep
• Mantis submitter real name: Bart Broersma

---

Please test and close if OK.

Converted from Mantis. Note by John McClane

• Mantis submitter username: mcclane
• Mantis submitter real name: John McClane

---

I'm sorry I didn't understand, what is the solution?

Converted from Mantis. Note by Bart Broersma @flyingsheep

• Mantis submitter username: Bart @flyingsheep
• Mantis submitter real name: Bart Broersma

---

The fix is applied in Lazarus trunk r53085, so in order to test you need to use trunk >= r53085.
The fix will be merged into 1.6 branch, so it will be in the upcoming 1.6.2 release.
(Fixes cannot be applied to released versions)

See http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=revision&root=lazarus&revision=53085 for the changes that I made to fix this.
You can easiliy apply these changes to your local copy of Lazarus and then rebuild Lazarus.

Notice that when an issue has he status resolved, it does not make much sense to add notes.
Chances are they will not be read by the developer.

If you think an issue you reported is not fixed, even though it is marked as resolved, then re-open the issue. This won't get unnoticed.

In all other cases you can ask on mailinglist (preferrably) or the forum.

Please close this issue.

closed

locked this issue

Attached files:

• tnotebookbug.zip (Size: 130314 bytes, user: mcclane (John McClane), date: 2016-10-06)

marked this issue as related to #29976 (closed)