function IsEmptyRow in Grids.pas uses a wrong variable

Original Reporter info from Mantis: kinlion

• Reporter name: Kinlion Yan

Description:

at line 6881, in function IsEmptyRow.

" if GetCells(i, FRow)<>'' then begin "

I think here should be ARow instead of FRow.

Mantis conversion info:

• Mantis ID: 32965
• OS: Windows
• OS Build: Windows
• Build: 54278
• Platform: Windows X64
• Version: 2.3 (SVN)
• Fixed in version: 1.8.2
• Fixed in revision: r57005 (#b63451bd)
• Target version: 1.8.2

assigned to @flyingsheep

added CategoryLCL Version2.3 (SVN) labels

changed milestone to %Version 1.8.2

Converted from Mantis. Note by jamie philbrook @jamie

• Mantis submitter username: jamie @jamie
• Mantis submitter real name: jamie philbrook

---

yes in lines 7485 and 7141 with my 1.8.0 release

From what I see the nested functions are accessing the same value as what
was being past to it within the code. so at the moment It mostly isn't causing
and issue but, if the Property "ROW" ever gets changed to a getter and modifications then things may not work so well in the future.

  
  Why this was done is beyond me, its like a time bomb...

Converted from Mantis. Note by Bart Broersma @flyingsheep

• Mantis submitter username: Bart @flyingsheep
• Mantis submitter real name: Bart Broersma

---

Hmm, there are 2 copies of this local function, not sure why.
Maybe it should be a method of TCustomGrid?

Converted from Mantis. Note by Bart Broersma @flyingsheep

• Mantis submitter username: Bart @flyingsheep
• Mantis submitter real name: Bart Broersma

---

Please test and close if OK.

Converted from Mantis. Note by Kinlion Yan

• Mantis submitter username: kinlion
• Mantis submitter real name: Kinlion Yan

---

Thanks Bart.

I think it would be better if the function is public, but it's another title.

It's my first bug-report, and I don't know how to test.

Converted from Mantis. Note by Bart Broersma @flyingsheep

• Mantis submitter username: Bart @flyingsheep
• Mantis submitter real name: Bart Broersma

---

@Kinlion
You can test with latest trunk, or if you have 1.8, you can apply the patch (https://svn.freepascal.org/cgi-bin/viewvc.cgi/trunk/lcl/grids.pas?r1=57005&r2=57004&pathrev=57005&root=lazarus&view=patch) to your 1.8 version.

If you need further help with this, please ask on ML or forum, we'll be happy to assist.

Converted from Mantis. Note by Kinlion Yan

• Mantis submitter username: kinlion
• Mantis submitter real name: Kinlion Yan

---

@Bart,

I have cloned the latest trunk using git.
The issue has been solved.
Thanks again.

Converted from Mantis. Note by Kinlion Yan

• Mantis submitter username: kinlion
• Mantis submitter real name: Kinlion Yan

---

Where is the 'Close' button?
I'm sure I have seen it before, but I can't find it now.

Converted from Mantis. Note by Bart Broersma @flyingsheep

• Mantis submitter username: Bart @flyingsheep
• Mantis submitter real name: Bart Broersma

---

Thanks for testing.

The Close button should be there now (the issue must have status "resolved", otherwise this button is not there).

Please close.

Converted from Mantis. Note by Kinlion Yan

• Mantis submitter username: kinlion
• Mantis submitter real name: Kinlion Yan

---

Yes, I can close it now :)

Converted from Mantis. Note by Kinlion Yan

• Mantis submitter username: kinlion
• Mantis submitter real name: Kinlion Yan

---

The issue has been solved. Thanks to Bart Broersma.

closed

locked this issue

Attached files:

• grids.pas (Size: 376034 bytes, user: kinlion (Kinlion Yan), date: 2018-01-07)