View Issue Details

IDProjectCategoryView StatusLast Update
0014381LazarusPrinterpublic2009-08-19 18:47
ReporterDmitry Boyarintsev Assigned ToJesus Reyes  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Fixed in Version0.9.28 
Summary0014381: patch for CarbonPrinter. Remove useless ValidatePageFormat
DescriptionIndex: carbon/carbonprinters.inc
===================================================================
--- carbon/carbonprinters.inc (revision 21297)
+++ carbon/carbonprinters.inc (working copy)
@@ -91,7 +91,6 @@
           PMPaper(CFArrayGetValueAtIndex(FPaperArray, I))),
         Self, SName, 'PMCreatePageFormatWithPMPaper');
 
- ValidatePageFormat;
     end;
   finally
     if S <> nil then


ValidatePageFormat procedure is called incorrectly, because there's no page format selected for the printer.
TagsNo tags attached.
Fixed in Revision21322
LazTarget0.9.28
WidgetsetCarbon
Attached Files

Activities

2009-08-18 22:53

 

carbonprinters.patch (400 bytes)   
Index: carbon/carbonprinters.inc
===================================================================
--- carbon/carbonprinters.inc	(revision 21297)
+++ carbon/carbonprinters.inc	(working copy)
@@ -91,7 +91,6 @@
           PMPaper(CFArrayGetValueAtIndex(FPaperArray, I))),
         Self, SName, 'PMCreatePageFormatWithPMPaper');
 
-      ValidatePageFormat;
     end;
   finally
     if S <> nil then
carbonprinters.patch (400 bytes)   

Jesus Reyes

2009-08-19 18:39

developer   ~0029981

Applied, thanks.

Dmitry Boyarintsev

2009-08-19 18:47

developer   ~0029984

thank you.

Issue History

Date Modified Username Field Change
2009-08-18 22:53 Dmitry Boyarintsev New Issue
2009-08-18 22:53 Dmitry Boyarintsev File Added: carbonprinters.patch
2009-08-18 22:53 Dmitry Boyarintsev LazTarget => -
2009-08-18 22:53 Dmitry Boyarintsev Widgetset => Carbon
2009-08-18 22:53 Dmitry Boyarintsev Status new => assigned
2009-08-18 22:53 Dmitry Boyarintsev Assigned To => Jesus Reyes
2009-08-19 18:39 Jesus Reyes Fixed in Revision => 21322
2009-08-19 18:39 Jesus Reyes LazTarget - => 0.9.28
2009-08-19 18:39 Jesus Reyes Status assigned => resolved
2009-08-19 18:39 Jesus Reyes Fixed in Version => 0.9.28
2009-08-19 18:39 Jesus Reyes Resolution open => fixed
2009-08-19 18:39 Jesus Reyes Note Added: 0029981
2009-08-19 18:47 Dmitry Boyarintsev Status resolved => closed
2009-08-19 18:47 Dmitry Boyarintsev Note Added: 0029984