|
2010-01-04 08:46
|
dbdateedit.pp (1,779 bytes) |
|
2010-01-04 08:47
|
|
|
|
I uploaded implementation based on editbtn.TDateEdit and some code taken from TDBEdit. But thinking again about subject, I have also another idea -> what do you think about creating general TDBEditBtn = data-aware edit-button component, which will have property Kind: TDBEditBtnKind=(ebkNone, ebkCalendar, ebkDots, ebkLookup) In database application I often use edit with button for these reasons: 1. Select date from calendar (ebkCalendar) 2. Select "next value" for field (ebkDots="...") 3. Select "foreign key" from referenced table (for example customer code from customer list) (ebkLookup) |
|
|
Jesus, can you review this patch? |
|
|
This patch has a couple of issues, first the unit name and the class match the ones from rx controls, it doesn't include provision for install it in IDE. I fixed both issues by renaming the class and the unit and making the necessary changes so it appears in component palette. The next problem is that although selecting a date from calendar it sets the linked dataset in edit state, the field content doesn't really changes and any information previously in field is lost once the record is posted. NOTE: This issue may be related to a FPC bug, currently as long as I tested, FPC cannot convert a shortdate formated string if it include month names, it works only if month is numeric form. Currently I don't have more time to fix the remaining problems, so I'm changing the target version of this issue. |
|
|
I updated the LazTarget Field too. |
|
|
@RX Controls: AFAIK RXLib has also TDateEdit (beside TDBDateEdit) and Lazarus already has own TDateEdit, so there is already collision between RXLib and Lazarus, so I think, that adding TDBDateEdit is not a problem from this POV (i do not like renaming nice TDBDateEdit to something else ;-)) @INSTALLING IN IDE: Add TDBDateEdit into list in Register procedure in dbctrls.pp ? @OTHER PROBLEMS: IMHO they can be fixed (later), if there will be decision add TDBDateEdit to LCL Edit:I uploaded v.2 slightly optimized, and fixed some minor issues |
|
2012-08-01 08:21
|
|
|
2012-08-01 08:22
|
|
|
|
I'm sorry. I found two problems with the patch. 1. It's a db component but ... a) it looks like an external (to LCL) component, but it doesn't include it's own package, or b) it doesn't include a register procedure in order to register it self into the IDE (easily to solve) or the changes to registerlcl, etc. or c) it's not a patch (a diff) to be included in dbctrls.pp. 2. Because the LCL API has changed with the years, it doesn't compile anymore. 3. Not important: One thing is using a name unknowingly that is used by somebody else and another is using it knowing that is used by somebody else and having the chance to modify it, nevertheless one choose a possible collision. I tried to include it directly in LCL using 1c, but 2 stopped me. We need the following: 1. Somebody (lacaK?, wOvAN?) needs to bring this component up to date with the current LCL API (make it compile). 2. I would then make the necessary to integrate it into the LCL. 3. Feedback about the target Lazarus version (1.4 is ok to me if everything is fixed) or if authors are not interested anymore in this component. |
|
|
I have interest in this component. I think he should be included in the unit DbCtrls. |
|
|
@Jesus: Ok I will make changes, when I find some free time ... and I will upload patch here ... |
|
|
I could use this as well, the one from rx does not work properly on linux, gives a odd resourse error. |
|
|
FYI, I added the one from 2012 to my project in Laz 1.2.6 and so far it seems to work ok. It compiles just fine. The other thing lacking is a tdbcalcedit control and was thinking the existing one on the misc tab could also be extended the same way? |
|
|
FYI, the current implementation auto selects even when autoselect is set to false. If I have a few on a form that where created in code for a "form View" they are all selected, but the other databound controls are not. |
|
|
image1.png (52,121 bytes) |
|
|
see attached image1.png to see what I mean about the auto selecting. |
|
|
|
|
|
dbdateedit3.zip: - added diff against dbctrls.pp (updated Register procedure, add include of dbdateedit.inc, etc.) - updated dbdateedit.inc - fixed autoselect Complies for me with Lazarus 1.2.2 (I hope it is okay now.) Alternative: create new unit: DBExtCtrls and put TDBDateEdit (include of dbdateedit.inc ) there and in future may be also other new "non-standard" data-aware controls (like TDBCalendar). |
|
|
I'm sorry, got this errors when compiling with Lazarus trunk. We normally do not put new features in fixes, and it can't be merged to fixes if it doesn't compile in trunk. /home/prog/lazarus/lcl/dbctrls.pp(1178,14) Error: (3058) There is no method in an ancestor class to be overridden: "GetReadOnly:Boolean;" /home/prog/lazarus/lcl/dbctrls.pp(1179,15) Error: (3058) There is no method in an ancestor class to be overridden: "SetReadOnly(Boolean);" /home/prog/lazarus/lcl/dbctrls.pp(1181,15) Error: (3058) There is no method in an ancestor class to be overridden: "DoButtonClick(TObject);" /home/prog/lazarus/lcl/dbctrls.pp(1184,15) Error: (3058) There is no method in an ancestor class to be overridden: "Change;" /home/prog/lazarus/lcl/dbctrls.pp(1419,1) Fatal: (10026) There were 4 errors compiling module, stopping Fatal: (1018) Compilation aborted Error: /home/prog/fpcbin_64/bin/ppcx64 returned an error exitcode |
|
|
|
|
|
My apologies, next attempt in dbdateedit4.zip: - there is included also new unit DBExtCtrls if you decide not put new TDBDateEdit into dbctrls unit ... may be that in future there will be also others DB-aware controls f.e. useful is TDBEditButton (data-aware TEditButton) ... (and I am not sure if linker can eliminate unused classes from big unit ?) - I wanted use EditingDone method for call UpdateRecord, but it seems, that TEditButton does not fire this method (so I have used EditExit) - and I do not know why, but when I create TDBDateEdit at runtime, its Width is larger than Width=80 of TDateEdit created at design time |
|
|
Thanks Applied to trunk, I used dbextctrls unit for that. 1. The icon for the component is missing ... 2. I also compiled fpmake and makefile* files, but I didn't include them in the patch, it seemed to me that it removed too much and I'm not sure if that is ok, I let that for someone else. |
|
|
@Jesus there no icon ? |
|
|
tdbdateedit.png (581 bytes) |
|
|
Added icon for TDBDateEdit by "howardpc" from forum: ( http://forum.lazarus.freepascal.org/index.php/topic,26813.0.html ) |
|
|
TDBDateEdit has conflict by name with Rxnew controls TDBDateEdit ! One of them have to be renamed ... |
|
|
In pascal we have namespace per unit. So in two different units we can have same named identifiers. I see no problem if there exists in word same named component. You either use "uses dbextctrls" or "uses dbdateedit" (unit named in RxLib). On other side, I am not sure if in Lazarus can be registered on component palete two components with same name, which resides in different units ? (If YES, then IMO there is no problem;) BTW RxLib already uses prefix "TRxDB..." for naming their DB-aware components (TRxDBTimeEdit, TRxDBCalcEdit, TRxDBCurrEdit, TRxDBComboBox, TRxDBGrid). So expand this naming scheme to all components also gives sense to me. |
|
|
This can be resolved. The icon is added, Rx library is fixed etc. |
- Anonymous
