|
|
This message also occurs when I try to 'rebuild Lazarus' using the build.
Correction to command-line build: Should have read "make clean all"...
|
|
|
|
I just tried building 23414, and I'm still getting the same exception box when I try to compile an existing project. Lazarus appears to run in all other respects. It is not crashing outright, just throwing this exception.
Just tried a new project with no content, and it compiled without the exception. Very strange bug.
Question: Are there any differences in the formats of the created project files between version 23335 and 23414 that might account for the exception?
|
|
|
|
Something new to add...
If I do not include version numbering, the new projects build correctly. When I try to include Version Info, the exception message gets thrown. If I uncheck the option and go back to a no-info-version build, it builds correctly.
I captured a screenshot of the error message and attached it above...
|
|
|
|
|
|
|
|
versioninfo.patch (3,780 bytes)
Index: projectresources.pas
===================================================================
--- projectresources.pas (revision 23415)
+++ projectresources.pas (working copy)
@@ -114,6 +114,7 @@
'lrs',
'res'
);
+
function StrToResourceType(const s: string): TResourceType;
implementation
@@ -493,8 +494,8 @@
SetDeleteValue(Path+'VersionInfo/CurrentMinorRevNr/Value', VersionInfo.MinorRevNr,0);
SetDeleteValue(Path+'VersionInfo/CurrentBuildNr/Value', VersionInfo.BuildNr,0);
SetDeleteValue(Path+'VersionInfo/ProjectVersion/Value', VersionInfo.ProductVersionString,'1.0.0.0');
- SetDeleteValue(Path+'VersionInfo/Language/Value', VersionInfo.HexLang,'0409');
- SetDeleteValue(Path+'VersionInfo/CharSet/Value', VersionInfo.HexCharSet,'04E4');
+ SetDeleteValue(Path+'VersionInfo/Language/Value', VersionInfo.HexLang,DefaultLanguage);
+ SetDeleteValue(Path+'VersionInfo/CharSet/Value', VersionInfo.HexCharSet,DefaultCharset);
SetDeleteValue(Path+'VersionInfo/Comments/Value', VersionInfo.CommentsString,'');
SetDeleteValue(Path+'VersionInfo/CompanyName/Value', VersionInfo.CompanyString,'');
SetDeleteValue(Path+'VersionInfo/FileDescription/Value', VersionInfo.DescriptionString,'');
@@ -523,8 +524,8 @@
VersionInfo.MinorRevNr := GetValue(Path+'VersionInfo/CurrentMinorRevNr/Value', 0);
VersionInfo.BuildNr := GetValue(Path+'VersionInfo/CurrentBuildNr/Value', 0);
VersionInfo.ProductVersionString := GetValue(Path+'VersionInfo/ProjectVersion/Value', '1.0.0.0');
- VersionInfo.HexLang := GetValue(Path+'VersionInfo/Language/Value', '0409');
- VersionInfo.HexCharSet := GetValue(Path+'VersionInfo/CharSet/Value', '04E4');
+ VersionInfo.HexLang := GetValue(Path+'VersionInfo/Language/Value', DefaultLanguage);
+ VersionInfo.HexCharSet := GetValue(Path+'VersionInfo/CharSet/Value', DefaultCharset);
VersionInfo.CommentsString := LineBreaksToSystemLineBreaks(GetValue(Path+'VersionInfo/Comments/Value', ''));
VersionInfo.CompanyString := LineBreaksToSystemLineBreaks(GetValue(Path+'VersionInfo/CompanyName/Value', ''));
VersionInfo.DescriptionString := LineBreaksToSystemLineBreaks(GetValue(Path+'VersionInfo/FileDescription/Value', ''));
Index: w32versioninfo.pas
===================================================================
--- w32versioninfo.pas (revision 23415)
+++ w32versioninfo.pas (working copy)
@@ -116,6 +116,10 @@
function MSCharacterSets: TStringList;
function MSHexCharacterSets: TStringList;
+const
+ DefaultLanguage = '0409';
+ DefaultCharSet = '04E4';
+
implementation
var
@@ -275,6 +279,8 @@
ARes: TVersionResource;
st: TVersionStringTable;
ti: TVerTranslationInfo;
+ lang: String;
+ charset: String;
begin
Result := True;
if UseVersionInfo then
@@ -284,7 +290,12 @@
ARes.FixedInfo.FileVersion := FVersion;
ARes.FixedInfo.ProductVersion := ExtractProductVersion;
- st := TVersionStringTable.Create(HexLang + HexCharSet);
+ lang:=HexLang;
+ if lang='' then lang:=DefaultLanguage;
+ charset:=HexCharSet;
+ if charset='' then charset:=DefaultCharSet;
+
+ st := TVersionStringTable.Create(lang + charset);
st.Add('Comments', Utf8ToAnsi(CommentsString));
st.Add('CompanyName', Utf8ToAnsi(CompanyString));
st.Add('FileDescription', Utf8ToAnsi(DescriptionString));
@@ -297,8 +308,8 @@
st.Add('ProductVersion', StringReplace(Utf8ToAnsi(ProductVersionString), ',', '.', [rfReplaceAll]));
ARes.StringFileInfo.Add(st);
- ti.language := StrToInt('$'+HexLang);
- ti.codepage := StrToInt('$'+HexCharSet);
+ ti.language := StrToInt('$'+lang);
+ ti.codepage := StrToInt('$'+charset);
ARes.VarFileInfo.Add(ti);
AResources.AddSystemResource(ARes);
end;
|
|
|
|
Dmitry,
A silly question, but I'm still a novice with Lazarus. Am I supposed to drop this patch into a folder, or has it already been inserted into the SVN stack? I just updated to svn 23416, and it is still throwing the exception even before I can close the Project Options dialog (I hit OK, and this exception message immediately appears). If I need to save this patch to a folder myself, which one, and do I need to rename it to anything different?
Thanks.
|
|
|
|
No, patch isn't applied yet. Task will be marked as "resolved" when patch is applied (or even not applied and marked as "won't fix" etc).Anyway, you can
apply this patch into your lazarus version and test it, after that write some feedback here. |
|
|
|
Thanks, Zeljan. That explains why 23416 has the same problem...
...Patch applied, and Lazarus has risen from the (near) dead!
I think this issue can be rendered 'resolved' and closed. |
|
|
|
It can be resolved, after the patch has been applied and committed. |
|
|
|
Thank you, everyone! |
|
|
|
there might other solutions for the bug.
I've just made a proposal. You can use the patch applied, but keep an eye on the issue.
If some other fix is made, you'll need to revert changed made by the patch and update the Lazarus. |
|
|
|
the patch has been applied.
test and close if ok. |
|
