[patch] SourceNotebook cleanup and conceptual fix
Original Reporter info from Mantis: etrusco
-
Reporter name: Flávio Etrusco
Original Reporter info from Mantis: etrusco
- Reporter name: Flávio Etrusco
Description:
What this patch does (in SourceEditor.pp, TSourceNotebook):
- don't call NotebookPageChanged explicitly on NextEditor and PrevEditor. It's already called by the FNotebook.OnChange (at on GTK2. If it's not invoked in other ws' then we'd seem other problems).
- fix 'else' clause in PrevEditor.
- update FPageIndex in NoteBookDeletePage, since it doesn't check whether FUpdateLock = 0.
- lower visibility of utilitarian methods/event handlers (from public to protected).
- remove duplicate logic in /change NoteBookDeletePage.
- make TSourceNotebook.PageIndex readonly, since it doesn't seem something that should be public.
I can make separate patches if necessary.
Mantis conversion info:
- Mantis ID: 16279
- Version: 0.9.29 (SVN)
- Fixed in version: 0.9.29 (SVN)
- Fixed in revision: 24639 (#462c25c1)
- Target version: 0.9.30