View Issue Details

IDProjectCategoryView StatusLast Update
0016958LazarusPatchpublic2010-07-17 17:45
ReporterMarcelo B PaulaAssigned ToJesus Reyes 
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Product Version0.9.29 (SVN)Product Build 
Target Version0.9.30Fixed in Version0.9.29 (SVN) 
Summary0016958: FieldsEditor AV while deleting persistent TField.
DescriptionAfter playing around with TBufDataSet i´ve discovered this issue when deletinga defined Field.

Follow suggested patch.
Additional InformationPS: Lazarus 0.9.29 svn 26670-win32- fpc.2.5.1
TagsNo tags attached.
Fixed in Revision26707
LazTarget0.9.30
WidgetsetWin32/Win64
Attached Files
  • fldeditor.diff (1,487 bytes)
    Index: fieldseditor.lfm
    ===================================================================
    --- fieldseditor.lfm	(revis�o 26670)
    +++ fieldseditor.lfm	(c�pia de trabalho)
    @@ -1,17 +1,15 @@
     object DSFieldsEditorFrm: TDSFieldsEditorFrm
    -  Left = 22
    +  Left = 472
       Height = 288
    -  Top = 29
    +  Top = 230
       Width = 215
       HorzScrollBar.Page = 214
       VertScrollBar.Page = 287
    -  ActiveControl = FieldsListBox
       Caption = 'Fields Editor'
       ClientHeight = 288
       ClientWidth = 215
       OnClose = FieldsEditorFrmClose
       OnDestroy = FieldsEditorFrmDestroy
    -  Position = poDefaultPosOnly
       LCLVersion = '0.9.29'
       object FieldsListBox: TListBox
         Left = 0
    @@ -27,7 +25,7 @@
         TabOrder = 0
       end
       object PopupMenu1: TPopupMenu
    -    left = 8
    +    left = 32
         top = 144
         object MenuItem1: TMenuItem
           Action = AddFieldsActn
    @@ -60,7 +58,7 @@
       end
       object ActionList1: TActionList
         OnUpdate = ActionList1Update
    -    left = 40
    +    left = 120
         top = 144
         object AddFieldsActn: TAction
           Category = 'Fields'
    Index: fieldseditor.pas
    ===================================================================
    --- fieldseditor.pas	(revis�o 26670)
    +++ fieldseditor.pas	(c�pia de trabalho)
    @@ -175,7 +175,7 @@
           fld := TField(FieldsListBox.Items.Objects[i]);
           FieldsListBox.Items.Delete(i);
           FDesigner.PropertyEditorHook.PersistentDeleting(fld);
    -      fld.Free;
    +      fld := nil;
           bModified := True;
         end;
       SelectionChanged;
    
    fldeditor.diff (1,487 bytes)

Activities

2010-07-16 23:53

 

fldeditor.diff (1,487 bytes)
Index: fieldseditor.lfm
===================================================================
--- fieldseditor.lfm	(revis�o 26670)
+++ fieldseditor.lfm	(c�pia de trabalho)
@@ -1,17 +1,15 @@
 object DSFieldsEditorFrm: TDSFieldsEditorFrm
-  Left = 22
+  Left = 472
   Height = 288
-  Top = 29
+  Top = 230
   Width = 215
   HorzScrollBar.Page = 214
   VertScrollBar.Page = 287
-  ActiveControl = FieldsListBox
   Caption = 'Fields Editor'
   ClientHeight = 288
   ClientWidth = 215
   OnClose = FieldsEditorFrmClose
   OnDestroy = FieldsEditorFrmDestroy
-  Position = poDefaultPosOnly
   LCLVersion = '0.9.29'
   object FieldsListBox: TListBox
     Left = 0
@@ -27,7 +25,7 @@
     TabOrder = 0
   end
   object PopupMenu1: TPopupMenu
-    left = 8
+    left = 32
     top = 144
     object MenuItem1: TMenuItem
       Action = AddFieldsActn
@@ -60,7 +58,7 @@
   end
   object ActionList1: TActionList
     OnUpdate = ActionList1Update
-    left = 40
+    left = 120
     top = 144
     object AddFieldsActn: TAction
       Category = 'Fields'
Index: fieldseditor.pas
===================================================================
--- fieldseditor.pas	(revis�o 26670)
+++ fieldseditor.pas	(c�pia de trabalho)
@@ -175,7 +175,7 @@
       fld := TField(FieldsListBox.Items.Objects[i]);
       FieldsListBox.Items.Delete(i);
       FDesigner.PropertyEditorHook.PersistentDeleting(fld);
-      fld.Free;
+      fld := nil;
       bModified := True;
     end;
   SelectionChanged;
fldeditor.diff (1,487 bytes)

Jesus Reyes

2010-07-17 03:49

developer   ~0039409

Applied, thanks.

Marcelo B Paula

2010-07-17 17:45

reporter   ~0039415

Thank you.

Issue History

Date Modified Username Field Change
2010-07-16 23:53 Marcelo B Paula New Issue
2010-07-16 23:53 Marcelo B Paula File Added: fldeditor.diff
2010-07-16 23:53 Marcelo B Paula Widgetset => Win32/Win64
2010-07-17 03:49 Jesus Reyes Status new => assigned
2010-07-17 03:49 Jesus Reyes Assigned To => Jesus Reyes
2010-07-17 03:49 Jesus Reyes Fixed in Revision => 26707
2010-07-17 03:49 Jesus Reyes LazTarget => 0.9.30
2010-07-17 03:49 Jesus Reyes Status assigned => resolved
2010-07-17 03:49 Jesus Reyes Fixed in Version => 0.9.29 (SVN)
2010-07-17 03:49 Jesus Reyes Resolution open => fixed
2010-07-17 03:49 Jesus Reyes Note Added: 0039409
2010-07-17 03:49 Jesus Reyes Target Version => 0.9.30
2010-07-17 17:45 Marcelo B Paula Status resolved => closed
2010-07-17 17:45 Marcelo B Paula Note Added: 0039415