View Issue Details

IDProjectCategoryView StatusLast Update
0017152LazarusIDEpublic2010-08-23 18:44
ReporterDenis GolovanAssigned ToMartin Friebe 
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version0.9.28.3 (SVN)Product Build 
Target Version0.9.30Fixed in Version0.9.29 (SVN) 
Summary0017152: Regression: Multi-keys shortcuts conflict with single-key shortcut
DescriptionHi

Until recently (within 2-3 months period) shortcuts made of multiple-keys worked fine.
But now (rev. 27055) shortcut defined as Ctrl+X+Ctrl+S (emacs-like saving) messes with Ctrl+S (emacs-like search).
The problem looks like Ctrl+S in this case receives some priority and Ctrl+X+Ctrl+S command does not get called at all.
TagsNo tags attached.
Fixed in Revision27084
LazTarget0.9.30
Widgetset
Attached Files

Relationships

has duplicate 0017637 closedMartin Friebe Editor shortcut mixup 

Activities

Martin Friebe

2010-08-11 20:12

manager   ~0040149

Can you attach your editoroptions.xml file (should be in /home/username/.lazarus

Are you sure ctrl-x is not assigned to any other action? Maybe it's a menu shortcut?

2010-08-11 20:25

 

editoroptions.xml (10,173 bytes)

Denis Golovan

2010-08-11 20:26

reporter   ~0040150

Attached. I just checked using Find key combination - Ctrl + X is assigned only as part of Ctrl + X + Ctrl + S combo.

Martin Friebe

2010-08-11 23:03

manager   ~0040156

The problem is also present on windows.

On a technical note: It is triggered because the input is first tested for menu-shortcuts, before it can be processed by SynEdit (which would know about the combination)

Below stack show "DOKEYDOWNBEFOREINTERFACE" catches the key.

#0 INCREMENTALSEARCH(0xd0f09e0, false, false) at sourceeditor.pp:7448
0000001 BEGININCREMENTALFIND(0xd0f09e0) at sourceeditor.pp:5945
0000002 INCREMENTALFINDCLICKED(0xbd902d0, 0xbd58790) at sourceeditor.pp:8325
0000003 MENUITEMCLICK(0xbd58790, 0xbc75d00) at menuintf.pas:551
0000004 MENUITEMCLICK(0xbd58790, 0xbc75d00) at menuintf.pas:1610
0000005 CLICK(0xbc75d00) at include\menuitem.inc:75
0000006 HANDLEITEM(0x970f850, 0xbc75d00) at include\menu.inc:253
0000007 ISSHORTCUT(0xb69b178, @0x970fbe0: {MSG = 48384, CHARCODE = 83, UNUSED = 2416, KEYDATA = 2031617, RESULT = 0}) at include\menu.inc:272
0000008 ISSHORTCUT(0xb75fef8, @0x970fbe0: {MSG = 48384, CHARCODE = 83, UNUSED = 2416, KEYDATA = 2031617, RESULT = 0}) at include\customform.inc:2381
0000009 ISSHORTCUT(0x2cc4f0, @0x970fbe0: {MSG = 48384, CHARCODE = 83, UNUSED = 2416, KEYDATA = 2031617, RESULT = 0}) at include\application.inc:1990
0000010 DOKEYDOWNBEFOREINTERFACE(0xd0f09e0, @0x970fbe0: {MSG = 48384, CHARCODE = 83, UNUSED = 2416, KEYDATA = 2031617, RESULT = 0}) at include\wincontrol.inc:5594
0000011 DOKEYDOWNBEFOREINTERFACE(0xddbb210, @0x970fbe0: {MSG = 48384, CHARCODE = 83, UNUSED = 2416, KEYDATA = 2031617, RESULT = 0}) at include\wincontrol.inc:5557
0000012 CNKEYDOWN(0xddbb210, @0x970fbe0: {MSG = 48384, CHARCODE = 83, UNUSED = 2416, KEYDATA = 2031617, RESULT = 0}) at include\wincontrol.inc:6871
0000013 DISPATCH(0x970f780, @0x0: 0) at ..\inc\objpas.inc:585
0000014 CONTROLS_TWINCONTROL_$_WMWINDOWPOSCHANGED$TLMWINDOWPOSMSG_RAISELOOP at :0
0000015 WNDPROC(0xddbb210, @0x970fbe0: {MSG = 48384, WPARAM = 158335059, LPARAM = 2031617, RESULT = 0, WPARAMLO = 83, WPARAMHI = 2416, LPARAMLO = 1, LPARAMHI = 31, RESULTLO = 0, RESULTHI = 0}) at include\wincontrol.inc:5196
0000016 WNDPROC(0xddbb210, @0x970fbe0: {MSG = 48384, WPARAM = 158335059, LPARAM = 2031617, RESULT = 0, WPARAMLO = 83, WPARAMHI = 2416, LPARAMLO = 1, LPARAMHI = 31, RESULTLO = 0, RESULTHI = 0}) at synedit.pp:5422
0000017 DELIVERMESSAGE(0xddbb210, @0x970fbe0: 0) at lclmessageglue.pas:110
0000018 WINDOWPROC(2426294, 256, 83, 2031617) at win32callback.inc:2420

Paul Ishenin

2010-08-23 17:42

manager   ~0040417

Is it still not fixed?

Martin Friebe

2010-08-23 18:08

manager   ~0040418

Actually it looks like it was fixed by your commit in 27084.
I forgot to test/update the report.

@Denis Golovan:
Please test too, and close if ok.

Denis Golovan

2010-08-23 18:44

reporter   ~0040419

Looks like it works now. Thanks

Issue History

Date Modified Username Field Change
2010-08-11 19:40 Denis Golovan New Issue
2010-08-11 19:40 Denis Golovan Widgetset => GTK 2
2010-08-11 20:12 Martin Friebe Note Added: 0040149
2010-08-11 20:25 Denis Golovan File Added: editoroptions.xml
2010-08-11 20:26 Denis Golovan Note Added: 0040150
2010-08-11 21:14 Martin Friebe LazTarget => 0.9.30
2010-08-11 21:14 Martin Friebe Status new => confirmed
2010-08-11 21:14 Martin Friebe Target Version => 0.9.30
2010-08-11 23:03 Martin Friebe Note Added: 0040156
2010-08-23 17:42 Paul Ishenin Note Added: 0040417
2010-08-23 17:42 Paul Ishenin Status confirmed => feedback
2010-08-23 18:08 Martin Friebe Fixed in Revision => 27084
2010-08-23 18:08 Martin Friebe Widgetset GTK 2 =>
2010-08-23 18:08 Martin Friebe Status feedback => resolved
2010-08-23 18:08 Martin Friebe Fixed in Version => 0.9.29 (SVN)
2010-08-23 18:08 Martin Friebe Resolution open => fixed
2010-08-23 18:08 Martin Friebe Assigned To => Martin Friebe
2010-08-23 18:08 Martin Friebe Note Added: 0040418
2010-08-23 18:44 Denis Golovan Status resolved => closed
2010-08-23 18:44 Denis Golovan Note Added: 0040419
2010-10-15 12:57 Martin Friebe Relationship added has duplicate 0017637