View Issue Details

IDProjectCategoryView StatusLast Update
0017923LazarusLCLpublic2010-11-13 18:43
ReporterSven BarthAssigned ToPaul Ishenin 
PrioritynormalSeveritytrivialReproducibilityN/A
Status closedResolutionfixed 
Product Version0.9.29 (SVN)Product Build 
Target VersionFixed in Version0.9.29 (SVN) 
Summary0017923: TCustomImageList.Equals: TObject in 2.4.2 does contain it
DescriptionI've compiled Lazarus with the freshly released 2.4.2 and I've noticed a warning in TCustomImageList. It has a method Equals which is also included in TObject, but it is not overriden (it's disabled by compiler defines).
Additional InformationThe attached patch changes the ">20402" to ">=20402" and thus the warning disappears.
TagsNo tags attached.
Fixed in Revision28202
LazTarget-
WidgetsetGTK, GTK 2, Win32/Win64, WinCE, Carbon, Cocoa, QT, fpGUI
Attached Files
  • imglist-equals.patch (607 bytes)
    Index: lcl/imglist.pp
    ===================================================================
    --- lcl/imglist.pp	(Revision 28200)
    +++ lcl/imglist.pp	(Arbeitskopie)
    @@ -158,7 +158,7 @@
         procedure WriteData(AStream: TStream); virtual;
         procedure ReadData(AStream: TStream); virtual;
         function Equals(Obj: TObject): boolean;
    -      {$if not (defined(ver2_2_2) or defined(ver2_2_0))}{$IF FPC_FULLVERSION>20402}override;{$ENDIF}{$ENDIF}
    +      {$if not (defined(ver2_2_2) or defined(ver2_2_0))}{$IF FPC_FULLVERSION>=20402}override;{$ENDIF}{$ENDIF}
         procedure BeginUpdate;
         procedure EndUpdate;
     
    
    imglist-equals.patch (607 bytes)

Activities

2010-11-13 14:09

 

imglist-equals.patch (607 bytes)
Index: lcl/imglist.pp
===================================================================
--- lcl/imglist.pp	(Revision 28200)
+++ lcl/imglist.pp	(Arbeitskopie)
@@ -158,7 +158,7 @@
     procedure WriteData(AStream: TStream); virtual;
     procedure ReadData(AStream: TStream); virtual;
     function Equals(Obj: TObject): boolean;
-      {$if not (defined(ver2_2_2) or defined(ver2_2_0))}{$IF FPC_FULLVERSION>20402}override;{$ENDIF}{$ENDIF}
+      {$if not (defined(ver2_2_2) or defined(ver2_2_0))}{$IF FPC_FULLVERSION>=20402}override;{$ENDIF}{$ENDIF}
     procedure BeginUpdate;
     procedure EndUpdate;
 
imglist-equals.patch (607 bytes)

Paul Ishenin

2010-11-13 15:26

manager   ~0043010

Thanks, applied.

Sven Barth

2010-11-13 18:43

manager   ~0043015

You're welcome.

Regards,
Sven

Issue History

Date Modified Username Field Change
2010-11-13 14:09 Sven Barth New Issue
2010-11-13 14:09 Sven Barth File Added: imglist-equals.patch
2010-11-13 14:09 Sven Barth Widgetset => GTK, GTK 2, Win32/Win64, WinCE, Carbon, Cocoa, QT, fpGUI
2010-11-13 15:26 Paul Ishenin Fixed in Revision => 28202
2010-11-13 15:26 Paul Ishenin LazTarget => -
2010-11-13 15:26 Paul Ishenin Status new => resolved
2010-11-13 15:26 Paul Ishenin Fixed in Version => 0.9.29 (SVN)
2010-11-13 15:26 Paul Ishenin Resolution open => fixed
2010-11-13 15:26 Paul Ishenin Assigned To => Paul Ishenin
2010-11-13 15:26 Paul Ishenin Note Added: 0043010
2010-11-13 18:43 Sven Barth Status resolved => closed
2010-11-13 18:43 Sven Barth Note Added: 0043015