View Issue Details

IDProjectCategoryView StatusLast Update
0018855LazarusIDEpublic2011-03-02 12:05
ReporterDirk SchiphorstAssigned ToMaxim Ganetsky 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformOSWin XPOS Version
Product Version0.9.31 (SVN)Product Build29656 
Target VersionFixed in Version0.9.31 (SVN) 
Summary0018855: Options for Clean Directory not correctly read / handled
Description'Recently used' entries for the 3 comboboxes in the Clean Directory dialog are not read correctly and I always end up with just the default values. Problem is ide\cleandirdlg.pas, line 162

 LoadRecentList(XMLConfig,List,Path+'Directories');

Should be
 LoadRecentList(XMLConfig,List,Path);

This only reveals a second problem, though. Because the design time default values are written to the config file the combobox.itemindex is not always set to 0 (see proc AddStandardComboItem) and combobox.text is not changed from it's design time value ('DirComboBox', etc).

Additional InformationAttached patch should resolve both problems
TagsNo tags attached.
Fixed in Revision29699
LazTarget-
WidgetsetWin32/Win64
Attached Files
  • cleandirdlg.diff (498 bytes)
    Index: ide/cleandirdlg.pas
    ===================================================================
    --- ide/cleandirdlg.pas	(revision 29656)
    +++ ide/cleandirdlg.pas	(working copy)
    @@ -159,8 +159,10 @@
         List: TStringList;
       begin
         List:=TStringList.Create;
    -    LoadRecentList(XMLConfig,List,Path+'Directories');
    +    LoadRecentList(XMLConfig,List,Path);
         AComboBox.Items.Assign(List);
    +    if AComboBox.Items.Count > 0 then
    +      AComboBox.ItemIndex := 0;
         List.Free;
       end;
       
    
    cleandirdlg.diff (498 bytes)

Activities

2011-03-02 00:37

 

cleandirdlg.diff (498 bytes)
Index: ide/cleandirdlg.pas
===================================================================
--- ide/cleandirdlg.pas	(revision 29656)
+++ ide/cleandirdlg.pas	(working copy)
@@ -159,8 +159,10 @@
     List: TStringList;
   begin
     List:=TStringList.Create;
-    LoadRecentList(XMLConfig,List,Path+'Directories');
+    LoadRecentList(XMLConfig,List,Path);
     AComboBox.Items.Assign(List);
+    if AComboBox.Items.Count > 0 then
+      AComboBox.ItemIndex := 0;
     List.Free;
   end;
   
cleandirdlg.diff (498 bytes)

Maxim Ganetsky

2011-03-02 01:16

developer   ~0046332

Applied, thanks. I added you to contributors list.

Please test and close if ok.

Dirk Schiphorst

2011-03-02 12:05

reporter   ~0046341

Thanks

Issue History

Date Modified Username Field Change
2011-03-02 00:37 Dirk Schiphorst New Issue
2011-03-02 00:37 Dirk Schiphorst File Added: cleandirdlg.diff
2011-03-02 00:37 Dirk Schiphorst Widgetset => Win32/Win64
2011-03-02 01:16 Maxim Ganetsky Fixed in Revision => 29699
2011-03-02 01:16 Maxim Ganetsky LazTarget => -
2011-03-02 01:16 Maxim Ganetsky Status new => resolved
2011-03-02 01:16 Maxim Ganetsky Fixed in Version => 0.9.31 (SVN)
2011-03-02 01:16 Maxim Ganetsky Resolution open => fixed
2011-03-02 01:16 Maxim Ganetsky Assigned To => Maxim Ganetsky
2011-03-02 01:16 Maxim Ganetsky Note Added: 0046332
2011-03-02 12:05 Dirk Schiphorst Status resolved => closed
2011-03-02 12:05 Dirk Schiphorst Note Added: 0046341