View Issue Details

IDProjectCategoryView StatusLast Update
0018958LazarusLCLpublic2011-03-21 08:27
ReporterAlexander S. KleninAssigned ToPaul Ishenin 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionProduct Build 
Target VersionFixed in Version0.9.31 (SVN) 
Summary0018958: TBrush does not initialize FPColor
DescriptionOn the newly-created TBrush, Color = clWhite, but FPColor = 0

Attached patch trivially fixes it, but I not 100% sure of full implications
of calling SetColor in the constructor --
maybe adding inherited SetFPColor(clWhite) instead is safer.
TagsNo tags attached.
Fixed in Revision29952
LazTarget-
Widgetset
Attached Files
  • tbrush_init_fpcolor.patch (347 bytes)
    Index: brush.inc
    ===================================================================
    --- brush.inc	(revision 29921)
    +++ brush.inc	(working copy)
    @@ -90,7 +90,7 @@
     begin
       inherited Create;
       FBitmap := nil;
    -  FColor := clWhite;
    +  Color := clWhite;
       DelayAllocate := True;
       FInternalUpdateIndex := -1;
       inherited SetStyle(bsSolid);
    

Activities

2011-03-21 03:51

 

tbrush_init_fpcolor.patch (347 bytes)
Index: brush.inc
===================================================================
--- brush.inc	(revision 29921)
+++ brush.inc	(working copy)
@@ -90,7 +90,7 @@
 begin
   inherited Create;
   FBitmap := nil;
-  FColor := clWhite;
+  Color := clWhite;
   DelayAllocate := True;
   FInternalUpdateIndex := -1;
   inherited SetStyle(bsSolid);

Paul Ishenin

2011-03-21 06:50

manager   ~0046714

Please test and close if ok.

Issue History

Date Modified Username Field Change
2011-03-21 03:51 Alexander S. Klenin New Issue
2011-03-21 03:51 Alexander S. Klenin File Added: tbrush_init_fpcolor.patch
2011-03-21 03:51 Alexander S. Klenin LazTarget => -
2011-03-21 06:50 Paul Ishenin Fixed in Revision => 29952
2011-03-21 06:50 Paul Ishenin Status new => resolved
2011-03-21 06:50 Paul Ishenin Fixed in Version => 0.9.31 (SVN)
2011-03-21 06:50 Paul Ishenin Resolution open => fixed
2011-03-21 06:50 Paul Ishenin Assigned To => Paul Ishenin
2011-03-21 06:50 Paul Ishenin Note Added: 0046714
2011-03-21 08:27 Alexander S. Klenin Status resolved => closed