View Issue Details

IDProjectCategoryView StatusLast Update
0020050LazarusDebuggerpublic2011-12-31 05:35
ReporterCyraxAssigned ToMartin Friebe 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionProduct Build 
Target VersionFixed in Version0.9.31 (SVN) 
Summary0020050: Watches doesn't remember their enabled or disabled status.
DescriptionIf user disables several watches and then saves and reopens a project, their status will be always enabled.

Attached patch (watchesdlg.pp.patch) fixes this bug.

TagsNo tags attached.
Fixed in Revision32048
LazTarget0.99.0
Widgetset
Attached Files
  • watchesdlg.pp.patch (529 bytes)
    Index: debugger/watchesdlg.pp
    ===================================================================
    --- debugger/watchesdlg.pp	(revision 32047)
    +++ debugger/watchesdlg.pp	(working copy)
    @@ -681,10 +681,12 @@
         Item.Data := AWatch;
         Item.SubItems.Add('');
         Item.Selected := True;
    +
    +    Watch := GetSelected;
    +    if Watch <> nil then Watch.Enabled := True;
    +
       end;
       
    -  Watch := GetSelected;
    -  if Watch <> nil then Watch.Enabled := True;
     
       UpdateItem(Item, AWatch);
       lvWatchesSelectItem(nil, nil, False);
    
    watchesdlg.pp.patch (529 bytes)

Activities

2011-08-25 10:23

 

watchesdlg.pp.patch (529 bytes)
Index: debugger/watchesdlg.pp
===================================================================
--- debugger/watchesdlg.pp	(revision 32047)
+++ debugger/watchesdlg.pp	(working copy)
@@ -681,10 +681,12 @@
     Item.Data := AWatch;
     Item.SubItems.Add('');
     Item.Selected := True;
+
+    Watch := GetSelected;
+    if Watch <> nil then Watch.Enabled := True;
+
   end;
   
-  Watch := GetSelected;
-  if Watch <> nil then Watch.Enabled := True;
 
   UpdateItem(Item, AWatch);
   lvWatchesSelectItem(nil, nil, False);
watchesdlg.pp.patch (529 bytes)

Martin Friebe

2011-08-25 12:51

manager   ~0051101

Please test and close if ok.

I removed the 2 lines entirely, as even after the patch they still caused unwanted "enabling", if entries from the history dialog (trunk) where selected.

The calling code already deals with enabling new watches. So the lines were no longer needed.

Issue History

Date Modified Username Field Change
2011-08-25 10:23 Cyrax New Issue
2011-08-25 10:23 Cyrax Status new => assigned
2011-08-25 10:23 Cyrax Assigned To => Marc Weustink
2011-08-25 10:23 Cyrax File Added: watchesdlg.pp.patch
2011-08-25 12:16 Martin Friebe Assigned To Marc Weustink => Martin Friebe
2011-08-25 12:51 Martin Friebe Fixed in Revision => 32048
2011-08-25 12:51 Martin Friebe LazTarget => 0.99.0
2011-08-25 12:51 Martin Friebe Status assigned => resolved
2011-08-25 12:51 Martin Friebe Fixed in Version => 0.9.31 (SVN)
2011-08-25 12:51 Martin Friebe Resolution open => fixed
2011-08-25 12:51 Martin Friebe Note Added: 0051101
2011-08-25 12:51 Martin Friebe Target Version => 0.99.0
2011-12-31 05:35 Cyrax Status resolved => closed