View Issue Details

IDProjectCategoryView StatusLast Update
0020237LazarusIDEpublic2011-09-14 12:10
ReporterGraeme GeldenhuysAssigned ToMartin Friebe 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86_64OSUbuntu LinuxOS Version10.04
Product Version0.9.31 (SVN)Product Build 
Target VersionFixed in Version0.9.31 (SVN) 
Summary0020237: Run -> Inspect (alt+F5) is not enabled
DescriptionThe 'Run -> Inspect' menu item is never enabled while debugging, but it is enabled in the context menu of the source editor. All while debugging of course.

This happens in Lazarus (trunk) and Lazarus 0.9.30.1.
TagsNo tags attached.
Fixed in Revision32329
LazTarget0.99.0
Widgetset
Attached Files
  • inspect-menu-fix.patch (595 bytes)
    Index: ide/debugmanager.pas
    ===================================================================
    --- ide/debugmanager.pas	(revision 32328)
    +++ ide/debugmanager.pas	(working copy)
    @@ -1614,6 +1614,9 @@
         // Stop
         itmRunMenuStop.Enabled := CanRun and DebuggerIsValid;
         StopSpeedButton.Enabled := itmRunMenuStop.Enabled;
    +    // Inspect
    +    itmRunMenuInspect.Enabled := CanRun and DebuggerIsValid
    +            and (dcEvaluate in FDebugger.Commands);
         // Evaluate
         itmRunMenuEvaluate.Enabled := CanRun and DebuggerIsValid
                 and (dcEvaluate in FDebugger.Commands);
    

Activities

In DebugManager.pp, line 1621, this is missing:

    // Inspect
    itmRunMenuInspect.Enabled := CanRun and DebuggerIsValid
            and (dcEvaluate in FDebugger.Commands);

Lazarus really needs to revamp the shortcuts/commands system...
(BTW the shortcut works. Next bug is that the Inspector autosizes column and 'type' is huge for any control ;-) )

2011-09-14 10:31

 

inspect-menu-fix.patch (595 bytes)
Index: ide/debugmanager.pas
===================================================================
--- ide/debugmanager.pas	(revision 32328)
+++ ide/debugmanager.pas	(working copy)
@@ -1614,6 +1614,9 @@
     // Stop
     itmRunMenuStop.Enabled := CanRun and DebuggerIsValid;
     StopSpeedButton.Enabled := itmRunMenuStop.Enabled;
+    // Inspect
+    itmRunMenuInspect.Enabled := CanRun and DebuggerIsValid
+            and (dcEvaluate in FDebugger.Commands);
     // Evaluate
     itmRunMenuEvaluate.Enabled := CanRun and DebuggerIsValid
             and (dcEvaluate in FDebugger.Commands);

Martin Friebe

2011-09-14 11:08

manager   ~0051810

Applied, thanks.

Please close if ok
Hey, Martin, moving the diff is sabotage! :-P (as it won't nullify my local revision on rebase ;-) BTW The Evaluate items are separate...)

Issue History

Date Modified Username Field Change
2011-09-14 08:51 Graeme Geldenhuys New Issue
2011-09-14 10:05 Flávio Etrusco (notifications not working) Note Added: 0051808
2011-09-14 10:31 Flávio Etrusco (notifications not working) File Added: inspect-menu-fix.patch
2011-09-14 10:58 Martin Friebe Status new => assigned
2011-09-14 10:58 Martin Friebe Assigned To => Martin Friebe
2011-09-14 11:08 Martin Friebe Fixed in Revision => 32329
2011-09-14 11:08 Martin Friebe LazTarget => 0.99.0
2011-09-14 11:08 Martin Friebe Status assigned => resolved
2011-09-14 11:08 Martin Friebe Fixed in Version => 0.9.31 (SVN)
2011-09-14 11:08 Martin Friebe Resolution open => fixed
2011-09-14 11:08 Martin Friebe Note Added: 0051810
2011-09-14 11:08 Martin Friebe Target Version => 0.99.0
2011-09-14 12:10 Flávio Etrusco (notifications not working) Note Added: 0051812