View Issue Details

IDProjectCategoryView StatusLast Update
0021598Lazarus CCRrxpublic2012-03-31 17:50
ReporterDaniel Simões de Almeida Assigned ToLagunov Aleksey  
PrioritynormalSeverityminorReproducibilitysometimes
Status resolvedResolutionfixed 
Summary0021598: Unable to build RX with FPC < 2.7.1
DescriptionRecent changes in the FPC made ​​the RX incompatible with versions less than 2.7.1 of FPC

I know that there is another case concerning the same subject, which recommended using FPC 2.7.1, however the FPC 2.7.1 presents several other problems, for example, breaks through the operation of Zeos 6.6.6

The attached patch modifies the sources of RX according to changes made in the Unit DBgrids.pas from Lazarus ... which would make the sources compatible with all versions of FPC.

I would appreciate if modifications could be applied (if everything is correct)
TagsNo tags attached.
Widgetset
Attached Files

Relationships

related to 0021424 resolvedLagunov Aleksey Lazarus CCR unable to build RX 
parent of 0021376 resolvedJesus Reyes Lazarus compiler error 

Activities

2012-03-29 21:59

 

rx_fpc260.patch (2,529 bytes)   
Index: dbutils.pas
===================================================================
--- dbutils.pas	(revision 2369)
+++ dbutils.pas	(working copy)
@@ -432,7 +432,7 @@
     if Result then Exit;
     DataSet.DisableControls;
     try
-      Bookmark := DataSet.Bookmark;
+      Bookmark := DataSet.GetBookmark;
       try
         with DataSet do begin
           First;
@@ -444,7 +444,7 @@
         end;
       finally
         if not Result and DataSet.BookmarkValid(PChar(Bookmark)) then
-          DataSet.Bookmark := Bookmark;
+          DataSet.GotoBookmark(Bookmark);
       end;
     finally
       DataSet.FreeBookmark(Bookmark);
@@ -920,7 +920,7 @@
 begin
   DS:=Field.DataSet;
   DS.DisableControls;
-  P:=DS.Bookmark;
+  P:=DS.GetBookmark;
   try
     DS.First;
     while not DS.EOF do
@@ -931,7 +931,7 @@
       DS.Next;
     end;
   finally
-    DS.Bookmark:=P;
+    DS.GotoBookmark(P);
     DS.FreeBookmark(P);
     DS.EnableControls;
   end;
Index: rxmemds.pas
===================================================================
--- rxmemds.pas	(revision 2369)
+++ rxmemds.pas	(working copy)
@@ -1340,7 +1340,7 @@
     if Result then Exit;
     DataSet.DisableControls;
     try
-      Bookmark := DataSet.Bookmark;
+      Bookmark := DataSet.GetBookmark;
       try
         with DataSet do begin
           First;
@@ -1352,7 +1352,7 @@
         end;
       finally
         if not Result and DataSet.BookmarkValid(PChar(Bookmark)) then
-          DataSet.Bookmark := Bookmark;
+          DataSet.GotoBookmark(Bookmark);
       end;
     finally
       DataSet.FreeBookmark(Bookmark);
@@ -1581,7 +1581,7 @@
 begin
   if Active and (FRecords <> nil) and (FRecords.Count > 0) then
   begin
-    Pos := Bookmark;
+    Pos := GetBookmark;
     try
       QuickSort(0, FRecords.Count - 1, @CompareRecords);
       SetBufListSize(0);
@@ -1595,7 +1595,7 @@
         raise;
       end;
     finally
-      Bookmark := Pos;
+      GotoBookmark(Pos);
       FreeBookmark(Pos);
     end;
     Resync([]);
Index: rxpopupunit.pas
===================================================================
--- rxpopupunit.pas	(revision 2369)
+++ rxpopupunit.pas	(working copy)
@@ -454,6 +454,7 @@
   FDataSource:=TDataSource.Create(Self);
   FPopUpFormOptions:=APopUpFormOptions;
   FFieldList:=AFieldList;
+  OnClose := @FormClose;
 
 {$IFDEF LINUX}
   PopupOrigin:=TCustomControl(AOwner).Parent.ControlToScreen(Point(TCustomControl(AOwner).Left, TCustomControl(AOwner).Height + TCustomControl(AOwner).Top));
rx_fpc260.patch (2,529 bytes)   

Daniel Simões de Almeida

2012-03-29 22:00

reporter   ~0058180

Related Issues
http://bugs.freepascal.org/view.php?id=21424
http://bugs.freepascal.org/view.php?id=21376

Issue History

Date Modified Username Field Change
2012-03-29 21:59 Daniel Simões de Almeida New Issue
2012-03-29 21:59 Daniel Simões de Almeida Status new => assigned
2012-03-29 21:59 Daniel Simões de Almeida Assigned To => Lagunov Aleksey
2012-03-29 21:59 Daniel Simões de Almeida File Added: rx_fpc260.patch
2012-03-29 22:00 Daniel Simões de Almeida Note Added: 0058180
2012-03-29 22:03 Vincent Snijders Relationship added related to 0021424
2012-03-29 22:03 Vincent Snijders Relationship added parent of 0021376
2012-03-31 17:50 Lagunov Aleksey Status assigned => resolved
2012-03-31 17:50 Lagunov Aleksey Resolution open => fixed