View Issue Details

IDProjectCategoryView StatusLast Update
0022085LazarusIDEpublic2012-05-22 23:22
ReporterIhor LavrynyukAssigned ToMaxim Ganetsky 
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Platformx64OSwindows 8OS VersionConsumer Preview
Product Version1.1 (SVN)Product Build37356 
Target VersionFixed in Version1.1 (SVN) 
Summary0022085: ToDo List show an extra "}"
DescriptionToDo List show an extra "}"

showed:
"Звіт по закупкам { Загальна кількість Загальна сума - по ревізії по кладу
мін кільк - видалити}}"
                     ^
Steps To Reproduce{ TODO : Звіт по закупкам
{
Загальна кількість
Загальна сума - по ревізії по складу
мін кільк - видалити
}
}
TagsNo tags attached.
Fixed in Revision37397
LazTarget-
Widgetset
Attached Files
  • todolist.pas.patch (750 bytes)
    Index: components/todolist/todolist.pas
    ===================================================================
    --- components/todolist/todolist.pas	(revision 37379)
    +++ components/todolist/todolist.pas	(working copy)
    @@ -549,9 +549,9 @@
       end;
       
       // Remove the ending comment chars from input string
    -  if (eComment<>'')
    -  and (Pos(EComment, ParsingString)=Length(ParsingString)- Length(EComment)+1) then
    -    ParsingString := Copy(ParsingString, 1, Length(ParsingString)-Length(eComment));
    +  if (EComment <> '')
    +  and (RightStr(ParsingString, Length(EComment)) = EComment) then
    +    ParsingString := Copy(ParsingString, 1, Length(ParsingString)-Length(EComment));
       
       // Remove Todo/Done flag from input string
       if isAltNotation then
    
    todolist.pas.patch (750 bytes)

Activities

Ihor Lavrynyuk

2012-05-20 09:18

reporter   ~0059775

Last edited: 2012-05-20 09:20

Also if used comments in ToDo - not need show this comment in list.
Comment in ToDo must be additional information.

{}
//

Ihor Lavrynyuk

2012-05-20 09:27

reporter   ~0059776

Last edited: 2012-05-20 09:28

Also list need and must be automatically sorted by priority.

Juha Manninen

2012-05-20 13:22

developer   ~0059783

Ihor, just an idea:
If you want to try fixing bugs yourself, the ToDo list would be a good package to practice with. It is relatively small and has only little dependencies to Lazarus IDE.
It has no active maintainer now.

Good bug reports are of course welcome but you create so many of them that nobody can fix them at the same pace. :)

  http://wiki.lazarus.freepascal.org/Creating_A_Patch

2012-05-22 21:09

 

todolist.pas.patch (750 bytes)
Index: components/todolist/todolist.pas
===================================================================
--- components/todolist/todolist.pas	(revision 37379)
+++ components/todolist/todolist.pas	(working copy)
@@ -549,9 +549,9 @@
   end;
   
   // Remove the ending comment chars from input string
-  if (eComment<>'')
-  and (Pos(EComment, ParsingString)=Length(ParsingString)- Length(EComment)+1) then
-    ParsingString := Copy(ParsingString, 1, Length(ParsingString)-Length(eComment));
+  if (EComment <> '')
+  and (RightStr(ParsingString, Length(EComment)) = EComment) then
+    ParsingString := Copy(ParsingString, 1, Length(ParsingString)-Length(EComment));
   
   // Remove Todo/Done flag from input string
   if isAltNotation then
todolist.pas.patch (750 bytes)

Maxim Ganetsky

2012-05-22 23:16

developer   ~0059866

Last edited: 2012-05-22 23:17

Attached patch is applied with changes. Thanks to Anton.

Please test and close if ok.

Ihor Lavrynyuk

2012-05-22 23:22

reporter   ~0059867

Also if used comments in ToDo - not need show this comment in list.
Comment in ToDo must be additional information.

 {}
 //

Also list need and must be automatically sorted by priori

Issue History

Date Modified Username Field Change
2012-05-20 09:12 Ihor Lavrynyuk New Issue
2012-05-20 09:12 Ihor Lavrynyuk Widgetset => Win32/Win64
2012-05-20 09:18 Ihor Lavrynyuk Note Added: 0059775
2012-05-20 09:19 Ihor Lavrynyuk Note Edited: 0059775
2012-05-20 09:19 Ihor Lavrynyuk Note Edited: 0059775
2012-05-20 09:20 Ihor Lavrynyuk Note Edited: 0059775
2012-05-20 09:27 Ihor Lavrynyuk Note Added: 0059776
2012-05-20 09:27 Ihor Lavrynyuk Note Edited: 0059776
2012-05-20 09:28 Ihor Lavrynyuk Note Edited: 0059776
2012-05-20 13:22 Juha Manninen Note Added: 0059783
2012-05-22 21:09 Anton File Added: todolist.pas.patch
2012-05-22 23:16 Maxim Ganetsky Fixed in Revision => 37397
2012-05-22 23:16 Maxim Ganetsky LazTarget => -
2012-05-22 23:16 Maxim Ganetsky Widgetset Win32/Win64 =>
2012-05-22 23:16 Maxim Ganetsky Status new => resolved
2012-05-22 23:16 Maxim Ganetsky Fixed in Version => 1.1 (SVN)
2012-05-22 23:16 Maxim Ganetsky Resolution open => fixed
2012-05-22 23:16 Maxim Ganetsky Assigned To => Maxim Ganetsky
2012-05-22 23:16 Maxim Ganetsky Note Added: 0059866
2012-05-22 23:17 Maxim Ganetsky Note Edited: 0059866
2012-05-22 23:22 Ihor Lavrynyuk Status resolved => closed
2012-05-22 23:22 Ihor Lavrynyuk Note Added: 0059867