View Issue Details

IDProjectCategoryView StatusLast Update
0022988LazarusPatchpublic2012-11-24 03:34
Reportertcaduto Assigned ToMartin Friebe  
PrioritynormalSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
Product Version1.0.0 
Target Version1.2.0Fixed in Version1.1 (SVN) 
Summary0022988: I added a PostgreSQL dialect to the Lazarus SQL Highlighter
DescriptionI don't know how to do a patch so I attached the whole file with
the mods to enable the PostgreSQL dialect.
I originally submitted this to the Delphi synedit project years ago and
noticed the Lazarus version did not have it.
TagsNo tags attached.
Fixed in Revision39358
LazTarget1.2
Widgetset
Attached Files

Activities

2012-09-26 20:18

 

synhighlightersql.pas (95,052 bytes)

Bart Broersma

2012-09-26 22:04

developer   ~0062658

Can you create a patch (see wiki article: creating a patch) instead of attaching the unit file?

Martin Friebe

2012-09-26 22:14

manager   ~0062659

I can use a full file, if there is no other way. But it makes it harder to synchronize.

Your current file is based on an older version of the Lazarus' SynEdit file. If I use your file, I loose lots of other changes. SO I can not use it as it is.

In order to submit a useful file, you must download the latest lazarus (svn trunk; or 1.1 snapshot of today) and then adapt this.

---
For creating patches there are tools like "WinMerge" it loads both files, and can create the patch. But even for a patch, it must be done against a recent version.

tcaduto

2012-09-26 23:16

reporter   ~0062662

Thanks Martin,
I will pull the file from trunk the day I do it and attach it to this ticket.
I might as well update all the keywords etc from PG 9.2 and remove any that are in the standard SQL. I will try and do it tomorrow.

Issue History

Date Modified Username Field Change
2012-09-26 20:18 tcaduto New Issue
2012-09-26 20:18 tcaduto File Added: synhighlightersql.pas
2012-09-26 21:40 Martin Friebe Status new => assigned
2012-09-26 21:40 Martin Friebe Assigned To => Martin Friebe
2012-09-26 22:04 Bart Broersma Note Added: 0062658
2012-09-26 22:14 Martin Friebe LazTarget => -
2012-09-26 22:14 Martin Friebe Note Added: 0062659
2012-09-26 22:14 Martin Friebe Status assigned => feedback
2012-09-26 23:16 tcaduto Note Added: 0062662
2012-11-24 03:34 Martin Friebe Fixed in Revision => 39358
2012-11-24 03:34 Martin Friebe LazTarget - => 1.2
2012-11-24 03:34 Martin Friebe Status feedback => resolved
2012-11-24 03:34 Martin Friebe Fixed in Version => 1.1 (SVN)
2012-11-24 03:34 Martin Friebe Resolution open => fixed
2012-11-24 03:34 Martin Friebe Target Version => 1.2.0