View Issue Details

IDProjectCategoryView StatusLast Update
0025099LazarusLCLpublic2013-10-17 17:13
ReporterCyraxAssigned ToJesus Reyes 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionProduct Build 
Target Version1.2.0Fixed in Version1.3 (SVN) 
Summary0025099: Lazarus trunk r42989 : SIGSEGV in grids.pas at TCustomGrid.Focused.
DescriptionSee summary field.

---

Target system: win32, Free Pascal trunk 2.7.1-r25569, Lazarus trunk '1.3'-r42989

fpc make options all install sourceinstall UPXPROG=echo OPT="-gw2 -godwarfsets
-gl -O- -OoNO -Xs-" COMPILER_OPTIONS="-gw2 -godwarfsets -gl -O- -OoNO -Xs-" INST
ALL_PREFIX=i:\free_pascal_and_lazarus\free_pascal_and_lazarus\fpc\trunk\build\tr
unk_x32 REVSTR=25569 IDE=1
lazarus make options make all UPXPROG=echo OPT="-gw2 -godwarfsets -gh -gl -O- -
OoNO -dHEAPTRC_WINDOW -Xs-" USESVN2REVISIONINC=0
TagsNo tags attached.
Fixed in Revision42991
LazTarget1.2
WidgetsetWin32/Win64
Attached Files
  • grids.pas.patch (530 bytes)
    Index: lcl/grids.pas
    ===================================================================
    --- lcl/grids.pas	(revision 42989)
    +++ lcl/grids.pas	(working copy)
    @@ -7357,7 +7357,7 @@
     function TCustomGrid.Focused: Boolean;
     begin
       Result := CanTab and (HandleAllocated and
    -    (FindOwnerControl(GetFocus)=Self) or (FEditor.Visible and FEditor.Focused));
    +    (FindOwnerControl(GetFocus)=Self) or (Assigned(FEditor) And FEditor.Visible and FEditor.Focused));
     end;
     
     procedure TCustomGrid.InvalidateCell(aCol, aRow: Integer);
    
    grids.pas.patch (530 bytes)

Activities

Cyrax

2013-09-27 18:13

reporter  

grids.pas.patch (530 bytes)
Index: lcl/grids.pas
===================================================================
--- lcl/grids.pas	(revision 42989)
+++ lcl/grids.pas	(working copy)
@@ -7357,7 +7357,7 @@
 function TCustomGrid.Focused: Boolean;
 begin
   Result := CanTab and (HandleAllocated and
-    (FindOwnerControl(GetFocus)=Self) or (FEditor.Visible and FEditor.Focused));
+    (FindOwnerControl(GetFocus)=Self) or (Assigned(FEditor) And FEditor.Visible and FEditor.Focused));
 end;
 
 procedure TCustomGrid.InvalidateCell(aCol, aRow: Integer);
grids.pas.patch (530 bytes)

Cyrax

2013-09-27 18:13

reporter   ~0070398

Attached patch which should fix this bug.

Jesus Reyes

2013-09-27 20:31

developer   ~0070406

I'm sorry I didn't see the bug report until I committed my patch, thanks.

Issue History

Date Modified Username Field Change
2013-09-27 17:52 Cyrax New Issue
2013-09-27 18:13 Cyrax File Added: grids.pas.patch
2013-09-27 18:13 Cyrax Note Added: 0070398
2013-09-27 20:30 Jesus Reyes Assigned To => Jesus Reyes
2013-09-27 20:30 Jesus Reyes Status new => assigned
2013-09-27 20:31 Jesus Reyes Fixed in Revision => 42991
2013-09-27 20:31 Jesus Reyes LazTarget => 1.2
2013-09-27 20:31 Jesus Reyes Note Added: 0070406
2013-09-27 20:31 Jesus Reyes Status assigned => resolved
2013-09-27 20:31 Jesus Reyes Fixed in Version => 1.3 (SVN)
2013-09-27 20:31 Jesus Reyes Resolution open => fixed
2013-09-27 20:31 Jesus Reyes Target Version => 1.2.0
2013-10-17 17:13 Cyrax Status resolved => closed