View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0025870 | Lazarus | LCL | public | 2014-03-16 11:13 | 2014-03-17 16:39 |
| Reporter | Michael Van Canneyt | Assigned To | Juha Manninen | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | All | OS | All | ||
| Product Version | 1.2.0 | ||||
| Summary | 0025870: TCustomButton.Click is protected | ||||
| Description | TCustomButton.Click is protected in the LCL. In the VCL, TCustomButton.Click is public. Seeing that TButton.Click just calls inherited, I think that the best solution is to make TCustomButton.Click public and remove the TButton.Click | ||||
| Steps To Reproduce | 1. Drop button on form (Button1). 2. Create function: Function TForm1.GetCustomButton : TCustomButton; begin Result:=Button1; end; 3. Create OnShow event: Procedure TForm1.OnShow(Sender : TObject) Var B : TCustomButton; begin B:=GetCustomButton; if Assigned(B) then B.Click; end; Fails in LCL, works in Delphi | ||||
| Tags | No tags attached. | ||||
| Fixed in Revision | r44451 | ||||
| LazTarget | - | ||||
| Widgetset | GTK, GTK 2, Win32/Win64, WinCE, Carbon, Cocoa, QT, fpGUI, CustomDrawn | ||||
| Attached Files |
| ||||
|
|
Done. The same change was required for TCustomBitBtn and TTICustomButton but I don't see any problem with it. |
|
|
Shall we merge it to 1.2.2 ? |
|
|
> Shall we merge it to 1.2.2 ? I don't know. It is up to you. This is somewhere between a bug fix and a feature. |
|
|
@Juha we must discuss such patches on mailing list (and other issues which I marked as possible merging). This is not feature (but changes interface section), but bug (delphi compatibile). While agreement is that only bug fixes goes to stable fixes this should go there IMO. Please add it to the fixes by yourself. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-03-16 11:13 | Michael Van Canneyt | New Issue | |
| 2014-03-16 23:45 | Juha Manninen | Assigned To | => Juha Manninen |
| 2014-03-16 23:45 | Juha Manninen | Status | new => assigned |
| 2014-03-16 23:48 | Juha Manninen | Fixed in Revision | => r44451 |
| 2014-03-16 23:48 | Juha Manninen | Note Added: 0073753 | |
| 2014-03-16 23:48 | Juha Manninen | Status | assigned => resolved |
| 2014-03-16 23:48 | Juha Manninen | Resolution | open => fixed |
| 2014-03-17 07:47 | Zeljan Rikalo | Note Added: 0073759 | |
| 2014-03-17 08:32 | Juha Manninen | Note Added: 0073764 | |
| 2014-03-17 11:22 | Zeljan Rikalo | Note Added: 0073770 |
