View Issue Details

IDProjectCategoryView StatusLast Update
0027310LazarusDebuggerpublic2015-01-15 16:58
ReporterBart BroersmaAssigned ToMartin Friebe 
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Platformi386OSWindowOS VersionWin7
Product Version1.5 (SVN)Product Build 
Target Version1.4Fixed in Version1.5 (SVN) 
Summary0027310: lazdebuggergdbmi/cmdlinedebugger: fix for Todo: use newconsole for Win9x
DescriptionTCmdLineDebugger.CreateDebugProcess has:
// TODO: under win9x and winMe should be created with console,

Attached is possible patch for this.
TagsNo tags attached.
Fixed in Revision47385
LazTarget1.4
WidgetsetWin32/Win64
Attached Files
  • lazdebugger.diff (1,075 bytes)
    Index: components/lazdebuggergdbmi/cmdlinedebugger.pp
    ===================================================================
    --- components/lazdebuggergdbmi/cmdlinedebugger.pp	(revision 47338)
    +++ components/lazdebuggergdbmi/cmdlinedebugger.pp	(working copy)
    @@ -333,9 +333,14 @@
       then begin
         FDbgProcess := TProcessUTF8.Create(nil);
         FDbgProcess.CommandLine := ExternalDebugger + ' ' + AOptions;
    -    // TODO: under win9x and winMe should be created with console,
    +    {$if defined(windows) and not defined(wince)}
    +    // under win9x and winMe should be created with console,
         // otherwise no break can be sent.
    -    FDbgProcess.Options:= [poUsePipes, poNoConsole, poStdErrToOutPut, poNewProcessGroup];
    +    if Win32MajorVersion <= 4 then
    +      FDbgProcess.Options:= [poUsePipes, poNewConsole, poStdErrToOutPut, poNewProcessGroup];
    +    else
    +    {$endif windows}
    +      FDbgProcess.Options:= [poUsePipes, poNoConsole, poStdErrToOutPut, poNewProcessGroup];
         FDbgProcess.ShowWindow := swoNone;
         FDbgProcess.Environment:=DebuggerEnvironment;
       end;
    
    lazdebugger.diff (1,075 bytes)

Activities

Bart Broersma

2015-01-14 12:52

developer  

lazdebugger.diff (1,075 bytes)
Index: components/lazdebuggergdbmi/cmdlinedebugger.pp
===================================================================
--- components/lazdebuggergdbmi/cmdlinedebugger.pp	(revision 47338)
+++ components/lazdebuggergdbmi/cmdlinedebugger.pp	(working copy)
@@ -333,9 +333,14 @@
   then begin
     FDbgProcess := TProcessUTF8.Create(nil);
     FDbgProcess.CommandLine := ExternalDebugger + ' ' + AOptions;
-    // TODO: under win9x and winMe should be created with console,
+    {$if defined(windows) and not defined(wince)}
+    // under win9x and winMe should be created with console,
     // otherwise no break can be sent.
-    FDbgProcess.Options:= [poUsePipes, poNoConsole, poStdErrToOutPut, poNewProcessGroup];
+    if Win32MajorVersion <= 4 then
+      FDbgProcess.Options:= [poUsePipes, poNewConsole, poStdErrToOutPut, poNewProcessGroup];
+    else
+    {$endif windows}
+      FDbgProcess.Options:= [poUsePipes, poNoConsole, poStdErrToOutPut, poNewProcessGroup];
     FDbgProcess.ShowWindow := swoNone;
     FDbgProcess.Environment:=DebuggerEnvironment;
   end;
lazdebugger.diff (1,075 bytes)

Martin Friebe

2015-01-14 18:42

manager   ~0080407

Please test and close if ok / Will merge once tested

Bart Broersma

2015-01-15 01:09

developer   ~0080421

Running a program in the IDE now opens a console (title: gdb).
What more needs to be tested?

Bart Broersma

2015-01-15 16:58

developer   ~0080429

As discussed on dev-ML.

Issue History

Date Modified Username Field Change
2015-01-14 12:52 Bart Broersma New Issue
2015-01-14 12:52 Bart Broersma Status new => assigned
2015-01-14 12:52 Bart Broersma Assigned To => Martin Friebe
2015-01-14 12:52 Bart Broersma File Added: lazdebugger.diff
2015-01-14 18:42 Martin Friebe Fixed in Revision => 47385
2015-01-14 18:42 Martin Friebe LazTarget - => 1.4
2015-01-14 18:42 Martin Friebe Note Added: 0080407
2015-01-14 18:42 Martin Friebe Status assigned => resolved
2015-01-14 18:42 Martin Friebe Fixed in Version => 1.5 (SVN)
2015-01-14 18:42 Martin Friebe Resolution open => fixed
2015-01-14 18:42 Martin Friebe Target Version => 1.4
2015-01-15 01:09 Bart Broersma Note Added: 0080421
2015-01-15 01:09 Bart Broersma Status resolved => assigned
2015-01-15 01:09 Bart Broersma Resolution fixed => reopened
2015-01-15 15:23 Martin Friebe Status assigned => resolved
2015-01-15 15:23 Martin Friebe Resolution reopened => fixed
2015-01-15 16:58 Bart Broersma Note Added: 0080429
2015-01-15 16:58 Bart Broersma Status resolved => closed