|
|
|
|
|
|
Details. test shows:
a) form Height is 603, while image has visible height
about 640.
b) form ClientHeight 603!! so issue exists: Height=ClientHeight while it's not ok for win32, do you agree? or is it done special? to not handle Win stuff, not calc wnd border? |
|
|
|
customform.inc.patch (1,617 bytes)
Index: customform.inc
===================================================================
--- lcl/include/customform.inc (revision 51106)
+++ lcl/include/customform.inc (working copy)
@@ -1279,9 +1279,9 @@
end;
var
- X, Y: integer;
+ X, Y, BorderW, BorderH: integer;
p: TPosition;
- AForm: TCustomForm;
+ AForm: TCustomForm; rcWindow, rcClient:TRect;
begin
if (Parent <> nil) or (ParentWindow <> 0) then exit;
@@ -1291,6 +1291,12 @@
X := Left;
Y := Top;
+ {$IFDEF Windows}
+ rcClient:=GetClientRect; GetWindowRect(Handle, rcWindow);
+ BorderW := (rcWindow.Right - rcWindow.Left) - rcClient.Right;
+ BorderH := (rcWindow.Bottom - rcWindow.Top) - rcClient.Bottom;
+ {$ENDIF}
+
p := Position;
if (Position = poMainFormCenter) and (Application.Mainform=nil) then
p := poScreenCenter;
@@ -1297,13 +1303,13 @@
case P of
poDesktopCenter:
begin
- X := Screen.DesktopLeft + (Screen.DesktopWidth - Width) div 2;
- Y := Screen.DesktopTop +(Screen.DesktopHeight - Height) div 2;
+ X := Screen.DesktopLeft + (Screen.DesktopWidth - (Width{$IFDEF Windows}+BorderW{$ENDIF})) div 2;
+ Y := Screen.DesktopTop +(Screen.DesktopHeight - (Height{$IFDEF Windows}+BorderH{$ENDIF})) div 2;
end;
poScreenCenter:
begin
- X := (Screen.Width - Width) div 2;
- Y := (Screen.Height - Height) div 2;
+ X := (Screen.Width - (Width{$IFDEF Windows}+BorderW{$ENDIF})) div 2;
+ Y := (Screen.Height - (Height{$IFDEF Windows}+BorderH{$ENDIF})) div 2;
end;
poMainFormCenter,
poOwnerFormCenter:
|
|
|
|
My patch seems resolved the problem. |
|
|
|
Good that patch is only here (calc position).Not inside calc of Height/Width. So noone should break.
|
|
|
|
A cross-platform solution (no ifdef's)would be nice(er). |
|
|
|
Yes, I know... This is temporary workaround only for Windows, but it is better than nothing ;) |
|
|
|
Fixed with a cross-platform solution.
Info: it works on Windows. It doesn't work on Linux/X11, but this is another problem (related to WM, see http://stackoverflow.com/questions/7408082/how-to-get-the-width-of-a-window-frame-before-creating-any-windows ). The real form bounds can be obtained from X11 only after the form has been shown. |
|
