PackgEditor. new look, no AddMore btn

Original Reporter info from Mantis: Alextp

• Reporter name: CudaText man

Description:

Juha wrote to see.I see it.My try. No Addmore btn. N functions of Addmore now lie inside Add..

Mantis conversion info:

• Mantis ID: 28097
• Version: 1.5 (SVN)
• Fixed in revision: r49046 (#9bbdc4fe), r49096 (#4be54721), r50815 (#5229da3d)

assigned to @JuhaManninen

added CategoryIDE Version1.5 (SVN) labels

Converted from Mantis. Note by CudaText man

• Mantis submitter username: Alextp
• Mantis submitter real name: CudaText man

---

ADD press-- gives menu
 Add file
 ---
 Add files..
 New file
 New comp
 New req

Converted from Mantis. Note by Juha Manninen @JuhaManninen

• Mantis submitter username: JuhaManninen @JuhaManninen
• Mantis submitter real name: Juha Manninen

---

Not bad! I modified the patch and committed in r49046. This is only the first step to improve the GUI. Other good ideas from Michael Van Canneyt are listed in this mail thread :
http://free-pascal-lazarus.989080.n3.nabble.com/Lazarus-Package-dialog-tt4041400.html#none
Popup menus also need attention. Later the Project Inspector will need similar changes.
This issue can be kept open and possible future patches can be attached here.

Converted from Mantis. Note by CudaText man

• Mantis submitter username: Alextp
• Mantis submitter real name: CudaText man

---

make clear. I make NEW dialog called from pack-ed. Dialog needed with ALL items? or only 'module'? Add ALL items to package? Also 'inherited', 'new project'

Converted from Mantis. Note by Juha Manninen @JuhaManninen

• Mantis submitter username: JuhaManninen @JuhaManninen
• Mantis submitter real name: Juha Manninen

---

New dialog for what? The "Add dependency" feature maybe needs a new dialog or maybe the existing ""Open loaded package" can be used.
The "Add files in directory" feature must be rethought and maybe removed.

"New project" is not related to package editor at all.

Converted from Mantis. Note by CudaText man

• Mantis submitter username: Alextp
• Mantis submitter real name: CudaText man

---

I post patch step-2. if you call "Pkg ed - Add>> - New file"
dialog of NewDialog will show. Only for modules (new Pas module, new Sql file, new txt file)

Converted from Mantis. Note by CudaText man

• Mantis submitter username: Alextp
• Mantis submitter real name: CudaText man

---

I don't understand ur answer. So see a patch

Converted from Mantis. Note by Juha Manninen @JuhaManninen

• Mantis submitter username: JuhaManninen @JuhaManninen
• Mantis submitter real name: Juha Manninen

---

Ok, the unit's name is NewDialog. Now I understand. Anyway, a patch speaks more than a thousand words, as we all know.
This is very good refactoring. I did not even realize that this dialog can be reused so easily.
Thanks!

I committed the patch in r49096 after some modifications. I removed the useless GUI elements and related code in TAddToPackageDlg.
Your patch freed the NewItem (TNewIDEItemTemplate) in TPackageEditorForm.mnuAddNewFileClick which is wrong and caused a crash when adding a file more than once. Now it works.

This change caused one clear visual improvement. The NewDialog has icons in its TreeView, the old GUI did not have them.

Converted from Mantis. Note by CudaText man

• Mantis submitter username: Alextp
• Mantis submitter real name: CudaText man

---

What else, what can be done more.Fixin of contx menu?It's not work which is interesting and i don't see why menu is bad.

Converted from Mantis. Note by Ondrej Pokorny @onpok

• Mantis submitter username: kluug.net @onpok
• Mantis submitter real name: Ondrej Pokorny

---

I think it would be a good idea to add a "Add ..." menu item to the tree view to have the same behavior like it is in Project Inspector. Please see http://bugs.freepascal.org/view.php?id=28192 - i changed the behavior of the "Add ..." menu item there. If you think that patch is worth committing I'll do the same for Package Editor.

Converted from Mantis. Note by Juha Manninen @JuhaManninen

• Mantis submitter username: JuhaManninen @JuhaManninen
• Mantis submitter real name: Juha Manninen

---

Yes, the popup menu needs renovation. See ideas from Michael Van Canneyt in the mail thread I referred in an earlier comment.
Maybe you Alexey and Ondrej can co-operate. There is a danger that you do similar changes without knowing about each other.

Converted from Mantis. Note by CudaText man

• Mantis submitter username: Alextp
• Mantis submitter real name: CudaText man

---

..See ideas from Michael Van Canneyt in the mail thread
I saw it, read 2 times not all thread.I saw idea how to change popmenu and other text was too bloated. What is it but/except popmenu? Can u paste...

Converted from Mantis. Note by Ondrej Pokorny @onpok

• Mantis submitter username: kluug.net @onpok
• Mantis submitter real name: Ondrej Pokorny

---

I will definitely wait until my other patches will be resolved before I fix other things. It's already hard for me to follow which patch needs which files. After that we can discuss what to do next.

Converted from Mantis. Note by CudaText man

• Mantis submitter username: Alextp
• Mantis submitter real name: CudaText man

---

Other patches resolved?

Converted from Mantis. Note by Ondrej Pokorny @onpok

• Mantis submitter username: kluug.net @onpok
• Mantis submitter real name: Ondrej Pokorny

---

I'm working hard on different patches, if you see what issues I sent recently :) But yes, when I have time, I'll add the menu items here as well.

Converted from Mantis. Note by Juha Manninen @JuhaManninen

• Mantis submitter username: JuhaManninen @JuhaManninen
• Mantis submitter real name: Juha Manninen

---

Package editor works well now. Please test.
The latest commit will be merged to 1.6, too.

closed

Attached files:

• dif-newdialog2.diff (Size: 12131 bytes, user: Alextp (CudaText man), date: 2015-05-18)
• dif-newdialog.diff (Size: 7855 bytes, user: Alextp (CudaText man), date: 2015-05-18)
• dif.diff (Size: 25863 bytes, user: Alextp (CudaText man), date: 2015-05-15)
• (Size: 17556 bytes, user: Alextp (CudaText man), date: 2015-05-15)

marked this issue as related to #28192 (closed)