View Issue Details

IDProjectCategoryView StatusLast Update
0029186FPCUtilitiespublic2017-05-24 21:56
ReporterAndrey CherepanovAssigned ToTomas Hajny 
PrioritynormalSeverityminorReproducibilityhave not tried
Status feedbackResolutionopen 
PlatformLinuxOSALT LinuxOS VersionSisyphus
Product Version3.0.0Product Build 
Target VersionFixed in Version 
Summary0029186: writeidx hangs up (circular call)
DescriptionIf I call writeidx fpctoc.html from fpcdocs subdirectory, this program is never finished.
After I put Writeln('Processing '+Doc^.GetDocumentURL); in procedure TFPHTMLFileLinkScanner.ProcessDoc (fpcbuild/fpcsrc/installer/writeidx.pas) I see curcular processing of fpctoc.html without got to links.

Please, check work of writeidx. It will be useful to show progress of its work.
TagsNo tags attached.
Fixed in Revision
FPCOldBugId
FPCTarget
Attached Files
  • fpc-writeidx-show-progress.patch (381 bytes)
    diff --git a/fpcbuild/fpcsrc/installer/writeidx.pas b/fpcbuild/fpcsrc/installer/writeidx.pas
    index 63434eb..cd565f3 100644
    --- a/fpcbuild/fpcsrc/installer/writeidx.pas
    +++ b/fpcbuild/fpcsrc/installer/writeidx.pas
    @@ -32,6 +32,7 @@
     
       procedure TFPHTMLFileLinkScanner.ProcessDoc(Doc: PHTMLLinkScanFile);
         begin
    +      Writeln('Processing '+Doc^.GetDocumentURL);
         end;
     
     
    

Activities

Andrey Cherepanov

2015-12-14 12:00

reporter  

fpc-writeidx-show-progress.patch (381 bytes)
diff --git a/fpcbuild/fpcsrc/installer/writeidx.pas b/fpcbuild/fpcsrc/installer/writeidx.pas
index 63434eb..cd565f3 100644
--- a/fpcbuild/fpcsrc/installer/writeidx.pas
+++ b/fpcbuild/fpcsrc/installer/writeidx.pas
@@ -32,6 +32,7 @@
 
   procedure TFPHTMLFileLinkScanner.ProcessDoc(Doc: PHTMLLinkScanFile);
     begin
+      Writeln('Processing '+Doc^.GetDocumentURL);
     end;
 
 

Tomas Hajny

2016-06-20 00:19

manager   ~0093290

Thanks for reporting this issue - the program is clearly buggy and not able to do anything useful. Worse, it's probably been that way since its creation more than 10 years ago. Let's start with another question, though: What was your intention when calling it? I ask because it seems to me that the program should be removed rather than fixed, but I'd like to check if there is some reason why it should be needed anyway.

Thaddy de Koning

2016-06-20 08:24

reporter   ~0093292

Note it looks somewhat debuggable to an extend by adding option -dDEBUG when compiling, which will give debugmessage output. (NOT $D+, nor {$DEBUGINFO ON} but -dDEBUG). See WHTMLScn source in ide directory.

Tomas Hajny

2016-06-20 09:10

manager   ~0093293

@Thaddy: Yes, I know. It wasn't very difficult to find out what's going on - ProcessDoc is overridden, the original one processes the document and moves on, but the overridden one does nothing. Still, the question is what's the point in using this standalone utility. What should be the supposed consumer of the created index? The text-mode IDE can do this internally. The text-mode installer (GO32v2 and OS/2) creates the index for the IDE internally. The external utility might be used by install.sh and/or the Windows installer to prepare the index for the text-mode IDE, but that doesn't happen now and nobody missed it so far as far as I can see. Moreover, it might be easier and more efficient to use the .chm version nowadays.

Marco van de Voort

2017-05-24 21:56

manager   ~0100660

Maybe simply remove it?

Issue History

Date Modified Username Field Change
2015-12-14 12:00 Andrey Cherepanov New Issue
2015-12-14 12:00 Andrey Cherepanov File Added: fpc-writeidx-show-progress.patch
2015-12-14 13:22 Jonas Maebe Assigned To => Tomas Hajny
2015-12-14 13:22 Jonas Maebe Status new => assigned
2016-06-20 00:19 Tomas Hajny Note Added: 0093290
2016-06-20 00:19 Tomas Hajny Status assigned => feedback
2016-06-20 08:24 Thaddy de Koning Note Added: 0093292
2016-06-20 09:10 Tomas Hajny Note Added: 0093293
2017-05-24 21:56 Marco van de Voort Note Added: 0100660