View Issue Details

IDProjectCategoryView StatusLast Update
0029271FPCPackagespublic2020-02-11 20:28
ReporterMarco van de Voort Assigned ToJoost van der Sluis  
PrioritynormalSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Platformgo32v2 
Product Version3.0.0 
Summary0029271: uregdos.zip contains multiple files (fpmake?)
Description(reported by Rugxulo on dos forum)

BTW, some .ZIPs have duplicate files in them, apparently due to some naming quirk:


CRC32: 0x0ea599f1
file: ./uregdos.zip, examples/regexpr/./testreg1.pp
file: ./uregdos.zip, examples/regexpr/testreg1.pp


So someone (or a rogue makefile?) is mistakenly adding various example files twice.
TagsNo tags attached.
Fixed in Revision
FPCOldBugId0
FPCTarget
Attached Files

Activities

Marco van de Voort

2017-03-01 15:42

manager   ~0098540

Still the case with 3.0.2

Marco van de Voort

2018-01-01 17:59

manager   ~0105229

And with 3.0.4. For uregdos the list is

  71693 Defl:N 9697 87% 2017-09-02 18:48 8601143f examples/regexpr/./Makefile
     168 Defl:N 124 26% 2008-12-20 23:32 1785db3d examples/regexpr/./Makefile.fpc
   27804 Defl:N 2813 90% 2011-08-29 13:14 0ea599f1 examples/regexpr/./testreg1.pp
   27804 Defl:N 2813 90% 2011-08-29 13:14 0ea599f1 examples/regexpr/testreg1.pp

So it seems there is a dir scan that generates the /./ files, and a normal reference to the testreg without :

 P.Targets.AddExampleProgram('testreg1.pp');
 P.Sources.AddExampleFiles('examples/*',P.Directory,false,'.');

So probably a path sanitation issue in addexamplefiles.

Marco van de Voort

2018-01-02 20:00

manager   ~0105269

If I run make zipsourceinstall on windows in regexpr the makefile line

    $(LOCALFPMAKE) archive $(FPMAKE_OPT) --zipprefix=$(DIST_DESTDIR)/$(ZIPPREFIX) --prefix=source\\$(INSTALL_FPCSUBDIR)\\\$$\(PACKAGEDIRECTORY\)

with

make INSTALL_FPCSUBDIR=x

evaluates to : --prefix=source\\x\\\$\(PACKAGEDIRECTORY\)

Note the chaos of escaping in this command. Similar problems might be the root cause of this problem on whatever target this is generated.

Issue History

Date Modified Username Field Change
2015-12-28 14:33 Marco van de Voort New Issue
2017-03-01 15:42 Marco van de Voort Note Added: 0098540
2018-01-01 17:59 Marco van de Voort Note Added: 0105229
2018-01-02 20:00 Marco van de Voort Note Added: 0105269
2020-02-11 20:28 Joost van der Sluis Assigned To => Joost van der Sluis
2020-02-11 20:28 Joost van der Sluis Status new => assigned