View Issue Details

IDProjectCategoryView StatusLast Update
0029668FPCPackagespublic2019-12-31 16:14
ReporterlksAssigned ToJonas Maebe 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformdarwinOSOSXOS Version10.11
Product Version3.1.1Product Build33101 
Target VersionFixed in Version3.2.0 
Summary0029668: darwin: cocoaint appkit/NSGraphicsContext.inc missing instance methods
DescriptionIn Objective C, saveGraphicsState and restoreGraphicsState are available as both class methods and instance methods. However, in appkit/NSGraphicsContext.inc, the routines are only available as class methods.

Suggested patch included (untested) to provide access to the instance methods.
TagsNo tags attached.
Fixed in Revision42501
FPCOldBugId
FPCTarget-
Attached Files
  • nsgraphicscontext.diff (738 bytes)
    Index: NSGraphicsContext.inc
    ===================================================================
    --- NSGraphicsContext.inc	(revision 33101)
    +++ NSGraphicsContext.inc	(working copy)
    @@ -76,6 +76,8 @@
         class procedure setGraphicsState(gState: NSInteger); message 'setGraphicsState:';
         function attributes: NSDictionary; message 'attributes';
         function isDrawingToScreen: Boolean; message 'isDrawingToScreen';
    +    procedure saveGraphicsStateInstance; message 'saveGraphicsState';
    +    procedure restoreGraphicsStateInstance; message 'restoreGraphicsState';
         procedure flushGraphics; message 'flushGraphics';
         function graphicsPort: Pointer; message 'graphicsPort';
         function isFlipped: Boolean; message 'isFlipped';
    

Activities

lks

2016-02-17 17:17

reporter  

nsgraphicscontext.diff (738 bytes)
Index: NSGraphicsContext.inc
===================================================================
--- NSGraphicsContext.inc	(revision 33101)
+++ NSGraphicsContext.inc	(working copy)
@@ -76,6 +76,8 @@
     class procedure setGraphicsState(gState: NSInteger); message 'setGraphicsState:';
     function attributes: NSDictionary; message 'attributes';
     function isDrawingToScreen: Boolean; message 'isDrawingToScreen';
+    procedure saveGraphicsStateInstance; message 'saveGraphicsState';
+    procedure restoreGraphicsStateInstance; message 'restoreGraphicsState';
     procedure flushGraphics; message 'flushGraphics';
     function graphicsPort: Pointer; message 'graphicsPort';
     function isFlipped: Boolean; message 'isFlipped';

Jonas Maebe

2019-12-31 16:14

manager   ~0120169

To be consistent with other such cases, I gave the class method a "class" prefix rather than using an "Instance" suffix for the instance method.

Issue History

Date Modified Username Field Change
2016-02-17 17:17 lks New Issue
2016-02-17 17:17 lks File Added: nsgraphicscontext.diff
2019-12-31 16:14 Jonas Maebe Assigned To => Jonas Maebe
2019-12-31 16:14 Jonas Maebe Status new => resolved
2019-12-31 16:14 Jonas Maebe Resolution open => fixed
2019-12-31 16:14 Jonas Maebe Fixed in Version => 3.2.0
2019-12-31 16:14 Jonas Maebe Fixed in Revision => 42501
2019-12-31 16:14 Jonas Maebe FPCTarget => -
2019-12-31 16:14 Jonas Maebe Note Added: 0120169