MSWindows: ModalForm should be minimized into task bar
Original Reporter info from Mantis: zeljko@holobit.net @zeljan1
-
Reporter name: Zeljan Rikalo
Original Reporter info from Mantis: zeljko@holobit.net @zeljan1
- Reporter name: Zeljan Rikalo
Description:
When we minimize modal form it should be minimized into icon of application not over start button. Only MSWindows widgetsets are affected.
Mantis conversion info:
Designs
Activity
added CategoryWidgetset WS: Win32/64 labels
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
Qt is fixed with r51727
-
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
Win32 is fixed in r51728. Needs feedback from users before closing and adding to fixes 1.6
-
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
win32, r51279 is also important for fixes. It doesn't allow to activate non-modal window if app is minimized together with modal window(s). In that case we are calling app restore.
-
Converted from Mantis. Note by Denis Kozlov
- Mantis submitter username: dezlov
- Mantis submitter real name: Denis Kozlov
I tested Win32 on Windows 7 and found couple of issues.
Each modal forms now appears on the taskbar as a separate button. Even if it is closed and then shown as a normal non-modal form, it still appears on the taskbar.
Maybe using "Params.Parent := Windows.GetDesktopWindow" at a window handle creation is not appropriate. This affects the whole life-cycle of the form.
-
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
r51730 fixes Qt behaviour in same manner as r51729
-
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
@Denis, can you:
Create separate issue for your observations and attach example or attach example project here so I can easy reproduce it and fix. -
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
Sorry, haven't seen example project here :)
-
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
hm...that really doesn't look good. Problematic part is GetRealPopupParent in CreateParams.
-
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
@Denis, will be nice if you can test now and give feedback. Note that I'm doing all tests on Win 10 Pro 64bit and minimized modal forms are not above start button as in your screenshoot.
-
Converted from Mantis. Note by Denis Kozlov
- Mantis submitter username: dezlov
- Mantis submitter real name: Denis Kozlov
TRUNK r51732
Modal forms no longer get squashed, they get minimized to taskbar as intended. Both Application.Minimize and the minimize frame button work the same way. That is great!
Remaining issue: Every modal form is shown separately on the taskbar (see the screenshot). Changing the default value of TForm.ShowInTaskbar from stDefault to stNever has no effect.
-
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
@Denis: for remaining issue: pls open separate issue for that, write your windows version also, and attach example project. Here everything looks ok, I'm on win10 pro 64bit.
-
Converted from Mantis. Note by Denis Kozlov
- Mantis submitter username: dezlov
- Mantis submitter real name: Denis Kozlov
The remaining issue is reported here:
http://bugs.freepascal.org/view.php?id=29746 -
r51728 is wrong. It just disables PopupParent (WndParent) for pmNone.
1.) If you use
procedure TForm1.Button1Click(Sender: TObject); begin Form2.PopupMode := pmAuto; Form2.ShowModal; end;
The issue is still present.
2.) The modal form &LtPos;b>must have a parent defined&LtPos;/b>!
3.) r51728 also causes the regression #29746 (closed).
-
I also assume that r51727 is wrong (although I couldn't test because I don't have Qt installed on windows).
The window parent should always be set according to GetRealPopupParent.
-
Converted from Mantis. Note by Zeljan Rikalo @zeljan1
- Mantis submitter username: zeljko@holobit.net @zeljan1
- Mantis submitter real name: Zeljan Rikalo
@Ondrej, problem with Windows (win32, not qt) is that WndParent must be known when handle is created, not later like it's possible with Qt.
-
Ondrej, problem with Windows (win32, not qt) is that WndParent must be known when handle is created, not later like it's possible with Qt.
Then RecreateHandle has to be called in ShowModal - at this place the WndParent is known.
-
No, no, no, Zeljko! You were not supposed to include pmAuto into consideration but the code should have shown you that the change is wrong.
The modal window needs WndParent!!!
Please do not solve the following code with the same approach but revert r51728 and 51749 and find a completely different approach without touching WndParent.
procedure TForm1.Button1Click(Sender: TObject); begin Form2.PopupMode := pmExplicit; Form2.PopupParent := Self; Form2.ShowModal; end;