View Issue Details

IDProjectCategoryView StatusLast Update
0030404FPCPackagespublic2016-07-24 09:44
ReporterAlexey Tor.Assigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
PlatformLinuxOSOS Version
Product Version3.1.1Product Build 
Target Version4.0.0Fixed in Version3.1.1 
Summary0030404: Fcl-json wish
Description
1- Wish.
make JsonConf.DefaultJSONOptions as "var", so my app can redefine it (yet it must use parameters to create, create's are 3-4, var is one)

2- this hilited by Laz as unused Priv field, pls del it

  TJSONScanner = class
  private
    FAllowComments: Boolean;

3- jsonScanner has DefaultOptions.
JsonConf has DefaultJSONOptions
Maybe no need?

TagsNo tags attached.
Fixed in Revision34199
FPCOldBugId
FPCTarget
Attached Files

Activities

Michael Van Canneyt

2016-07-24 09:44

administrator   ~0093809

1) I cannot make DefaultJSONOptions a var for 2 Reasons.
  * It is used in JSONOptions' "default" keyword
  * If you change it, any 3rd party code you use which also uses JSONConf will maybe misbehave.
    Everyone would have to check the value of this variable before creating a TJSONConfig instance.

2) Fixed.

3) If you look at these 2 constants, you see they are different.
   For JSONConf, the comments are allowed, it makes sense.
   For the scanner, they are by default not allowed, and that must remain so, for example for backwards compatibility.

Issue History

Date Modified Username Field Change
2016-07-23 23:16 Alexey Tor. New Issue
2016-07-24 09:37 Michael Van Canneyt Assigned To => Michael Van Canneyt
2016-07-24 09:37 Michael Van Canneyt Status new => assigned
2016-07-24 09:44 Michael Van Canneyt Fixed in Revision => 34199
2016-07-24 09:44 Michael Van Canneyt Note Added: 0093809
2016-07-24 09:44 Michael Van Canneyt Status assigned => resolved
2016-07-24 09:44 Michael Van Canneyt Fixed in Version => 3.1.1
2016-07-24 09:44 Michael Van Canneyt Resolution open => fixed
2016-07-24 09:44 Michael Van Canneyt Target Version => 4.0.0