View Issue Details

IDProjectCategoryView StatusLast Update
0030605LazarusPackagespublic2016-11-07 08:17
ReporterPascal RiekenbergAssigned ToMartin Friebe 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.7 (SVN)Product Build 
Target Version1.8Fixed in Version1.7 (SVN) 
Summary0030605: [SynEdit] fMarkupManger.TextChanged gets called with indices instead of linenumbers
DescriptionfMarkupManger.TextChanged gets called with indices instead of linenumbers.

Which can cause RangeCheckErrors in DoTextChange of markups
TagsNo tags attached.
Fixed in Revision52982
LazTarget1.8
Widgetset
Attached Files
  • synedit.pp_index_instead_of_line.patch (474 bytes)
    Index: synedit.pp
    ===================================================================
    --- synedit.pp	(revision 52981)
    +++ synedit.pp	(working copy)
    @@ -8062,7 +8130,7 @@
       if fHighlighter.AttributeChangeNeedScan then begin
         FHighlighter.CurrentLines := FTheLinesView;
         FHighlighter.ScanAllRanges;
    -    fMarkupManager.TextChanged(0, FTheLinesView.Count - 1, 0);
    +    fMarkupManager.TextChanged(1, FTheLinesView.Count, 0);
         TopView := TopView;
       end;
     end;
    

Activities

Pascal Riekenberg

2016-09-16 14:51

reporter  

synedit.pp_index_instead_of_line.patch (474 bytes)
Index: synedit.pp
===================================================================
--- synedit.pp	(revision 52981)
+++ synedit.pp	(working copy)
@@ -8062,7 +8130,7 @@
   if fHighlighter.AttributeChangeNeedScan then begin
     FHighlighter.CurrentLines := FTheLinesView;
     FHighlighter.ScanAllRanges;
-    fMarkupManager.TextChanged(0, FTheLinesView.Count - 1, 0);
+    fMarkupManager.TextChanged(1, FTheLinesView.Count, 0);
     TopView := TopView;
   end;
 end;

Issue History

Date Modified Username Field Change
2016-09-16 14:51 Pascal Riekenberg New Issue
2016-09-16 14:51 Pascal Riekenberg File Added: synedit.pp_index_instead_of_line.patch
2016-09-16 15:11 Martin Friebe Assigned To => Martin Friebe
2016-09-16 15:11 Martin Friebe Status new => assigned
2016-09-16 20:29 Martin Friebe Fixed in Revision => 52982
2016-09-16 20:29 Martin Friebe LazTarget => 1.8
2016-09-16 20:29 Martin Friebe Status assigned => resolved
2016-09-16 20:29 Martin Friebe Fixed in Version => 1.7 (SVN)
2016-09-16 20:29 Martin Friebe Resolution open => fixed
2016-09-16 20:29 Martin Friebe Target Version => 1.8
2016-11-07 08:17 Pascal Riekenberg Status resolved => closed