| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0030661 | Lazarus | LCL | public | 2016-09-28 13:54 | 2017-06-05 00:08 |
| Reporter | jakyro | Assigned To | Michl | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | OS | Windows | OS Version | 10 | |
| Product Version | 1.6 | Product Build | 51630 | ||
| Target Version | 1.8 | Fixed in Version | 1.9 (SVN) | ||
| Summary | 0030661: TTreeView memory leak (WARNING: TResourceCacheItem.IncreaseRefCount 1000 TPenHandleCache) | ||||
| Description | TreeView memory leak. Create Win32/64 LCL application, add TreeView on MainForm, run and start resize MainForm until the message in console/log: WARNING: TResourceCacheItem.IncreaseRefCount 1000 TPenHandleCache WARNING: TResourceCacheItem.IncreaseRefCount 10000 TPenHandleCache I tested it on Windows 10.0.10586 and 10.0.14393. | ||||
| Steps To Reproduce | Windows 10.0.10586/10.0.14393 lazarus-1.6.0-fpc-3.0.0-win32/win64 2016-02-15 1. Create LCL graphical application "Menu/File/New.../Project/Application". Create MainForm if not created. 2. Create TreeView on MainForm and add TreeView items 1 or more. 3. Uncheck "Project Options.../Config and Target/Win32 gui application (-WG)" to see console messages OR run application with argument "--debug-log=log.txt". 4. Run application. Start resize MainForm (for repaint TreeView) from current size to zero and back, until the message (or close application to save log.txt if application running with --debug-log): WARNING: TResourceCacheItem.IncreaseRefCount 1000 TPenHandleCache WARNING: TResourceCacheItem.IncreaseRefCount 10000 TPenHandleCache | ||||
| Additional Information | WARNING: TResourceCacheItem.IncreaseRefCount 1000 TPenHandleCache WARNING: TResourceCacheItem.IncreaseRefCount 10000 TPenHandleCache | ||||
| Tags | IncreaseRefCount, lcl, TPenHandleCache, TResourceCacheItem, ttreeview, warnings | ||||
| Fixed in Revision | r55118 | ||||
| LazTarget | - | ||||
| Widgetset | Win32/Win64 | ||||
| Attached Files |
| ||||
|
|
treeview-cache.png (39,886 bytes) |
|
|
How often do you need to resize? I can't reproduce the bug under Linux/Gtk2. Maybe Win32 only issue. |
|
|
Lazarus 1.7 r52861 FPC 3.0.0 i386-win32-win32/win64 I automated the resize: Counter = 165 WARNING: TResourceCacheItem.IncreaseRefCount 1000 TPenHandleCache Counter = 1665 WARNING: TResourceCacheItem.IncreaseRefCount 10000 TPenHandleCache Note: the TreevIew must have Items, otherwise this issue does not happen. |
|
|
While redrawing, all calls to TPen.FreeReference say: FReference.Allocated=FALSE and also in all calls to TPen.ReferenceNeeded it says FReference.Allocated=FALSE So, pens are added to the cache, but never seem to get deleted from it. |
|
|
How to fix it? I can not continue to create my project with this bug. |
|
|
I can't reproduce the bug under Windows either. Please attach an example unit to reproduce the problem. |
|
|
tvpencache.zip (65,635 bytes) |
|
|
Sample project attached (tvpencache.zip). Unzip, build and run from commandline like this: C:\Users\Bart\LazarusProjecten\bugs\TreeViewPenCache>tvpencache | grep WARNING --before-context=1 Output on my system (Lazarus 1.7 r52861 FPC 3.0.0 i386-win32-win32 on Win7-64): Counter = 165 WARNING: TResourceCacheItem.IncreaseRefCount 1000 TPenHandleCache -- Counter = 1665 WARNING: TResourceCacheItem.IncreaseRefCount 10000 TPenHandleCache |
|
|
I can confirm this issue under win32. Does not happen with qt under win32, also does not happen under linux gtk2/qt. |
|
|
example_treeview_warning.zip (65,636 bytes) |
|
|
> I can not continue to create my project with this bug. I ran my sample program for > 500000 iterations. There were no errors, crashes or Windows complaining. Also heaptrace reported no memory leaks. So, whilst this is a bug, it should not prevet you from developing your program. |
|
|
Fixed in trunk. Please test and close if OK. Btw. there was no memory leak. A new pen wasn't created, because the parameter list was wrong, so Handle 0 was given back. For this Handle 0, the reference count was increased. |
