View Issue Details

IDProjectCategoryView StatusLast Update
0030959FPCRTLpublic2016-11-26 18:06
ReporterAlexey Tor.Assigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version3.1.1Product Build 
Target Version3.2.0Fixed in Version3.1.1 
Summary0030959: Fix comment at sysutils.AdjustLineBreaks
Descriptionsysstr.inc
{ AdjustLineBreaks returns S with all CR characters not followed by LF
    replaced with CR/LF }
// under Linux all CR characters or CR/LF combinations should be replaced with LF


this comment is misleading. What "should" mean. Programmer should? I suggest:
{ AdjustLineBreaks returns S with all occurances of CR+LF, CR (w/o LF), LF replaced
   to one style, given by DefaultTextLineBreakStyle.
   on Windows: CR (w/o LF) and LF will be replaced by CR+LF
   on Unix: CR+LF, CR will be replaced by LF
   on MacOS9: similar, by CR }
 
TagsNo tags attached.
Fixed in Revision34969
FPCOldBugId
FPCTarget
Attached Files

Activities

Michael Van Canneyt

2016-11-26 18:06

administrator   ~0096261

Changed the comment to something - hopefully - more clear.

Issue History

Date Modified Username Field Change
2016-11-20 00:26 Alexey Tor. New Issue
2016-11-20 00:32 Michael Van Canneyt Assigned To => Michael Van Canneyt
2016-11-20 00:32 Michael Van Canneyt Status new => assigned
2016-11-26 18:06 Michael Van Canneyt Fixed in Revision => 34969
2016-11-26 18:06 Michael Van Canneyt Note Added: 0096261
2016-11-26 18:06 Michael Van Canneyt Status assigned => resolved
2016-11-26 18:06 Michael Van Canneyt Fixed in Version => 3.1.1
2016-11-26 18:06 Michael Van Canneyt Resolution open => fixed
2016-11-26 18:06 Michael Van Canneyt Target Version => 3.2.0