| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0031625 | Lazarus | Patch | public | 2017-04-02 22:09 | 2017-04-22 17:38 |
| Reporter | FTurtle | Assigned To | Ondrej Pokorny | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.7 (SVN) | Product Build | 54507 | ||
| Target Version | Fixed in Version | 1.9 (SVN) | |||
| Summary | 0031625: [Patch] New icons for IDE | ||||
| Description | Added to copyright.txt: Following images were created by FTurtle by modifying original images from Silk icon set 1.3: menu directory: menu_view_components.png (from application.png) menu_view_inspector.png (from application.png) menu_view_messages.png (from application.png) menu_view_search_results.png (from application.png, page_white_find.png) Icon for Object Inspector was replaced because it looked very similar to icon for Project Inspector. It was inconvenient for use on toolbar. | ||||
| Tags | No tags attached. | ||||
| Fixed in Revision | 54547, 54648 | ||||
| LazTarget | 1.8 | ||||
| Widgetset | |||||
| Attached Files |
| ||||
|
|
before.png (49,181 bytes) |
|
|
after.png (50,686 bytes) |
|
|
images.zip (2,427 bytes) |
|
|
patch.diff (3,546 bytes) |
|
|
Just in case: This patch requires to regenerate laz_images.res |
|
|
Like icos for OI/ Messages. |
|
|
Thank you. |
|
|
Now I'm doing a new version without copying from Silk icon set. Hope send today later. |
|
|
The icon for Messages is intuitive because the window shows text lines and is located below the editor almost always. The icon for Object Inspector could have something related to "object" and "inspector". Don't know... Anyway it is important to differentiate it from Project Inspector icon. |
|
|
images2.zip (1,979 bytes) |
|
|
patch2.diff (3,377 bytes) |
|
|
> The icon for Object Inspector could have something related to "object" and "inspector" I think it would be good, but I don't know how to do it. At least yet. If I will have an idea, I'll try to implement it. I attached new version with fully own images. (images2.zip, patch2.diff) |
|
|
The Object Inspector icon is fine for me: It highlights the window left to the text editor/form designer which usually is the Object Inspector. If the icon of the Message Window following the same idea is intuitive then the Object Inspector icon should be fine as well. |
|
|
I like the search results icon. But I don't like the other 3 icons because they just emphasize the default window position, not the meaning of the window. E.g. I have the project inspector on the left side :) => I added only menu_view_search_results.png. I keep this issue open for some time if you want to supply other icons. |
|
|
> But I don't like the other 3 icons because they just emphasize the default window position, not the meaning of the window. The single purpose of toolbuttons is easy access to often used functions. What is figured on picture is absolutely no matter. Two conditions must be met: 1. The purpose of the button should be clear with first glance. 2. The picture should not offend the estetic feelings. Picture should not be a brief retelling of the novel "War and Peace", it just needs to be understandable. > E.g. I have the project inspector on the left side :) Yes, I know that some people place project inspector on the left side. Moreover, one of such people gave me an idea to put buttons for access to main windows on editor's toolbar. But I found what there is some trouble with buttons (see before.png) > they just emphasize the default window position, not the meaning of the window. This is not a disadvantage, this is advantage. Just try. > E.g. I have the project inspector on the left side This is the cause why I didn't make icon for Project Inspector. |
|
|
You are right - it's better to have at least some icons than no icons. I'll apply the remaining 3 as well. Anyway we need somebody to recreate Lazarus IDE icons - we need High-DPI icons as well. So your new icons may be replaced in the future because they don't have High-DPI equivalents. IMO the best for the future would be to pick up icons from the Icons8 library: https://icons8.com/ - they offer High-DPI versions, have really lots of them and are free to use for open source projects: https://icons8.com/license/ |
|
|
> I'll apply the remaining 3 as well. OK I have ideas for some other icons and I would like to have time to make them for inclusion in 1.8. Addind new icons or replasing old is not that thing which may generate new bugs, so icons may be added after releasing RC1 and RC2. > Anyway we need somebody to recreate Lazarus IDE icons - we need High-DPI icons as well. So your new icons may be replaced in the future because they don't have High-DPI equivalents. As for High-DPI: 1. As far as I understand all changes with High-DPI will after 1.8 released. So icons included now will in work long time and it will useful for all users at least til version 2.0. 2. I can make High-DPI versions for all my icons. But I need to know format, resolution, naming rules and etc. > IMO the best for the future would be to pick up icons from the Icons8 library I think it is good to use ready icons if they are suitable. But anyway for some icons will be difficult to find ready variants. The decision about which icons to leave homemade, and which to replace with library ones, may be taken between 1.8 and 2.0 |
|
|
> 2. I can make High-DPI versions for all my icons. But I need to know format, resolution, naming rules and etc. There is images/README.txt file with all information you should need. |
|
|
> There is images/README.txt file with all information you should need. Thank you. |
|
|
images_3.zip (7,989 bytes) |
|
|
patch_3.diff (3,282 bytes) |
|
|
Added new version of images (with High-DPI) and patch: images_3.zip patch_3.diff |
|
|
I applied the *3 patch. Thank you! (Will be merged to 1.8 RC1.) |
|
|
Thank you. |
