View Issue Details

IDProjectCategoryView StatusLast Update
0031730LazarusPatchpublic2017-05-02 20:16
ReporterFTurtle Assigned ToOndrej Pokorny  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version1.9 (SVN) 
Summary0031730: [Patches] New icons for Anchor Editor (with High-DPI)
DescriptionPatch contain new icons for Anchor Editor (with High-DPI).
Scaling of pictures in dialog not works yet.
TagsNo tags attached.
Fixed in Revision54799
LazTarget-
Widgetset
Attached Files

Activities

FTurtle

2017-04-28 19:55

reporter  

images.zip (22,627 bytes)

FTurtle

2017-04-28 19:56

reporter  

patch.diff (5,345 bytes)   
Index: designer/anchoreditor.pas
===================================================================
--- designer/anchoreditor.pas	(revision 54762)
+++ designer/anchoreditor.pas	(working copy)
@@ -466,18 +466,18 @@
 
 procedure TAnchorDesigner.LoadGlyphs;
 begin
-  LeftRefLeftSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left');
-  LeftRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_center_horizontal');
+  LeftRefLeftSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left_left');
+  LeftRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left_center');
   LeftRefRightSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left_right');
-  RightRefLeftSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left_right');
-  RightRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_center_horizontal');
-  RightRefRightSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_right');
-  TopRefTopSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top');
-  TopRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_center_vertical');
+  RightRefLeftSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_right_left');
+  RightRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_right_center');
+  RightRefRightSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_right_right');
+  TopRefTopSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top_top');
+  TopRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top_center');
   TopRefBottomSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top_bottom');
-  BottomRefTopSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top_bottom');
-  BottomRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_center_vertical');
-  BottomRefBottomSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_bottom');
+  BottomRefTopSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_bottom_top');
+  BottomRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_bottom_center');
+  BottomRefBottomSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_bottom_bottom');
 end;
 
 procedure TAnchorDesigner.CreateSideControls;
Index: images/copyright.txt
===================================================================
--- images/copyright.txt	(revision 54762)
+++ images/copyright.txt	(working copy)
@@ -11,6 +11,45 @@
 
 Following images were created by FTurtle:
 
+designer directory:
+
+anchor_bottom_bottom.png
+anchor_bottom_bottom_150.png
+anchor_bottom_bottom_200.png
+anchor_bottom_center.png
+anchor_bottom_center_150.png
+anchor_bottom_center_200.png
+anchor_bottom_top.png
+anchor_bottom_top_150.png
+anchor_bottom_top_200.png
+anchor_left_center.png
+anchor_left_center_150.png
+anchor_left_center_200.png
+anchor_left_left.png
+anchor_left_left_150.png
+anchor_left_left_200.png
+anchor_left_right.png
+anchor_left_right_150.png
+anchor_left_right_200.png
+anchor_right_center.png
+anchor_right_center_150.png
+anchor_right_center_200.png
+anchor_right_left.png
+anchor_right_left_150.png
+anchor_right_left_200.png
+anchor_right_right.png
+anchor_right_right_150.png
+anchor_right_right_200.png
+anchor_top_bottom.png
+anchor_top_bottom_150.png
+anchor_top_bottom_200.png
+anchor_top_center.png
+anchor_top_center_150.png
+anchor_top_center_200.png
+anchor_top_top.png
+anchor_top_top_150.png
+anchor_top_top_200.png
+
 menu directory:
 
 menu_clear_all_bookmarks.png
Index: images/laz_images_list.txt
===================================================================
--- images/laz_images_list.txt	(revision 54762)
+++ images/laz_images_list.txt	(working copy)
@@ -218,14 +218,42 @@
 designer/add_sep_below.png
 designer/add_submenu_right.png
 designer/add_submenu_below.png
-designer/anchor_bottom.png
-designer/anchor_center_horizontal.png
-designer/anchor_center_vertical.png
-designer/anchor_left.png
+designer/anchor_bottom_bottom.png
+designer/anchor_bottom_bottom_150.png
+designer/anchor_bottom_bottom_200.png
+designer/anchor_bottom_center.png
+designer/anchor_bottom_center_150.png
+designer/anchor_bottom_center_200.png
+designer/anchor_bottom_top.png
+designer/anchor_bottom_top_150.png
+designer/anchor_bottom_top_200.png
+designer/anchor_left_center.png
+designer/anchor_left_center_150.png
+designer/anchor_left_center_200.png
+designer/anchor_left_left.png
+designer/anchor_left_left_150.png
+designer/anchor_left_left_200.png
 designer/anchor_left_right.png
-designer/anchor_right.png
-designer/anchor_top.png
+designer/anchor_left_right_150.png
+designer/anchor_left_right_200.png
+designer/anchor_right_center.png
+designer/anchor_right_center_150.png
+designer/anchor_right_center_200.png
+designer/anchor_right_left.png
+designer/anchor_right_left_150.png
+designer/anchor_right_left_200.png
+designer/anchor_right_right.png
+designer/anchor_right_right_150.png
+designer/anchor_right_right_200.png
 designer/anchor_top_bottom.png
+designer/anchor_top_bottom_150.png
+designer/anchor_top_bottom_200.png
+designer/anchor_top_center.png
+designer/anchor_top_center_150.png
+designer/anchor_top_center_200.png
+designer/anchor_top_top.png
+designer/anchor_top_top_150.png
+designer/anchor_top_top_200.png
 designer/align.png
 designer/mirror_horizontal.png
 designer/mirror_vertical.png
patch.diff (5,345 bytes)   

FTurtle

2017-04-28 23:54

reporter  

patch2.diff (5,840 bytes)   
Index: designer/anchoreditor.pas
===================================================================
--- designer/anchoreditor.pas	(revision 54762)
+++ designer/anchoreditor.pas	(working copy)
@@ -465,19 +465,31 @@
 end;
 
 procedure TAnchorDesigner.LoadGlyphs;
+
+  function GetSuffix: String;
+    begin
+      if Screen.PixelsPerInch < 144 then Exit('');
+      if Screen.PixelsPerInch < 192 then Exit('_150');
+      Exit('_200');
+    end;
+
+var
+  Suffix: String;
 begin
-  LeftRefLeftSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left');
-  LeftRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_center_horizontal');
-  LeftRefRightSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left_right');
-  RightRefLeftSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left_right');
-  RightRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_center_horizontal');
-  RightRefRightSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_right');
-  TopRefTopSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top');
-  TopRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_center_vertical');
-  TopRefBottomSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top_bottom');
-  BottomRefTopSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top_bottom');
-  BottomRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_center_vertical');
-  BottomRefBottomSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_bottom');
+  Suffix:=GetSuffix;
+
+  LeftRefLeftSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left_left'+Suffix);
+  LeftRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left_center'+Suffix);
+  LeftRefRightSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_left_right'+Suffix);
+  RightRefLeftSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_right_left'+Suffix);
+  RightRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_right_center'+Suffix);
+  RightRefRightSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_right_right'+Suffix);
+  TopRefTopSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top_top'+Suffix);
+  TopRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top_center'+Suffix);
+  TopRefBottomSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_top_bottom'+Suffix);
+  BottomRefTopSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_bottom_top'+Suffix);
+  BottomRefCenterSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_bottom_center'+Suffix);
+  BottomRefBottomSpeedButton.LoadGlyphFromResourceName(HInstance, 'anchor_bottom_bottom'+Suffix);
 end;
 
 procedure TAnchorDesigner.CreateSideControls;
Index: images/copyright.txt
===================================================================
--- images/copyright.txt	(revision 54762)
+++ images/copyright.txt	(working copy)
@@ -11,6 +11,45 @@
 
 Following images were created by FTurtle:
 
+designer directory:
+
+anchor_bottom_bottom.png
+anchor_bottom_bottom_150.png
+anchor_bottom_bottom_200.png
+anchor_bottom_center.png
+anchor_bottom_center_150.png
+anchor_bottom_center_200.png
+anchor_bottom_top.png
+anchor_bottom_top_150.png
+anchor_bottom_top_200.png
+anchor_left_center.png
+anchor_left_center_150.png
+anchor_left_center_200.png
+anchor_left_left.png
+anchor_left_left_150.png
+anchor_left_left_200.png
+anchor_left_right.png
+anchor_left_right_150.png
+anchor_left_right_200.png
+anchor_right_center.png
+anchor_right_center_150.png
+anchor_right_center_200.png
+anchor_right_left.png
+anchor_right_left_150.png
+anchor_right_left_200.png
+anchor_right_right.png
+anchor_right_right_150.png
+anchor_right_right_200.png
+anchor_top_bottom.png
+anchor_top_bottom_150.png
+anchor_top_bottom_200.png
+anchor_top_center.png
+anchor_top_center_150.png
+anchor_top_center_200.png
+anchor_top_top.png
+anchor_top_top_150.png
+anchor_top_top_200.png
+
 menu directory:
 
 menu_clear_all_bookmarks.png
Index: images/laz_images_list.txt
===================================================================
--- images/laz_images_list.txt	(revision 54762)
+++ images/laz_images_list.txt	(working copy)
@@ -218,14 +218,42 @@
 designer/add_sep_below.png
 designer/add_submenu_right.png
 designer/add_submenu_below.png
-designer/anchor_bottom.png
-designer/anchor_center_horizontal.png
-designer/anchor_center_vertical.png
-designer/anchor_left.png
+designer/anchor_bottom_bottom.png
+designer/anchor_bottom_bottom_150.png
+designer/anchor_bottom_bottom_200.png
+designer/anchor_bottom_center.png
+designer/anchor_bottom_center_150.png
+designer/anchor_bottom_center_200.png
+designer/anchor_bottom_top.png
+designer/anchor_bottom_top_150.png
+designer/anchor_bottom_top_200.png
+designer/anchor_left_center.png
+designer/anchor_left_center_150.png
+designer/anchor_left_center_200.png
+designer/anchor_left_left.png
+designer/anchor_left_left_150.png
+designer/anchor_left_left_200.png
 designer/anchor_left_right.png
-designer/anchor_right.png
-designer/anchor_top.png
+designer/anchor_left_right_150.png
+designer/anchor_left_right_200.png
+designer/anchor_right_center.png
+designer/anchor_right_center_150.png
+designer/anchor_right_center_200.png
+designer/anchor_right_left.png
+designer/anchor_right_left_150.png
+designer/anchor_right_left_200.png
+designer/anchor_right_right.png
+designer/anchor_right_right_150.png
+designer/anchor_right_right_200.png
 designer/anchor_top_bottom.png
+designer/anchor_top_bottom_150.png
+designer/anchor_top_bottom_200.png
+designer/anchor_top_center.png
+designer/anchor_top_center_150.png
+designer/anchor_top_center_200.png
+designer/anchor_top_top.png
+designer/anchor_top_top_150.png
+designer/anchor_top_top_200.png
 designer/align.png
 designer/mirror_horizontal.png
 designer/mirror_vertical.png
patch2.diff (5,840 bytes)   

FTurtle

2017-04-28 23:55

reporter   ~0099991

I added scaling of glyphs in Anchor Editor:

patch2.diff

Ondrej Pokorny

2017-05-02 18:39

developer   ~0100063

applied, thanks :) will be merged to 1.8

FTurtle

2017-05-02 20:16

reporter   ~0100067

Thank you.

Issue History

Date Modified Username Field Change
2017-04-28 19:55 FTurtle New Issue
2017-04-28 19:55 FTurtle File Added: images.zip
2017-04-28 19:56 FTurtle File Added: patch.diff
2017-04-28 23:53 Ondrej Pokorny Assigned To => Ondrej Pokorny
2017-04-28 23:53 Ondrej Pokorny Status new => assigned
2017-04-28 23:54 FTurtle File Added: patch2.diff
2017-04-28 23:55 FTurtle Note Added: 0099991
2017-05-02 18:39 Ondrej Pokorny Fixed in Revision => 54799
2017-05-02 18:39 Ondrej Pokorny LazTarget => -
2017-05-02 18:39 Ondrej Pokorny Note Added: 0100063
2017-05-02 18:39 Ondrej Pokorny Status assigned => resolved
2017-05-02 18:39 Ondrej Pokorny Resolution open => fixed
2017-05-02 20:16 FTurtle Note Added: 0100067
2017-05-02 20:16 FTurtle Status resolved => closed