|
|
toolbar-cf.png (49,416 bytes) |
|
|
The last empty item should not be available for deletion. In Windows I could not reproduce it. Could you tell steps for reliable reproduction of its deletion? Perhaps this referred with using of filter. |
|
|
- dialog ToolbarConfig appears - in left filter edit type "run" - select "run w/o debug" - press "arrow right" - delete empty item |
|
|
About b): last item was introduced for make possible insert new item after last. Any operation with it are prohibited. It may be only selected for marking place for inserting new item. Which revision do you use? On 55036 I cant delete last item with you instructions (button is disabled). |
|
|
I use r55040. |
|
|
I can reproduce it with Linux + GTK2. When nothing is selected in the right side list then a new item is added to the very end, after the empty space. The events are somehow different. With other widgetsets the last empty item is selected automatically. With QT the lightning image shows also at the last empty item which is another bug. FTurtle, if you want to fix and improve it, I have another suggestion: Delete-key should work the same as the left arrow works now. For a separator the arrow is not logical. A separator is not really moved anywhere. For other items the delete-key is also intuitive because the items are deleted from that list. |
|
|
OK, I will see with other widgetsets. |
|
|
Why is the control TListView instead of TListBox? I have no idea. TListView is a problematic control. Already now the config dialog code has widgetset specific workarounds which is not good. I think it should be changed to TListBox. TToolBarConfig.lvToolbarDrawItem is called only with QT. I don't know why. I fixed the image issue with QT in r55042. The original issue reported by AlexeyT still remains. |
|
|
Fixed, please test. |
|
|
The main cause of the bug is that in some widgetsets setting of lvToolbar.ItemIndex ignores if form is not visible. So, the solution is something like: procedure TToolBarConfig.FormShow(Sender: TObject); begin lvToolbar.ItemIndex:=lvToolbar.Items.Count-1; end; Or: procedure TToolBarConfig.FormShow(Sender: TObject); begin lvToolbar.Selected := lvToolbar.Items[lvToolbar.Items.Count-1]; end; I dont see FormShow in your solution. I will can test something only at Sunday (maybe at Saturday) so I cant say more about your solution right now, but in any case I think that line in wiki should be moved to "Submitted by developer / committer and waiting for testing (do not commit yet)" |
- Anonymous
