View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0032350 | Patches | IDE | public | 2017-08-28 10:37 | 2017-08-28 14:34 |
| Reporter | ptvs | Assigned To | Juha Manninen | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Intel Core i3-7100 | OS | Microsoft Windows 7 SP1 x86 | ||
| Summary | 0032350: Unable to switch windows other than designed forms from "Window" menu | ||||
| Description | Unable to switch windows other than designed forms from "Window" menu, when option "Window menu shows designed form's name instead of caption" is enabled. Patch for revision 55662. | ||||
| Tags | No tags attached. | ||||
| Fixed in Revision | r55754 | ||||
| LazTarget | - | ||||
| Widgetset | |||||
| Attached Files |
| ||||
|
|
ide_mainbase.diff (1,331 bytes)
Index: ide/mainbase.pas
===================================================================
--- ide/mainbase.pas (revision 55662)
+++ ide/mainbase.pas (working copy)
@@ -630,8 +630,8 @@
while (i>=0) do begin
Form:=Screen.CustomForms[i];
nfd := EnvironmentOptions.Desktop.IDENameForDesignedFormList;
- if (nfd and (Form.Name=(Sender as TIDEMenuCommand).Caption))
- or ((not nfd) and (Form.Caption=(Sender as TIDEMenuCommand).Caption)) then
+ if (nfd and IsFormDesign(Form) and (Form.Name=(Sender as TIDEMenuCommand).Caption))
+ or (((not nfd) or (nfd and (not IsFormDesign(Form)))) and (Form.Caption=(Sender as TIDEMenuCommand).Caption)) then
begin
IDEWindowCreators.ShowForm(Form,true);
break;
@@ -651,8 +651,8 @@
while (i>=0) do begin
Form:=Screen.CustomForms[i];
nfd := EnvironmentOptions.Desktop.IDENameForDesignedFormList;
- if (nfd and (Form.Name=(Sender as TIDEMenuCommand).Caption))
- or ((not nfd) and (Form.Caption=(Sender as TIDEMenuCommand).Caption)) then
+ if (nfd and IsFormDesign(Form) and (Form.Name=(Sender as TIDEMenuCommand).Caption))
+ or (((not nfd) or (nfd and (not IsFormDesign(Form)))) and (Form.Caption=(Sender as TIDEMenuCommand).Caption)) then
begin
// show
if not Form.IsVisible then
|
|
|
Thanks. I modied your patch to simplify the logic and reduce duplicated code. Please test. |
|
|
Works fine |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-08-28 10:37 | ptvs | New Issue | |
| 2017-08-28 10:37 | ptvs | File Added: ide_mainbase.diff | |
| 2017-08-28 11:48 | Juha Manninen | Assigned To | => Juha Manninen |
| 2017-08-28 11:48 | Juha Manninen | Status | new => assigned |
| 2017-08-28 12:33 | Juha Manninen | Fixed in Revision | => r55754 |
| 2017-08-28 12:33 | Juha Manninen | LazTarget | => - |
| 2017-08-28 12:33 | Juha Manninen | Note Added: 0102462 | |
| 2017-08-28 12:33 | Juha Manninen | Status | assigned => resolved |
| 2017-08-28 12:33 | Juha Manninen | Resolution | open => fixed |
| 2017-08-28 14:34 | ptvs | Note Added: 0102467 |
