View Issue Details

IDProjectCategoryView StatusLast Update
0032399FPCPatchpublic2017-09-11 15:08
ReporterPascal RiekenbergAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformi386OSWindows 10 x64OS Version1703
Product Version3.1.1Product Build 
Target Version3.2.0Fixed in Version3.1.1 
Summary0032399: TCSVDataPacketReader.LoadFieldDefs: fParser is not initialized with FOptions
DescriptionTCSVDataPacketReader.LoadFieldDefs: fParser is not initialized with FOptions
so it will not work properly if for example delimiter is set to ;
Steps To ReproduceUse fpreport ReportDesigner and add a CSV-Dataset with ; as delimiter.
Additional InformationAttached patch fixes this.
TagsNo tags attached.
Fixed in Revision37176
FPCOldBugId
FPCTarget
Attached Files
  • csvdataset.pp.patch (391 bytes)
    Index: packages/fcl-db/src/base/csvdataset.pp
    ===================================================================
    --- packages/fcl-db/src/base/csvdataset.pp	(revision 37175)
    +++ packages/fcl-db/src/base/csvdataset.pp	(working copy)
    @@ -183,6 +183,7 @@
     
     begin
       FParser:=TCSVParser.Create;
    +  FParser.Assign(FOptions);
       FParser.SetSource(Stream);
       FCurrentRow:=0;
       ReadNextRow;
    
    csvdataset.pp.patch (391 bytes)

Activities

Pascal Riekenberg

2017-09-11 14:47

reporter  

csvdataset.pp.patch (391 bytes)
Index: packages/fcl-db/src/base/csvdataset.pp
===================================================================
--- packages/fcl-db/src/base/csvdataset.pp	(revision 37175)
+++ packages/fcl-db/src/base/csvdataset.pp	(working copy)
@@ -183,6 +183,7 @@
 
 begin
   FParser:=TCSVParser.Create;
+  FParser.Assign(FOptions);
   FParser.SetSource(Stream);
   FCurrentRow:=0;
   ReadNextRow;
csvdataset.pp.patch (391 bytes)

Michael Van Canneyt

2017-09-11 14:58

administrator   ~0102778

Applied, thank you very much!

Pascal Riekenberg

2017-09-11 15:08

reporter   ~0102779

yw!

Issue History

Date Modified Username Field Change
2017-09-11 14:47 Pascal Riekenberg New Issue
2017-09-11 14:47 Pascal Riekenberg File Added: csvdataset.pp.patch
2017-09-11 14:56 Michael Van Canneyt Assigned To => Michael Van Canneyt
2017-09-11 14:56 Michael Van Canneyt Status new => assigned
2017-09-11 14:58 Michael Van Canneyt Fixed in Revision => 37176
2017-09-11 14:58 Michael Van Canneyt Note Added: 0102778
2017-09-11 14:58 Michael Van Canneyt Status assigned => resolved
2017-09-11 14:58 Michael Van Canneyt Fixed in Version => 3.1.1
2017-09-11 14:58 Michael Van Canneyt Resolution open => fixed
2017-09-11 14:58 Michael Van Canneyt Target Version => 3.2.0
2017-09-11 15:08 Pascal Riekenberg Note Added: 0102779
2017-09-11 15:08 Pascal Riekenberg Status resolved => closed