View Issue Details

IDProjectCategoryView StatusLast Update
0032409FPCFCLpublic2017-09-12 22:11
ReporterAndrey ZubarevAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionProduct Build 
Target Version3.2.0Fixed in Version3.1.1 
Summary0032409: [fcl-web] fphttpclient.EncodeURLElement uninicialized result value
Descriptionempty parameter S gives uninicialized result
TagsNo tags attached.
Fixed in Revision37196
FPCOldBugId
FPCTarget
Attached Files
  • fphttpclient.pp.patch (384 bytes)
    Index: packages/fcl-web/src/base/fphttpclient.pp
    ===================================================================
    --- packages/fcl-web/src/base/fphttpclient.pp	(revision 37156)
    +++ packages/fcl-web/src/base/fphttpclient.pp	(working copy)
    @@ -383,6 +383,7 @@
       P : PChar;
       c: AnsiChar;
     begin
    +  result:='';
       l:=Length(S);
       If (l=0) then Exit;
       SetLength(Result,l*3);
    
    fphttpclient.pp.patch (384 bytes)

Activities

Andrey Zubarev

2017-09-12 21:19

reporter  

fphttpclient.pp.patch (384 bytes)
Index: packages/fcl-web/src/base/fphttpclient.pp
===================================================================
--- packages/fcl-web/src/base/fphttpclient.pp	(revision 37156)
+++ packages/fcl-web/src/base/fphttpclient.pp	(working copy)
@@ -383,6 +383,7 @@
   P : PChar;
   c: AnsiChar;
 begin
+  result:='';
   l:=Length(S);
   If (l=0) then Exit;
   SetLength(Result,l*3);
fphttpclient.pp.patch (384 bytes)

Michael Van Canneyt

2017-09-12 22:05

administrator   ~0102814

Applied, thanks for the patch!

Andrey Zubarev

2017-09-12 22:11

reporter   ~0102815

Thanks!

Issue History

Date Modified Username Field Change
2017-09-12 21:19 Andrey Zubarev New Issue
2017-09-12 21:19 Andrey Zubarev File Added: fphttpclient.pp.patch
2017-09-12 22:03 Michael Van Canneyt Assigned To => Michael Van Canneyt
2017-09-12 22:03 Michael Van Canneyt Status new => assigned
2017-09-12 22:05 Michael Van Canneyt Fixed in Revision => 37196
2017-09-12 22:05 Michael Van Canneyt Note Added: 0102814
2017-09-12 22:05 Michael Van Canneyt Status assigned => resolved
2017-09-12 22:05 Michael Van Canneyt Fixed in Version => 3.1.1
2017-09-12 22:05 Michael Van Canneyt Resolution open => fixed
2017-09-12 22:05 Michael Van Canneyt Target Version => 3.2.0
2017-09-12 22:11 Andrey Zubarev Note Added: 0102815
2017-09-12 22:11 Andrey Zubarev Status resolved => closed