View Issue Details

IDProjectCategoryView StatusLast Update
0032431LazarusPatchpublic2017-09-17 22:39
ReporterFTurtleAssigned ToMichl 
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version1.9 (SVN)Product Build55866 
Target Version1.8Fixed in Version1.9 (SVN) 
Summary0032431: High-DPI icons
DescriptionHigh-DPI icons.

File menu/menu_project_viewsource.png is no longer used and may be deleted.
TagsNo tags attached.
Fixed in Revision55878
LazTarget-
Widgetset
Attached Files
  • images.zip (25,187 bytes)
  • patch.diff (7,157 bytes)
    Index: ide/mainbase.pas
    ===================================================================
    --- ide/mainbase.pas	(revision 55866)
    +++ ide/mainbase.pas	(working copy)
    @@ -1294,7 +1294,7 @@
         CreateMenuItem(ParentMI,itmProjectRemoveFrom,'itmProjectRemoveFrom',lisMenuRemoveFromProject, 'menu_project_remove');
         CreateMenuItem(ParentMI,itmProjectViewUnits,'itmProjectViewUnits',lisMenuViewUnits, 'menu_view_units');
         CreateMenuItem(ParentMI,itmProjectViewForms,'itmProjectViewForms',lisMenuViewForms, 'menu_view_forms');
    -    CreateMenuItem(ParentMI,itmProjectViewSource,'itmProjectViewSource',lisMenuViewProjectSource, 'menu_project_viewsource');
    +    CreateMenuItem(ParentMI,itmProjectViewSource,'itmProjectViewSource',lisMenuViewProjectSource, 'item_project_source');
       end;
     end;
     
    @@ -1431,7 +1431,7 @@
       with MainIDEBar do begin
         CreateMenuSeparatorSection(mnuWindow,itmWindowManagers,'itmWindowManagers');
         ParentMI:=itmWindowManagers;
    -    CreateMenuItem(ParentMI,itmWindowManager,'itmWindowManager', lisManageSourceEditors, 'pkg_files');
    +    CreateMenuItem(ParentMI,itmWindowManager,'itmWindowManager', lisManageSourceEditors, 'menu_manage_source_editors');
         // Populated later with a list of editor names
         CreateMenuSeparatorSection(mnuWindow,itmWindowLists,'itmWindowLists');
         CreateMenuSeparatorSection(mnuWindow,itmCenterWindowLists,'itmCenterWindowLists');
    Index: ide/projectinspector.pas
    ===================================================================
    --- ide/projectinspector.pas	(revision 55866)
    +++ ide/projectinspector.pas	(working copy)
    @@ -1017,7 +1017,7 @@
       ImageIndexRequired        := IDEImages.LoadImage('pkg_required');
       ImageIndexConflict        := IDEImages.LoadImage('pkg_conflict');
       ImageIndexRemovedRequired := IDEImages.LoadImage('pkg_removedrequired');
    -  ImageIndexProject         := IDEImages.LoadImage('item_project');
    +  ImageIndexProject         := IDEImages.LoadImage('item_project_source');
       ImageIndexUnit            := IDEImages.LoadImage('item_unit');
       ImageIndexRegisterUnit    := IDEImages.LoadImage('pkg_registerunit');
       ImageIndexText            := IDEImages.LoadImage('pkg_text');
    Index: ide/searchresultview.pp
    ===================================================================
    --- ide/searchresultview.pp	(revision 55866)
    +++ ide/searchresultview.pp	(working copy)
    @@ -314,7 +314,7 @@
       mniCollapseAll.Caption := lisCollapseAll;
     
       ToolBar.Images := IDEImages.Images_16;
    -  SearchAgainButton.ImageIndex := IDEImages.LoadImage('menu_search_find');
    +  SearchAgainButton.ImageIndex := IDEImages.LoadImage('menu_new_search');
       ClosePageButton.ImageIndex := IDEImages.LoadImage('menu_close');
       ActionList.Images := IDEImages.Images_16;
       actClosePage.ImageIndex := IDEImages.LoadImage('menu_close');
    Index: images/copyright.txt
    ===================================================================
    --- images/copyright.txt	(revision 55866)
    +++ images/copyright.txt	(working copy)
    @@ -88,6 +88,9 @@
     item_form.png
     item_form_150.png
     item_form_200.png
    +item_project_source.png
    +item_project_source_150.png
    +item_project_source_200.png
     item_unit.png
     item_unit_150.png
     item_unit_200.png
    @@ -160,18 +163,39 @@
     menu_jumpto_interfaceuses_200.png
     menu_jumpto_interface_150.png
     menu_jumpto_interface_200.png
    +menu_manage_source_editors.png
    +menu_manage_source_editors_150.png
    +menu_manage_source_editors_200.png
     menu_new.png
     menu_new_150.png
     menu_new_200.png
     menu_new_form.png
     menu_new_form_150.png
     menu_new_form_200.png
    +menu_new_search.png
    +menu_new_search_150.png
    +menu_new_search_200.png
     menu_new_unit.png
     menu_new_unit_150.png
     menu_new_unit_200.png
    +menu_pause.png
    +menu_pause_150.png
    +menu_pause_200.png
     menu_redo.png
     menu_redo_150.png
     menu_redo_200.png
    +menu_run.png
    +menu_run_150.png
    +menu_run_200.png
    +menu_run_cursor.png
    +menu_run_cursor_150.png
    +menu_run_cursor_200.png
    +menu_run_parameters.png
    +menu_run_parameters_150.png
    +menu_run_parameters_200.png
    +menu_run_withoutdebugging.png
    +menu_run_withoutdebugging_150.png
    +menu_run_withoutdebugging_200.png
     menu_saveas.png
     menu_saveas_150.png
     menu_saveas_200.png
    @@ -221,6 +245,9 @@
     menu_stepover.png
     menu_stepover_150.png
     menu_stepover_200.png
    +menu_stop.png
    +menu_stop_150.png
    +menu_stop_200.png
     menu_toggle_bookmark0.png
     menu_toggle_bookmark0_150.png
     menu_toggle_bookmark0_200.png
    @@ -272,6 +299,9 @@
     menu_view_search_results.png
     menu_view_search_results_150.png
     menu_view_search_results_200.png
    +menu_view_source_editor.png
    +menu_view_source_editor_150.png
    +menu_view_source_editor_200.png
     menu_view_units.png
     menu_view_units_150.png
     menu_view_units_200.png
    Index: images/laz_images_list.txt
    ===================================================================
    --- images/laz_images_list.txt	(revision 55866)
    +++ images/laz_images_list.txt	(working copy)
    @@ -217,6 +217,9 @@
     items/item_library.png
     items/item_package.png
     items/item_project.png
    +items/item_project_source.png
    +items/item_project_source_150.png
    +items/item_project_source_200.png
     items/item_todo.png
     items/item_unit.png
     items/item_unit_150.png
    @@ -313,16 +316,24 @@
     menu/menu_jumpto_procedurebegin.png
     menu/menu_jumpto_procedureheader.png
     menu/menu_manage_desktops.png
    +menu/menu_manage_source_editors.png
    +menu/menu_manage_source_editors_150.png
    +menu/menu_manage_source_editors_200.png
     menu/menu_new.png
     menu/menu_new_150.png
     menu/menu_new_200.png
     menu/menu_new_form.png
     menu/menu_new_form_150.png
     menu/menu_new_form_200.png
    +menu/menu_new_search.png
    +menu/menu_new_search_150.png
    +menu/menu_new_search_200.png
     menu/menu_new_unit.png
     menu/menu_new_unit_150.png
     menu/menu_new_unit_200.png
     menu/menu_pause.png
    +menu/menu_pause_150.png
    +menu/menu_pause_200.png
     menu/menu_project_add.png
     menu/menu_project_close.png
     menu/menu_project_from_file.png
    @@ -332,7 +343,6 @@
     menu/menu_project_remove.png
     menu/menu_project_save.png
     menu/menu_project_saveas.png
    -menu/menu_project_viewsource.png
     menu/menu_quick_compile.png
     menu/menu_redo.png
     menu/menu_redo_150.png
    @@ -340,10 +350,18 @@
     menu/menu_reportingbug.png
     menu/menu_reset_debugger.png
     menu/menu_run.png
    +menu/menu_run_150.png
    +menu/menu_run_200.png
     menu/menu_run_cursor.png
    +menu/menu_run_cursor_150.png
    +menu/menu_run_cursor_200.png
     menu/menu_run_file.png
     menu/menu_run_parameters.png
    +menu/menu_run_parameters_150.png
    +menu/menu_run_parameters_200.png
     menu/menu_run_withoutdebugging.png
    +menu/menu_run_withoutdebugging_150.png
    +menu/menu_run_withoutdebugging_200.png
     menu/menu_saveas.png
     menu/menu_saveas_150.png
     menu/menu_saveas_200.png
    @@ -398,6 +416,8 @@
     menu/menu_stepover_200.png
     menu/menu_stepover_instr.png
     menu/menu_stop.png
    +menu/menu_stop_150.png
    +menu/menu_stop_200.png
     menu/menu_toggle_bookmark0.png
     menu/menu_toggle_bookmark0_150.png
     menu/menu_toggle_bookmark0_200.png
    @@ -460,6 +480,8 @@
     menu/menu_view_search_results_150.png
     menu/menu_view_search_results_200.png
     menu/menu_view_source_editor.png
    +menu/menu_view_source_editor_150.png
    +menu/menu_view_source_editor_200.png
     menu/menu_view_todo.png
     menu/menu_view_toggle_form_unit.png
     menu/menu_view_units.png
    
    patch.diff (7,157 bytes)
  • red_version.zip (1,808 bytes)

Activities

FTurtle

2017-09-17 12:17

reporter  

images.zip (25,187 bytes)

FTurtle

2017-09-17 12:17

reporter  

patch.diff (7,157 bytes)
Index: ide/mainbase.pas
===================================================================
--- ide/mainbase.pas	(revision 55866)
+++ ide/mainbase.pas	(working copy)
@@ -1294,7 +1294,7 @@
     CreateMenuItem(ParentMI,itmProjectRemoveFrom,'itmProjectRemoveFrom',lisMenuRemoveFromProject, 'menu_project_remove');
     CreateMenuItem(ParentMI,itmProjectViewUnits,'itmProjectViewUnits',lisMenuViewUnits, 'menu_view_units');
     CreateMenuItem(ParentMI,itmProjectViewForms,'itmProjectViewForms',lisMenuViewForms, 'menu_view_forms');
-    CreateMenuItem(ParentMI,itmProjectViewSource,'itmProjectViewSource',lisMenuViewProjectSource, 'menu_project_viewsource');
+    CreateMenuItem(ParentMI,itmProjectViewSource,'itmProjectViewSource',lisMenuViewProjectSource, 'item_project_source');
   end;
 end;
 
@@ -1431,7 +1431,7 @@
   with MainIDEBar do begin
     CreateMenuSeparatorSection(mnuWindow,itmWindowManagers,'itmWindowManagers');
     ParentMI:=itmWindowManagers;
-    CreateMenuItem(ParentMI,itmWindowManager,'itmWindowManager', lisManageSourceEditors, 'pkg_files');
+    CreateMenuItem(ParentMI,itmWindowManager,'itmWindowManager', lisManageSourceEditors, 'menu_manage_source_editors');
     // Populated later with a list of editor names
     CreateMenuSeparatorSection(mnuWindow,itmWindowLists,'itmWindowLists');
     CreateMenuSeparatorSection(mnuWindow,itmCenterWindowLists,'itmCenterWindowLists');
Index: ide/projectinspector.pas
===================================================================
--- ide/projectinspector.pas	(revision 55866)
+++ ide/projectinspector.pas	(working copy)
@@ -1017,7 +1017,7 @@
   ImageIndexRequired        := IDEImages.LoadImage('pkg_required');
   ImageIndexConflict        := IDEImages.LoadImage('pkg_conflict');
   ImageIndexRemovedRequired := IDEImages.LoadImage('pkg_removedrequired');
-  ImageIndexProject         := IDEImages.LoadImage('item_project');
+  ImageIndexProject         := IDEImages.LoadImage('item_project_source');
   ImageIndexUnit            := IDEImages.LoadImage('item_unit');
   ImageIndexRegisterUnit    := IDEImages.LoadImage('pkg_registerunit');
   ImageIndexText            := IDEImages.LoadImage('pkg_text');
Index: ide/searchresultview.pp
===================================================================
--- ide/searchresultview.pp	(revision 55866)
+++ ide/searchresultview.pp	(working copy)
@@ -314,7 +314,7 @@
   mniCollapseAll.Caption := lisCollapseAll;
 
   ToolBar.Images := IDEImages.Images_16;
-  SearchAgainButton.ImageIndex := IDEImages.LoadImage('menu_search_find');
+  SearchAgainButton.ImageIndex := IDEImages.LoadImage('menu_new_search');
   ClosePageButton.ImageIndex := IDEImages.LoadImage('menu_close');
   ActionList.Images := IDEImages.Images_16;
   actClosePage.ImageIndex := IDEImages.LoadImage('menu_close');
Index: images/copyright.txt
===================================================================
--- images/copyright.txt	(revision 55866)
+++ images/copyright.txt	(working copy)
@@ -88,6 +88,9 @@
 item_form.png
 item_form_150.png
 item_form_200.png
+item_project_source.png
+item_project_source_150.png
+item_project_source_200.png
 item_unit.png
 item_unit_150.png
 item_unit_200.png
@@ -160,18 +163,39 @@
 menu_jumpto_interfaceuses_200.png
 menu_jumpto_interface_150.png
 menu_jumpto_interface_200.png
+menu_manage_source_editors.png
+menu_manage_source_editors_150.png
+menu_manage_source_editors_200.png
 menu_new.png
 menu_new_150.png
 menu_new_200.png
 menu_new_form.png
 menu_new_form_150.png
 menu_new_form_200.png
+menu_new_search.png
+menu_new_search_150.png
+menu_new_search_200.png
 menu_new_unit.png
 menu_new_unit_150.png
 menu_new_unit_200.png
+menu_pause.png
+menu_pause_150.png
+menu_pause_200.png
 menu_redo.png
 menu_redo_150.png
 menu_redo_200.png
+menu_run.png
+menu_run_150.png
+menu_run_200.png
+menu_run_cursor.png
+menu_run_cursor_150.png
+menu_run_cursor_200.png
+menu_run_parameters.png
+menu_run_parameters_150.png
+menu_run_parameters_200.png
+menu_run_withoutdebugging.png
+menu_run_withoutdebugging_150.png
+menu_run_withoutdebugging_200.png
 menu_saveas.png
 menu_saveas_150.png
 menu_saveas_200.png
@@ -221,6 +245,9 @@
 menu_stepover.png
 menu_stepover_150.png
 menu_stepover_200.png
+menu_stop.png
+menu_stop_150.png
+menu_stop_200.png
 menu_toggle_bookmark0.png
 menu_toggle_bookmark0_150.png
 menu_toggle_bookmark0_200.png
@@ -272,6 +299,9 @@
 menu_view_search_results.png
 menu_view_search_results_150.png
 menu_view_search_results_200.png
+menu_view_source_editor.png
+menu_view_source_editor_150.png
+menu_view_source_editor_200.png
 menu_view_units.png
 menu_view_units_150.png
 menu_view_units_200.png
Index: images/laz_images_list.txt
===================================================================
--- images/laz_images_list.txt	(revision 55866)
+++ images/laz_images_list.txt	(working copy)
@@ -217,6 +217,9 @@
 items/item_library.png
 items/item_package.png
 items/item_project.png
+items/item_project_source.png
+items/item_project_source_150.png
+items/item_project_source_200.png
 items/item_todo.png
 items/item_unit.png
 items/item_unit_150.png
@@ -313,16 +316,24 @@
 menu/menu_jumpto_procedurebegin.png
 menu/menu_jumpto_procedureheader.png
 menu/menu_manage_desktops.png
+menu/menu_manage_source_editors.png
+menu/menu_manage_source_editors_150.png
+menu/menu_manage_source_editors_200.png
 menu/menu_new.png
 menu/menu_new_150.png
 menu/menu_new_200.png
 menu/menu_new_form.png
 menu/menu_new_form_150.png
 menu/menu_new_form_200.png
+menu/menu_new_search.png
+menu/menu_new_search_150.png
+menu/menu_new_search_200.png
 menu/menu_new_unit.png
 menu/menu_new_unit_150.png
 menu/menu_new_unit_200.png
 menu/menu_pause.png
+menu/menu_pause_150.png
+menu/menu_pause_200.png
 menu/menu_project_add.png
 menu/menu_project_close.png
 menu/menu_project_from_file.png
@@ -332,7 +343,6 @@
 menu/menu_project_remove.png
 menu/menu_project_save.png
 menu/menu_project_saveas.png
-menu/menu_project_viewsource.png
 menu/menu_quick_compile.png
 menu/menu_redo.png
 menu/menu_redo_150.png
@@ -340,10 +350,18 @@
 menu/menu_reportingbug.png
 menu/menu_reset_debugger.png
 menu/menu_run.png
+menu/menu_run_150.png
+menu/menu_run_200.png
 menu/menu_run_cursor.png
+menu/menu_run_cursor_150.png
+menu/menu_run_cursor_200.png
 menu/menu_run_file.png
 menu/menu_run_parameters.png
+menu/menu_run_parameters_150.png
+menu/menu_run_parameters_200.png
 menu/menu_run_withoutdebugging.png
+menu/menu_run_withoutdebugging_150.png
+menu/menu_run_withoutdebugging_200.png
 menu/menu_saveas.png
 menu/menu_saveas_150.png
 menu/menu_saveas_200.png
@@ -398,6 +416,8 @@
 menu/menu_stepover_200.png
 menu/menu_stepover_instr.png
 menu/menu_stop.png
+menu/menu_stop_150.png
+menu/menu_stop_200.png
 menu/menu_toggle_bookmark0.png
 menu/menu_toggle_bookmark0_150.png
 menu/menu_toggle_bookmark0_200.png
@@ -460,6 +480,8 @@
 menu/menu_view_search_results_150.png
 menu/menu_view_search_results_200.png
 menu/menu_view_source_editor.png
+menu/menu_view_source_editor_150.png
+menu/menu_view_source_editor_200.png
 menu/menu_view_todo.png
 menu/menu_view_toggle_form_unit.png
 menu/menu_view_units.png
patch.diff (7,157 bytes)

Michl

2017-09-17 14:54

developer   ~0102889

I checked the images. I like the most. Thank you for that! Just the image menu_stop.png (and its scaled siblings) should stay red, not green. I use this speedbutton very often. When it is green, I need to look at it twice, to click on the coorect one.

FTurtle

2017-09-17 18:13

reporter  

red_version.zip (1,808 bytes)

FTurtle

2017-09-17 18:14

reporter   ~0102891

Attached red version.

Michl

2017-09-17 21:04

developer   ~0102895

Applied. Thank you!

FTurtle

2017-09-17 22:39

reporter   ~0102897

Thank you.

Issue History

Date Modified Username Field Change
2017-09-17 12:17 FTurtle New Issue
2017-09-17 12:17 FTurtle File Added: images.zip
2017-09-17 12:17 FTurtle File Added: patch.diff
2017-09-17 14:27 Michl Assigned To => Michl
2017-09-17 14:27 Michl Status new => assigned
2017-09-17 14:54 Michl LazTarget => -
2017-09-17 14:54 Michl Note Added: 0102889
2017-09-17 14:54 Michl Status assigned => feedback
2017-09-17 18:13 FTurtle File Added: red_version.zip
2017-09-17 18:14 FTurtle Note Added: 0102891
2017-09-17 18:14 FTurtle Status feedback => assigned
2017-09-17 21:04 Michl Fixed in Revision => 55878
2017-09-17 21:04 Michl Note Added: 0102895
2017-09-17 21:04 Michl Status assigned => resolved
2017-09-17 21:04 Michl Fixed in Version => 1.9 (SVN)
2017-09-17 21:04 Michl Resolution open => fixed
2017-09-17 21:04 Michl Target Version => 1.8
2017-09-17 22:39 FTurtle Note Added: 0102897
2017-09-17 22:39 FTurtle Status resolved => closed