View Issue Details

IDProjectCategoryView StatusLast Update
0032442FPCPatchpublic2017-09-20 19:52
ReporterPascal RiekenbergAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformi386OSWindows 10 x64OS Version1703
Product Version3.1.1Product Build 
Target Version3.2.0Fixed in Version3.1.1 
Summary0032442: fcl-report: PageCount isn't working as return type was wrong
DescriptionSee attached patch.
TagsNo tags attached.
Fixed in Revision37272
FPCOldBugId
FPCTarget
Attached Files
  • fpreport.pp.patch (425 bytes)
    Index: packages/fcl-report/src/fpreport.pp
    ===================================================================
    --- packages/fcl-report/src/fpreport.pp	(revision 37254)
    +++ packages/fcl-report/src/fpreport.pp	(working copy)
    @@ -6582,7 +6582,7 @@
       if UsePageCountMarker then
         Result.ResString := cPageCountMarker
       else
    -    Result.ResString := IntToStr(FPageCount);
    +    Result.ResInteger := FPageCount;
     end;
     
     
    
    fpreport.pp.patch (425 bytes)

Activities

Pascal Riekenberg

2017-09-19 10:47

reporter  

fpreport.pp.patch (425 bytes)
Index: packages/fcl-report/src/fpreport.pp
===================================================================
--- packages/fcl-report/src/fpreport.pp	(revision 37254)
+++ packages/fcl-report/src/fpreport.pp	(working copy)
@@ -6582,7 +6582,7 @@
   if UsePageCountMarker then
     Result.ResString := cPageCountMarker
   else
-    Result.ResString := IntToStr(FPageCount);
+    Result.ResInteger := FPageCount;
 end;
 
 
fpreport.pp.patch (425 bytes)

Michael Van Canneyt

2017-09-20 17:11

administrator   ~0102951

I can't believe it!
I changed the implementation 3 times, still managed to commit a wrong version :/

Thanks for the fix!

Pascal Riekenberg

2017-09-20 19:52

reporter   ~0102953

:-)

Issue History

Date Modified Username Field Change
2017-09-19 10:47 Pascal Riekenberg New Issue
2017-09-19 10:47 Pascal Riekenberg File Added: fpreport.pp.patch
2017-09-20 17:11 Michael Van Canneyt Fixed in Revision => 37272
2017-09-20 17:11 Michael Van Canneyt Note Added: 0102951
2017-09-20 17:11 Michael Van Canneyt Status new => resolved
2017-09-20 17:11 Michael Van Canneyt Fixed in Version => 3.1.1
2017-09-20 17:11 Michael Van Canneyt Resolution open => fixed
2017-09-20 17:11 Michael Van Canneyt Assigned To => Michael Van Canneyt
2017-09-20 17:11 Michael Van Canneyt Target Version => 3.2.0
2017-09-20 19:52 Pascal Riekenberg Note Added: 0102953
2017-09-20 19:52 Pascal Riekenberg Status resolved => closed