View Issue Details

IDProjectCategoryView StatusLast Update
0032704LazarusPackagespublic2021-03-01 11:09
ReporterCudaText man Assigned Towp  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformwin10 
Product Version1.9 (SVN) 
Target Version2.2 
Summary0032704: OnlinePkgManager hi-dpi bug in messagebox
DescriptionThis messagebox has too tall buttons, on scale 150%. See above part of picture, it has OK size of combobox+button.
TagsNo tags attached.
Fixed in Revision
LazTarget2.2
Widgetset
Attached Files

Relationships

related to 0037985 assignedwp HighDPI: "Replace next" dialog is not scaled correctly 

Activities

CudaText man

2017-11-17 22:52

reporter  

opm-too-big-btn.png (34,815 bytes)   
opm-too-big-btn.png (34,815 bytes)   

Balázs Székely

2017-11-18 06:56

developer   ~0104168

@AlexeyT,

I can confirm this issue. OPM uses the CreateMessageDialog function from the dialogs unit, so it must be fixed there first. Can you please create a patch? I don't have commit rights there, but I'm sure somebody will apply it.

wp

2021-02-26 17:22

developer   ~0129174

Last edited: 2021-02-26 18:33

View 2 revisions

Looks as if the forms created by CreateMessageDlg are not correctly LCLscaled. In addition to the button size, the system icons (the "i" in CudaText man's screenshot), as well as the TBitBtn glyphs are too small.

Tested this with a 144ppi Win7 and Laz 2.1.

wp

2021-02-26 18:30

developer   ~0129176

Here is a small demo programm that CreateMessageDialog is not scaled correctly: the size of the form and width of the button are scaled correctly, but the height of the button is scaled twice, and the size of the images is not scaled at all (this happens, BTW, also with the buttons of a TButtonPanel)

wp

2021-02-26 23:30

developer   ~0129186

Fixed the button height issue in r64673

Balázs Székely

2021-02-28 20:22

developer   ~0129251

Thanks @wp. Can I close this issue?

wp

2021-02-28 21:24

developer   ~0129255

I wanted to keep it open to remind me that the icon is not scaled. But it's probably better to put this into a separate report.

Issue History

Date Modified Username Field Change
2017-11-17 22:52 CudaText man New Issue
2017-11-17 22:52 CudaText man File Added: opm-too-big-btn.png
2017-11-18 06:56 Balázs Székely LazTarget => -
2017-11-18 06:56 Balázs Székely Note Added: 0104168
2017-11-18 06:56 Balázs Székely Assigned To => Balázs Székely
2017-11-18 06:56 Balázs Székely Status new => assigned
2017-11-18 06:56 Balázs Székely Target Version => 1.9 (SVN)
2021-02-26 15:53 Martin Friebe Target Version 1.9 (SVN) => 2.2
2021-02-26 17:22 wp Note Added: 0129174
2021-02-26 18:30 wp Note Added: 0129176
2021-02-26 18:30 wp File Added: lclscaling_createmessagedialog.zip
2021-02-26 18:30 wp File Added: lclscaling_createmessagedialog_96ppi.png
2021-02-26 18:30 wp File Added: lclscaling_createmessagedialog144ppi.png
2021-02-26 18:33 wp Note Edited: 0129174 View Revisions
2021-02-26 23:30 wp Note Added: 0129186
2021-02-26 23:30 wp Assigned To Balázs Székely => wp
2021-02-28 20:22 Balázs Székely Note Added: 0129251
2021-02-28 21:24 wp Note Added: 0129255
2021-02-28 21:25 wp Status assigned => resolved
2021-02-28 21:25 wp Resolution open => fixed
2021-02-28 21:25 wp LazTarget - => 2.2
2021-03-01 11:09 wp Relationship added related to 0037985