View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0032975 | Lazarus | LCL | public | 2018-01-08 03:45 | 2018-09-10 22:34 |
| Reporter | fantangshan | Assigned To | Juha Manninen | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | x86_64 | OS | ubuntu 16.04 | ||
| Summary | 0032975: A patch for fixing OnChange of TFloatSpinEdit and TSpinEdit is triggered but nothing changed when TForm.Show with gtk2 | ||||
| Description | Honestly I don't realy understand why these changing can fix it. I suggest that it should be someone who is familar with gtk2 merging my modification and please completely test it. | ||||
| Steps To Reproduce | 1. Run the test program 2. You should not see the caption of the labels on the form changed. | ||||
| Tags | No tags attached. | ||||
| Fixed in Revision | |||||
| LazTarget | - | ||||
| Widgetset | GTK 2 | ||||
| Attached Files |
| ||||
| related to | 0032985 | closed | Juha Manninen | [patch] Fix TFloatSpinEdit behaviour (Gtk2) |
| related to | 0031618 | closed | Juha Manninen | TSpinEdit.OnChange events in GTk2 |
|
|
|
|
|
Why this still in state of new? Please merge it, this is really a bug, please first run the test program to see it. I want to keep updating with trunc, so please do it as soon as possible. Or tell me how can I commit ? I'm happy to do this. |
|
|
First learn howo create patch, then create patch and upload it here so we can review. http://wiki.freepascal.org/Creating_A_Patch |
|
|
Yes? I got a patch and I uploaded. Can anyone see it? |
|
|
|
|
|
No need to zip the patch, just attach it as is, makes it easier for us to review. |
|
|
Why don't merge the patch or fix this bug. |
|
|
GTK is not really my thing. Maybe Zeljan? |
|
|
The patch is invalid. Please provide a new one. Upload it directly without compressing as it is rather small. It is easier to download and view. Also, my browser allows to view a patch directly without downloading. Does the bug still exist? I see the Label captions change when I click things. You did not even fill the "Product Version" field. Is this about some old Lazarus version? You must always create patches against trunk and test with it. --- $ patch -p0 < ~/patch/gtk2 gtk2.patch gtk2proc.inc.patch [juha@JuhanKone lazarus_trunk]$ patch -p0 < ~/patch/gtk2.patch (Stripping trailing CRs from patch; use --binary to disable.) patching file lcl/interfaces/gtk2/gtk2callback.inc Hunk 0000001 FAILED at 537. 1 out of 1 hunk FAILED -- saving rejects to file lcl/interfaces/gtk2/gtk2callback.inc.rej (Stripping trailing CRs from patch; use --binary to disable.) patching file lcl/interfaces/gtk2/gtk2proc.pp Hunk 0000001 FAILED at 101. 1 out of 1 hunk FAILED -- saving rejects to file lcl/interfaces/gtk2/gtk2proc.pp.rej (Stripping trailing CRs from patch; use --binary to disable.) patching file lcl/interfaces/gtk2/gtk2widgetset.inc Hunk 0000001 FAILED at 437. 1 out of 1 hunk FAILED -- saving rejects to file lcl/interfaces/gtk2/gtk2widgetset.inc.rej |
|
|
It was a bug with the call to OnChange when Readonly is changed, fixed with 0032985. |
|
|
Ok, thanks for the info. Resolving. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-01-08 03:45 | fantangshan | New Issue | |
| 2018-01-08 03:45 | fantangshan | File Added: lazarus_truc.zip | |
| 2018-01-08 17:47 | Bart Broersma | Relationship added | related to 0031618 |
| 2018-01-21 10:40 | fantangshan | Note Added: 0105978 | |
| 2018-01-21 16:02 | Zeljan Rikalo | Note Added: 0105986 | |
| 2018-02-08 14:37 | fantangshan | Note Added: 0106286 | |
| 2018-02-08 14:38 | fantangshan | File Added: lazarus_truc_again.zip | |
| 2018-02-08 19:07 | Bart Broersma | Note Added: 0106292 | |
| 2018-02-28 15:37 | fantangshan | Note Added: 0106756 | |
| 2018-02-28 15:42 | Bart Broersma | Note Added: 0106758 | |
| 2018-09-09 10:56 | Juha Manninen | Assigned To | => Juha Manninen |
| 2018-09-09 10:56 | Juha Manninen | Status | new => assigned |
| 2018-09-09 10:59 | Juha Manninen | Note Added: 0110585 | |
| 2018-09-09 10:59 | Juha Manninen | LazTarget | => - |
| 2018-09-09 10:59 | Juha Manninen | Status | assigned => feedback |
| 2018-09-09 11:08 | Juha Manninen | Note Edited: 0110585 | View Revisions |
| 2018-09-09 11:12 | Juha Manninen | Note Edited: 0110585 | View Revisions |
| 2018-09-09 11:15 | Juha Manninen | Note Edited: 0110585 | View Revisions |
| 2018-09-10 21:35 | accorp | Note Added: 0110619 | |
| 2018-09-10 22:31 | Juha Manninen | Relationship added | related to 0032985 |
| 2018-09-10 22:34 | Juha Manninen | Note Added: 0110624 | |
| 2018-09-10 22:34 | Juha Manninen | Status | feedback => resolved |
| 2018-09-10 22:34 | Juha Manninen | Resolution | open => fixed |
