View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0033081 | FPC | Database | public | 2018-01-26 23:49 | 2018-09-23 17:12 |
Reporter | Michal Gawrycki | Assigned To | Michael Van Canneyt | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | Product Build | 37892 | |||
Target Version | 3.2.0 | Fixed in Version | 3.1.1 | ||
Summary | 0033081: TDataSet.ClearFields should check if dataset is in edit mode. | ||||
Description | Following the documentation, TDataSet.ClearFields should check if dataset is in edit mode and raise an exception if it is not. https://www.freepascal.org/docs-html/fcl/db/tdataset.clearfields.html | ||||
Tags | No tags attached. | ||||
Fixed in Revision | 38064 | ||||
FPCOldBugId | |||||
FPCTarget | |||||
Attached Files |
|
|
clearfields-dataset.inc.patch (430 bytes)
Index: packages/fcl-db/src/base/dataset.inc =================================================================== --- packages/fcl-db/src/base/dataset.inc (revision 37892) +++ packages/fcl-db/src/base/dataset.inc (working copy) @@ -1504,6 +1504,7 @@ begin + if not (State in dsEditModes) then DatabaseError(SNotEditing, Self); DataEvent(deCheckBrowseMode, 0); FreeFieldBuffers; InternalInitRecord(ActiveBuffer); |
|
Applied the patch, thank you! |
|
Closed. Thanks. |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-01-26 23:49 | Michal Gawrycki | New Issue | |
2018-01-26 23:49 | Michal Gawrycki | File Added: clearfields-dataset.inc.patch | |
2018-01-28 10:33 | Michael Van Canneyt | Assigned To | => Michael Van Canneyt |
2018-01-28 10:33 | Michael Van Canneyt | Status | new => assigned |
2018-01-28 11:00 | Michael Van Canneyt | Fixed in Revision | => 38064 |
2018-01-28 11:00 | Michael Van Canneyt | Note Added: 0106087 | |
2018-01-28 11:00 | Michael Van Canneyt | Status | assigned => resolved |
2018-01-28 11:00 | Michael Van Canneyt | Fixed in Version | => 3.1.1 |
2018-01-28 11:00 | Michael Van Canneyt | Resolution | open => fixed |
2018-01-28 11:00 | Michael Van Canneyt | Target Version | => 3.2.0 |
2018-09-23 17:12 | Michal Gawrycki | Note Added: 0110982 | |
2018-09-23 17:12 | Michal Gawrycki | Status | resolved => closed |