View Issue Details

IDProjectCategoryView StatusLast Update
0033449FPCDatabasepublic2018-03-17 22:24
ReporterwpAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product VersionProduct Build 
Target Version3.2.0Fixed in Version3.1.1 
Summary0033449: Declare FileName of TBufDataset as TFileName
DescriptionIn r57498/57521 the type TFileName has been registered to its own property editor for Lazarus. To take advantage of this for TBufDataset, it properte "FileName" must be type "TFileName", instead of "string".
TagsNo tags attached.
Fixed in Revision38553
FPCOldBugId
FPCTarget
Attached Files
  • bufdataset.pas.patch (1,085 bytes)
    Index: fcl-db/src/base/bufdataset.pas
    ===================================================================
    --- fcl-db/src/base/bufdataset.pas	(revision 38547)
    +++ fcl-db/src/base/bufdataset.pas	(working copy)
    @@ -495,7 +495,7 @@
         function GetCurrentIndexBuf: TBufIndex;
         procedure InitUserIndexes;
       private
    -    FFileName: string;
    +    FFileName: TFileName;
         FReadFromFile   : boolean;
         FFileStream     : TFileStream;
         FDatasetReader  : TDataPacketReader;
    @@ -654,7 +654,7 @@
         property ReadOnly : Boolean read FReadOnly write SetReadOnly default false;
         property ManualMergeChangeLog : Boolean read FManualMergeChangeLog write FManualMergeChangeLog default False;
       published
    -    property FileName : string read FFileName write FFileName;
    +    property FileName : TFileName read FFileName write FFileName;
         property PacketRecords : Integer read FPacketRecords write SetPacketRecords default 10;
         property OnUpdateError: TResolverErrorEvent read FOnUpdateError write SetOnUpdateError;
         property IndexDefs : TIndexDefs read GetIndexDefs;
    
    bufdataset.pas.patch (1,085 bytes)

Activities

wp

2018-03-17 16:57

reporter  

bufdataset.pas.patch (1,085 bytes)
Index: fcl-db/src/base/bufdataset.pas
===================================================================
--- fcl-db/src/base/bufdataset.pas	(revision 38547)
+++ fcl-db/src/base/bufdataset.pas	(working copy)
@@ -495,7 +495,7 @@
     function GetCurrentIndexBuf: TBufIndex;
     procedure InitUserIndexes;
   private
-    FFileName: string;
+    FFileName: TFileName;
     FReadFromFile   : boolean;
     FFileStream     : TFileStream;
     FDatasetReader  : TDataPacketReader;
@@ -654,7 +654,7 @@
     property ReadOnly : Boolean read FReadOnly write SetReadOnly default false;
     property ManualMergeChangeLog : Boolean read FManualMergeChangeLog write FManualMergeChangeLog default False;
   published
-    property FileName : string read FFileName write FFileName;
+    property FileName : TFileName read FFileName write FFileName;
     property PacketRecords : Integer read FPacketRecords write SetPacketRecords default 10;
     property OnUpdateError: TResolverErrorEvent read FOnUpdateError write SetOnUpdateError;
     property IndexDefs : TIndexDefs read GetIndexDefs;
bufdataset.pas.patch (1,085 bytes)

Michael Van Canneyt

2018-03-17 18:51

administrator   ~0107213

Fixed, thanks for the patch.

wp

2018-03-17 22:24

reporter   ~0107217

Thank you

Issue History

Date Modified Username Field Change
2018-03-17 16:56 wp New Issue
2018-03-17 16:57 wp File Added: bufdataset.pas.patch
2018-03-17 18:51 Michael Van Canneyt Fixed in Revision => 38553
2018-03-17 18:51 Michael Van Canneyt Note Added: 0107213
2018-03-17 18:51 Michael Van Canneyt Status new => resolved
2018-03-17 18:51 Michael Van Canneyt Fixed in Version => 3.1.1
2018-03-17 18:51 Michael Van Canneyt Resolution open => fixed
2018-03-17 18:51 Michael Van Canneyt Assigned To => Michael Van Canneyt
2018-03-17 18:51 Michael Van Canneyt Target Version => 3.2.0
2018-03-17 22:24 wp Note Added: 0107217
2018-03-17 22:24 wp Status resolved => closed