View Issue Details

IDProjectCategoryView StatusLast Update
0033513LazarusPackagespublic2018-03-25 20:05
ReporterStephanoAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.9 (SVN)Product Build 
Target VersionFixed in Version1.9 (SVN) 
Summary0033513: fpreport designer doesn't build
Descriptionpatch attached
TagsNo tags attached.
Fixed in Revision57564.
LazTarget-
Widgetset
Attached Files
  • patch1.diff (650 bytes)
    Index: components/fpreport/design/frmfpreportdesignermain.pp
    ===================================================================
    --- components/fpreport/design/frmfpreportdesignermain.pp	(revision 57563)
    +++ components/fpreport/design/frmfpreportdesignermain.pp	(working copy)
    @@ -1509,7 +1509,7 @@
         if (FReport.Owner<>Self) and (OldName<>'') then
           FReport.Name:=OldName;
         FFilename:=AFileName;
    -    if Assigned(errs) and Errs.Count>0 then
    +    if Assigned(errs) and (Errs.Count>0) then
           MessageDlg(SErrAccessingData,Format(SErrAccessingDataDetails,[Errs.Text]),mtWarning,[mbOK],'');
         FLoadModified:=rs.IsModified;
       finally
    
    patch1.diff (650 bytes)

Activities

Stephano

2018-03-25 19:58

developer  

patch1.diff (650 bytes)
Index: components/fpreport/design/frmfpreportdesignermain.pp
===================================================================
--- components/fpreport/design/frmfpreportdesignermain.pp	(revision 57563)
+++ components/fpreport/design/frmfpreportdesignermain.pp	(working copy)
@@ -1509,7 +1509,7 @@
     if (FReport.Owner<>Self) and (OldName<>'') then
       FReport.Name:=OldName;
     FFilename:=AFileName;
-    if Assigned(errs) and Errs.Count>0 then
+    if Assigned(errs) and (Errs.Count>0) then
       MessageDlg(SErrAccessingData,Format(SErrAccessingDataDetails,[Errs.Text]),mtWarning,[mbOK],'');
     FLoadModified:=rs.IsModified;
   finally
patch1.diff (650 bytes)

Michael Van Canneyt

2018-03-25 20:03

administrator   ~0107416

I had already discovered that I committed too early. Thanks !

Issue History

Date Modified Username Field Change
2018-03-25 19:58 Stephano New Issue
2018-03-25 19:58 Stephano Status new => assigned
2018-03-25 19:58 Stephano Assigned To => Michael Van Canneyt
2018-03-25 19:58 Stephano File Added: patch1.diff
2018-03-25 20:03 Michael Van Canneyt Fixed in Revision => 57564.
2018-03-25 20:03 Michael Van Canneyt Note Added: 0107416
2018-03-25 20:03 Michael Van Canneyt Status assigned => resolved
2018-03-25 20:03 Michael Van Canneyt Fixed in Version => 1.9 (SVN)
2018-03-25 20:03 Michael Van Canneyt Resolution open => fixed
2018-03-25 20:05 Stephano Status resolved => closed