View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0033922 | FPC | Database | public | 2018-06-28 09:11 | 2018-06-28 09:58 |
Reporter | Ondrej Pokorny | Assigned To | Michael Van Canneyt | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Product Build | ||||
Target Version | 3.2.0 | Fixed in Version | 3.1.1 | ||
Summary | 0033922: MySQL: make EscapeString protected | ||||
Description | The attached patch makes EscapeString protected so that it can be used in overriden functions (e.g. GetAsSQLText). | ||||
Tags | No tags attached. | ||||
Fixed in Revision | 39318 | ||||
FPCOldBugId | |||||
FPCTarget | |||||
Attached Files |
|
|
MySQL-escapestring-protected-01.patch (959 bytes)
Index: packages/fcl-db/src/sqldb/mysql/mysqlconn.inc =================================================================== --- packages/fcl-db/src/sqldb/mysql/mysqlconn.inc (revision 39317) +++ packages/fcl-db/src/sqldb/mysql/mysqlconn.inc (working copy) @@ -117,12 +117,12 @@ function GetServerStatus: String; procedure ConnectMySQL(var HMySQL: PMySQL); procedure ExecuteDirectMySQL(const query : string); - function EscapeString(const Str : string) : string; protected Procedure ConnectToServer; virtual; Procedure SelectDatabase; virtual; function MySQLDataType(AField: PMYSQL_FIELD; var NewType: TFieldType; var NewSize: Integer): Boolean; function MySQLWriteData(AField: PMYSQL_FIELD; FieldDef: TFieldDef; Source, Dest: PChar; Len: integer; out CreateBlob : boolean): Boolean; + function EscapeString(const Str : string) : string; // SQLConnection methods procedure DoInternalConnect; override; |
|
Applied, thank you! |
|
Thank you! |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-06-28 09:11 | Ondrej Pokorny | New Issue | |
2018-06-28 09:11 | Ondrej Pokorny | File Added: MySQL-escapestring-protected-01.patch | |
2018-06-28 09:26 | Michael Van Canneyt | Assigned To | => Michael Van Canneyt |
2018-06-28 09:26 | Michael Van Canneyt | Status | new => assigned |
2018-06-28 09:54 | Michael Van Canneyt | Fixed in Revision | => 39318 |
2018-06-28 09:54 | Michael Van Canneyt | Note Added: 0109091 | |
2018-06-28 09:54 | Michael Van Canneyt | Status | assigned => resolved |
2018-06-28 09:54 | Michael Van Canneyt | Fixed in Version | => 3.1.1 |
2018-06-28 09:54 | Michael Van Canneyt | Resolution | open => fixed |
2018-06-28 09:54 | Michael Van Canneyt | Target Version | => 3.2.0 |
2018-06-28 09:58 | Ondrej Pokorny | Note Added: 0109092 | |
2018-06-28 09:58 | Ondrej Pokorny | Status | resolved => closed |