View Issue Details

IDProjectCategoryView StatusLast Update
0034118FPCPackagespublic2018-08-12 18:46
ReporterAlexey Tor.Assigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version3.1.1Product Build 
Target Version3.2.0Fixed in Version3.1.1 
Summary0034118: RegExpr: optimize NotLetter
Description
   NOTLETTER:
      while (Result < TheMax) and
         not IsWordChar(scan^)  //###0.940
     {   not ((scan^ >= 'a') and (scan^ <= 'z') !! I've forgotten (>='0') and (<='9')
         or (scan^ >= 'A') and (scan^ <= 'Z')
         or (scan^ = '_'))} do begin
        inc (Result);
        inc (scan);
       end;

  
this is strange: first IsWordChar check (it checks A..Z _)
and then check for A..Z and _.
2nd check can be removed.
TagsNo tags attached.
Fixed in Revision39608
FPCOldBugId
FPCTarget
Attached Files

Activities

Alexey Tor.

2018-08-11 21:01

reporter   ~0109980

ops.... 2nd check is commented so I made mistake. maybe cleanup it.

Michael Van Canneyt

2018-08-12 10:56

administrator   ~0109989

The second check was already commented out.
Maybe check your syntax highlighter ;)

I reformatted the code somewhat and removed the commented code.

Issue History

Date Modified Username Field Change
2018-08-11 21:00 Alexey Tor. New Issue
2018-08-11 21:01 Alexey Tor. Note Added: 0109980
2018-08-12 01:33 Michael Van Canneyt Assigned To => Michael Van Canneyt
2018-08-12 01:33 Michael Van Canneyt Status new => assigned
2018-08-12 10:56 Michael Van Canneyt Fixed in Revision => 39608
2018-08-12 10:56 Michael Van Canneyt Note Added: 0109989
2018-08-12 10:56 Michael Van Canneyt Status assigned => resolved
2018-08-12 10:56 Michael Van Canneyt Fixed in Version => 3.1.1
2018-08-12 10:56 Michael Van Canneyt Resolution open => fixed
2018-08-12 10:56 Michael Van Canneyt Target Version => 3.2.0
2018-08-12 18:46 Alexey Tor. Status resolved => closed